From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, swati2.sharma@intel.com,
sameer.lattannavar@intel.com, pranay.samala@intel.com
Subject: [PATCH i-g-t] tests/kms_plane:Add more logs to skips/failure
Date: Thu, 21 Nov 2024 18:12:14 +0530 [thread overview]
Message-ID: <20241121124214.1929042-1-pranay.samala@intel.com> (raw)
Having some logs for test failures and skips would
make debugging much easier.
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
tests/kms_plane.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 77a669dc5..383149564 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -293,8 +293,11 @@ test_plane_position_with_output(data_t *data,
create_fb_for_mode(data, mode, &green, &rect, 1, &primary_fb);
igt_plane_set_fb(primary, &primary_fb);
- if (!igt_plane_has_format_mod(sprite, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR))
+ if (!igt_plane_has_format_mod(sprite, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR)) {
+ igt_info("plane-%d does not supports XRGB format and Linear modifier\n",
+ sprite->index);
return;
+ }
igt_create_color_fb(data->drm_fd,
64, 64, /* width, height */
@@ -493,7 +496,7 @@ test_plane_panning(data_t *data, enum pipe pipe)
mode_found = true;
break;
}
- igt_require(mode_found);
+ igt_require_f(mode_found, "All connector modes are skipped due to low memory\n");
if (data->flags & TEST_PANNING_TOP_LEFT)
test_grab_crc(data, output, pipe, &red, data->flags, &ref_crc);
@@ -1263,13 +1266,14 @@ static void test_planar_settings(data_t *data)
* If here is added non-intel tests below require will need to be
* changed to if(..)
*/
- igt_require(data->display.is_atomic);
+ igt_require_f(data->display.is_atomic, "Atomic mode-set not supported\n");
igt_require_intel(data->drm_fd);
devid = intel_get_drm_devid(data->drm_fd);
- igt_require(intel_display_ver(devid) >= 9);
+ igt_require_f(intel_display_ver(devid) >= 9, "Requires Intel display version 9 or above\n");
output = igt_get_single_output_for_pipe(&data->display, pipe);
- igt_require(output);
+ igt_require_f(output, "Output-%s is not compatible with pipe-%s\n",
+ data->output->name, kmstest_pipe_name(pipe));
igt_output_set_pipe(output, pipe);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
--
2.34.1
next reply other threads:[~2024-11-21 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 12:42 Pranay Samala [this message]
2024-11-21 16:23 ` ✓ Xe.CI.BAT: success for tests/kms_plane:Add more logs to skips/failure Patchwork
2024-11-21 16:38 ` ✗ i915.CI.BAT: failure " Patchwork
2024-11-22 0:26 ` ✗ Xe.CI.Full: " Patchwork
2024-11-22 5:51 ` [PATCH i-g-t] " B, Jeevan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121124214.1929042-1-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox