Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, swati2.sharma@intel.com,
	jeevan.b@intel.com, sameer.lattannavar@intel.com,
	pranay.samala@intel.com
Subject: [PATCH i-g-t v2 1/2] tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do hflip with tile4
Date: Fri, 22 Nov 2024 11:03:59 +0530	[thread overview]
Message-ID: <20241122053400.1931176-2-pranay.samala@intel.com> (raw)
In-Reply-To: <20241122053400.1931176-1-pranay.samala@intel.com>

Intel display version 20 onwards, Tile4 no longer can be used with
horizontal flip.

Bspec: 69853

v2: Fix the shadowing global declaration warn (Jeevan)

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_big_fb.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tests/intel/kms_big_fb.c b/tests/intel/kms_big_fb.c
index 7da3d12d4..67ab85852 100644
--- a/tests/intel/kms_big_fb.c
+++ b/tests/intel/kms_big_fb.c
@@ -965,6 +965,19 @@ static const struct {
 	{ 0, "" },
 	{ IGT_REFLECT_X, "-hflip" },
 };
+
+static bool test_requirements(data_t *input_data, int l)
+{
+	/* Intel display version 20 onwards cannot do reflect-x with tile4 */
+	if (!(!is_intel_device(input_data->drm_fd) ||
+	      intel_display_ver(intel_get_drm_devid(input_data->drm_fd)) < 20 ||
+	      !(fliptab[l].flip == IGT_REFLECT_X &&
+	      input_data->modifier == I915_FORMAT_MOD_4_TILED)))
+		return false;
+
+	return true;
+}
+
 igt_main
 {
 	igt_fixture {
@@ -1123,6 +1136,8 @@ igt_main
 					igt_describe("test async flip on maximum hardware supported stride length for given bpp and modifiers.");
 					igt_subtest_f("%s-max-hw-stride-%dbpp-rotate-%d%s-async-flip", modifiers[i].name,
 						formats[j].bpp, rotations[k].angle, fliptab[l].flipname) {
+							igt_require_f(test_requirements(&data, l),
+								      "Can't use reflect-x with Tile4 on intel display version 20+\n");
 							igt_require(igt_has_drm_cap(data.drm_fd, DRM_CAP_ASYNC_PAGE_FLIP));
 							data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width);
 							test_scanout(&data);
-- 
2.34.1


  reply	other threads:[~2024-11-22  5:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22  5:33 [PATCH i-g-t v2 0/2] tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do hflip with tile4 Pranay Samala
2024-11-22  5:33 ` Pranay Samala [this message]
2024-11-26  4:51   ` [PATCH i-g-t v2 1/2] " B, Jeevan
2024-11-22  5:34 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala
2024-11-22  6:43 ` ✗ Xe.CI.BAT: failure for tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do hflip with tile4 (rev2) Patchwork
2024-11-22  8:01 ` ✓ i915.CI.BAT: success " Patchwork
2024-11-22 22:38 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-26 23:21   ` Matt Roper
2024-11-24 14:40 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241122053400.1931176-2-pranay.samala@intel.com \
    --to=pranay.samala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=sameer.lattannavar@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox