From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, swati2.sharma@intel.com,
jeevan.b@intel.com, sameer.lattannavar@intel.com,
pranay.samala@intel.com
Subject: [PATCH i-g-t] tests/intel/kms_dsc: Add meaningfull skip message
Date: Mon, 25 Nov 2024 08:54:20 +0530 [thread overview]
Message-ID: <20241125032420.1945935-1-pranay.samala@intel.com> (raw)
This patch adds a proper skip message which will be
easy to debug.
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
tests/intel/kms_dsc.c | 36 ++++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
index 9b48caf76..65b0d262c 100644
--- a/tests/intel/kms_dsc.c
+++ b/tests/intel/kms_dsc.c
@@ -280,21 +280,6 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
data->output = output;
data->pipe = pipe;
- if (!is_dsc_supported_by_sink(data->drm_fd, data->output) ||
- !check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe) ||
- igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
- continue;
-
- if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
- (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
- data->output, data->output_format)))
- continue;
-
- if ((test_type & TEST_DSC_FRACTIONAL_BPP) &&
- (!is_dsc_fractional_bpp_supported(data->disp_ver,
- data->drm_fd, data->output)))
- continue;
-
if (test_type & TEST_DSC_OUTPUT_FORMAT)
snprintf(&name[0][0], LEN, "-%s", kmstest_dsc_output_format_str(data->output_format));
if (test_type & TEST_DSC_FORMAT)
@@ -303,8 +288,27 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
snprintf(&name[2][0], LEN, "-%dbpc", data->input_bpc);
igt_dynamic_f("pipe-%s-%s%s%s%s", kmstest_pipe_name(data->pipe), data->output->name,
- &name[0][0], &name[1][0], &name[2][0])
+ &name[0][0], &name[1][0], &name[2][0]) {
+ if (!is_dsc_supported_by_sink(data->drm_fd, data->output) ||
+ !check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe) ||
+ igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
+ continue;
+
+ if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
+ (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
+ data->output, data->output_format))) {
+ igt_skip("DSC %s output format not supported on pipe-%s\n",
+ kmstest_dsc_output_format_str(data->output_format),
+ kmstest_pipe_name(data->pipe));
+ continue;
+ }
+
+ if ((test_type & TEST_DSC_FRACTIONAL_BPP) &&
+ (!is_dsc_fractional_bpp_supported(data->disp_ver,
+ data->drm_fd, data->output)))
+ continue;
update_display(data, test_type);
+ }
if (data->limited)
break;
--
2.34.1
next reply other threads:[~2024-11-25 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 3:24 Pranay Samala [this message]
2024-11-25 4:14 ` ✓ Xe.CI.BAT: success for tests/intel/kms_dsc: Add meaningfull skip message Patchwork
2024-11-25 4:29 ` ✓ i915.CI.BAT: " Patchwork
2024-11-25 6:10 ` ✗ i915.CI.Full: failure " Patchwork
2024-11-25 7:28 ` ✗ Xe.CI.Full: " Patchwork
2024-11-25 17:36 ` [PATCH i-g-t] " B, Jeevan
2024-11-29 18:22 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125032420.1945935-1-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox