From: Matt Roper <matthew.d.roper@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH i-g-t] tests/intel/xe_fault_injection: Pick a valid PAT index for vm_bind
Date: Mon, 25 Nov 2024 10:54:32 -0800 [thread overview]
Message-ID: <20241125185432.1187252-1-matthew.d.roper@intel.com> (raw)
The vm_bind helper function in the fault injection test failed to
specify a PAT index to use for the bind, effectively leaving the index
as 0. On Xe2 and Xe3 platforms, index 0 provides non-coherent behavior
which is incompatible with vm_bind operations on userptr, resulting in a
test failure before the test even got to the point of intentionally
injecting errors.
Fixes: 13e3d5126 ("tests/intel/xe_fault_injection: Inject errors during vm bind IOCTL")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3499
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
tests/intel/xe_fault_injection.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
index 7d6c90276..7ae941367 100644
--- a/tests/intel/xe_fault_injection.c
+++ b/tests/intel/xe_fault_injection.c
@@ -18,6 +18,7 @@
#include "igt_kmod.h"
#include "igt_sysfs.h"
#include "lib/igt_syncobj.h"
+#include "lib/intel_pat.h"
#include "xe/xe_ioctl.h"
#include "xe/xe_query.h"
@@ -238,6 +239,7 @@ simple_vm_bind(int fd, uint32_t vm)
.bind.range = BO_SIZE,
.bind.addr = BO_ADDR,
.bind.op = DRM_XE_VM_BIND_OP_MAP_USERPTR,
+ .bind.pat_index = intel_get_pat_idx_wb(fd),
.bind.flags = 0,
.num_syncs = 1,
.syncs = (uintptr_t)&syncobj,
--
2.47.0
next reply other threads:[~2024-11-25 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 18:54 Matt Roper [this message]
2024-11-26 1:03 ` ✓ Xe.CI.BAT: success for tests/intel/xe_fault_injection: Pick a valid PAT index for vm_bind Patchwork
2024-11-26 1:24 ` ✓ i915.CI.BAT: " Patchwork
2024-11-26 3:04 ` ✗ i915.CI.Full: failure " Patchwork
2024-11-29 16:19 ` Kamil Konieczny
2024-11-26 4:43 ` ✗ Xe.CI.Full: " Patchwork
2024-11-29 16:36 ` Kamil Konieczny
2024-11-29 16:18 ` [PATCH i-g-t] " Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125185432.1187252-1-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox