From: Matt Roper <matthew.d.roper@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH i-g-t] tests/intel/xe_wedged: Manage verbosity of GT reset fault injection
Date: Tue, 26 Nov 2024 15:02:40 -0800 [thread overview]
Message-ID: <20241126230240.1780940-1-matthew.d.roper@intel.com> (raw)
igt@xe_wedged@basic-wedged triggers a GT reset and uses fault injection
to ensure that the reset artificially fails. This works as expected,
but depending on the value in the fail_gt_reset/verbose debugfs
when the test starts, different levels of output may be printed to
dmesg. The test already marks the general "declared wedged" message as
expected so that igt_runner won't try to flag those as test errors, but
if verbose=2, then the fault injection framework will also issue print
dump_stack() output which gets flagged as a problem by igt_runner.
Explicitly set verbose=1 when running the test so that we get the
general wedged message and fault injection notification (which we
already tell igt_runner to ignore), but skip the unnecessary stack dump
that just confuses the runner.
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2919
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
tests/intel/xe_wedged.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/intel/xe_wedged.c b/tests/intel/xe_wedged.c
index 88e5d47f2..0db8c8eba 100644
--- a/tests/intel/xe_wedged.c
+++ b/tests/intel/xe_wedged.c
@@ -213,6 +213,7 @@ igt_main
igt_subtest("basic-wedged") {
igt_require(igt_debugfs_exists(fd, "fail_gt_reset/probability",
O_RDWR));
+ igt_debugfs_write(fd, "fail_gt_reset/verbose", "1");
igt_assert_eq(simple_ioctl(fd), 0);
ignore_wedged_in_dmesg();
--
2.47.0
next reply other threads:[~2024-11-26 23:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 23:02 Matt Roper [this message]
2024-11-26 23:32 ` ✓ Xe.CI.BAT: success for tests/intel/xe_wedged: Manage verbosity of GT reset fault injection Patchwork
2024-11-26 23:46 ` ✓ i915.CI.BAT: " Patchwork
2024-11-27 0:30 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-27 23:16 ` Matt Roper
2024-11-27 1:13 ` ✗ i915.CI.Full: " Patchwork
2024-11-28 11:05 ` [PATCH i-g-t] " Rodrigo Vivi
2024-11-28 11:40 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126230240.1780940-1-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox