Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
	"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Chris Wilson" <chris.p.wilson@linux.intel.com>,
	"Janusz Krzysztofik" <janusz.krzysztofik@linux.intel.com>
Subject: [PATCH i-g-t v2 0/2] tests/gem_mmap_offset: Fix OOM hits
Date: Thu, 28 Nov 2024 12:16:34 +0100	[thread overview]
Message-ID: <20241128111822.836089-4-janusz.krzysztofik@linux.intel.com> (raw)

The 'clear' subtest used to exercise correctness of object memory clearing
on passing a batch with the object to GPU for processing.  However, commit
e25913a1a79d ("i915/gem_mmap_offset: Ignore ENOSPC error for making
residency execbuf"), while resolving an issue of unnecessary failures on
ENOSPC errors, introduced an alternative method of clearing the object
memory, with random selection of one of those methods on each iteration.
The new method expects the memory to be cleared in pagefault handler path.
Since those two methods may give different results, mixing them in one
exercise may make the picture unclear, especially if something goes wrong.

The exercise is executed in several parallel threads, one per CPU.  Each
thread repeats the exercise in a time only limited loop, with no delay
between consecutive iterations.  In case of passing system memory objects
to execbuf, that happens to exhaust all available physical memory, which
is neither the matter nor the goal nor requirement of the exercise.

Move the pagefault method, free from the issue, to a new separate subtest,
and make sure sufficient amount of physical memory is available before
calling another execbuf.

v2: Limit the scope of the fix to SMEM exercise.

Janusz Krzysztofik (2):
  tests/gem_mmap_offset: Split 'clear' subtest
  tests/gem_mmap_offset: Fix OOM hits

 tests/intel/gem_mmap_offset.c | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

-- 
2.47.0


             reply	other threads:[~2024-11-28 11:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 11:16 Janusz Krzysztofik [this message]
2024-11-28 11:16 ` [PATCH i-g-t v2 1/2] tests/gem_mmap_offset: Split 'clear' subtest Janusz Krzysztofik
2024-11-28 11:56   ` Andi Shyti
2024-11-28 11:16 ` [PATCH i-g-t v2 2/2] tests/gem_mmap_offset: Fix OOM hits Janusz Krzysztofik
2024-11-28 11:56   ` Andi Shyti
2024-11-28 13:56 ` ✓ Xe.CI.BAT: success for tests/gem_mmap_offset: Fix OOM hits (rev2) Patchwork
2024-11-28 14:05 ` ✓ i915.CI.BAT: " Patchwork
2024-11-28 17:05 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-29 15:06   ` Janusz Krzysztofik
2024-11-28 17:16 ` ✗ i915.CI.Full: " Patchwork
2024-11-29 14:59   ` Janusz Krzysztofik
2024-12-03  4:37     ` Illipilli, TejasreeX
2024-12-02 13:07 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241128111822.836089-4-janusz.krzysztofik@linux.intel.com \
    --to=janusz.krzysztofik@linux.intel.com \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox