From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>,
Jeevan B <jeevan.b@intel.com>,
Kunal Joshi <kunal1.joshi@intel.com>,
Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 2/4] tests/kms_async_flips: Skip async flips on joiner output
Date: Fri, 29 Nov 2024 09:57:44 +0530 [thread overview]
Message-ID: <20241129042746.701796-3-jeevan.b@intel.com> (raw)
In-Reply-To: <20241129042746.701796-1-jeevan.b@intel.com>
From: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
Async flips are disallowed with joiner, but the test commit still
goes through and causes failures. Update the tests to skip on
joiner outputs.
V2: Skip tests only on joiner outputs (Kunal).
V3: Add a todo to remove workaround when async flips with joiner is
supported in kernel.
V4: Add proper FIXME, improve log message and
move igt_is_joiner mode to library (Swati).
Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_async_flips.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 5dec71291..3ce6e18d7 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -653,6 +653,12 @@ static void run_test(data_t *data, void (*test)(data_t *))
data->allow_fail = false;
data->modifier = default_modifier(data);
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {
+ /*
+ * FIXME: joiner+async flip is busted currently in KMD.
+ * Remove this check once the issues are fixed in KMD.
+ */
+ igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
+ "Skipping, async flip not supported on joiner mode\n");
test_init_fbs(data);
test(data);
}
@@ -674,8 +680,16 @@ static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
igt_dynamic_f("pipe-%s-%s-%s", kmstest_pipe_name(data->pipe),
data->output->name,
igt_fb_modifier_name(data->modifier)) {
- test_init_fbs(data);
- test(data);
+ /*
+ * FIXME: joiner+async flip is busted currently in KMD.
+ * Remove this check once the issues are fixed in KMD.
+ */
+ igt_skip_on_f(is_joiner_mode(data->drm_fd,
+ data->output),
+ "Skipping, async flip not supported "
+ "on joiner mode\n");
+ test_init_fbs(data);
+ test(data);
}
}
}
--
2.25.1
next prev parent reply other threads:[~2024-11-29 4:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 4:27 [PATCH i-g-t 0/4] Skip test if joiner display is connected Jeevan B
2024-11-29 4:27 ` [PATCH i-g-t 1/4] lib/igt_kms: Add is_joiner_mode function Jeevan B
2024-11-29 4:27 ` Jeevan B [this message]
2024-11-29 4:27 ` [PATCH i-g-t 3/4] tests/kms_display_modes: Skip test if joiner display is connected Jeevan B
2024-11-29 4:27 ` [PATCH i-g-t 4/4] lib/igt_kms: Add 6k resolution support for a single CRTC Jeevan B
2024-11-29 4:49 ` ✓ Xe.CI.BAT: success for Skip test if joiner display is connected (rev5) Patchwork
2024-11-29 5:17 ` ✓ i915.CI.BAT: " Patchwork
2024-11-29 6:43 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-01 15:26 ` B, Jeevan
2024-11-29 15:55 ` ✗ Xe.CI.Full: " Patchwork
2024-12-01 15:26 ` B, Jeevan
-- strict thread matches above, loose matches on Subject: below --
2024-12-04 6:09 [PATCH i-g-t 0/4] Skip test if joiner display is connected Jeevan B
2024-12-04 6:09 ` [PATCH i-g-t 2/4] tests/kms_async_flips: Skip async flips on joiner output Jeevan B
2024-11-27 8:13 [PATCH i-g-t 0/4] Skip test if joiner display is connected Jeevan B
2024-11-27 8:13 ` [PATCH i-g-t 2/4] tests/kms_async_flips: Skip async flips on joiner output Jeevan B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129042746.701796-3-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=santhosh.reddy.guddati@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox