Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com,
	alex.zuo@intel.com, kamil.konieczny@linux.intel.com,
	vinay.belgaumkar@intel.com
Subject: [PATCH v8 0/4] test/intel/xe_sysfs: Restore sysfs params correctly
Date: Mon,  2 Dec 2024 18:08:12 +0000	[thread overview]
Message-ID: <20241202180816.47538-1-jonathan.cavitt@intel.com> (raw)

The xe_sysfs_timeslice_duration, xe_sysfs_preempt_timeout, and
xe_sysfs_scheduler tests do not correctly restore modified sysfs params on
test failure.
Additionally, xe_sysfs_timeslice_duration modifies but does not restore
preempt_timeout_us.
Finally, while xe_sysfs_scheduler does attempt to restore all modified
sysfs params at the end of the tests, no guarantee is made that the
restorations are successful.
Repair these issues.

v3: Fix several formatting issues (Kamil)

v4: Do not compare possibly unassigned variable (Kamil)
    Whitespace and commit name fixes (Kamil)

v5: Add new helper funciton, igt_sysfs_get_next_engine
    Fix igt_sysfs_scanf/printf usage in tests (Kamil)

v6: Replace helper function igt_sysfs_get_next_engine with new helper
    functions that return and destroy engine lists (Kamil)

v7: Also fix xe_sysfs_scheduler

v8: Update igt_sysfs_get_engine_list to no longer require reporting
    size (Kamil)
    Remove assertion for some sysfs writes to succeed, as we only
    require that the end result is correct.

Jonathan Cavitt (4):
  lib/igt_sysfs: Add engine list helpers
  tests/intel/xe_sysfs*: Restore values on test failure
  tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout
  tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored

 lib/igt_sysfs.c                           | 60 ++++++++++++++++
 lib/igt_sysfs.h                           |  3 +
 tests/intel/xe_sysfs_preempt_timeout.c    | 64 ++++++++++++++---
 tests/intel/xe_sysfs_scheduler.c          | 88 ++++++++++++++++++++---
 tests/intel/xe_sysfs_timeslice_duration.c | 79 +++++++++++++++++---
 5 files changed, 264 insertions(+), 30 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-12-02 18:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 18:08 Jonathan Cavitt [this message]
2024-12-02 18:08 ` [PATCH v8 1/4] lib/igt_sysfs: Add engine list helpers Jonathan Cavitt
2024-12-03 18:31   ` Kamil Konieczny
2024-12-03 22:24     ` Cavitt, Jonathan
2024-12-04  7:25       ` Kamil Konieczny
2024-12-02 18:08 ` [PATCH v8 2/4] tests/intel/xe_sysfs*: Restore values on test failure Jonathan Cavitt
2024-12-02 18:08 ` [PATCH v8 3/4] tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout Jonathan Cavitt
2024-12-02 18:08 ` [PATCH v8 4/4] tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored Jonathan Cavitt
2024-12-03 18:36   ` Kamil Konieczny
2024-12-02 19:19 ` ✓ i915.CI.BAT: success for test/intel/xe_sysfs: Restore sysfs params correctly Patchwork
2024-12-02 19:29 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-02 21:12 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-02 23:10 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241202180816.47538-1-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox