From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 324AFE6C610 for ; Tue, 3 Dec 2024 22:32:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6142110EB59; Tue, 3 Dec 2024 22:32:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Cyv9yuN1"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDC8510E252 for ; Tue, 3 Dec 2024 22:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733265135; x=1764801135; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=/aPaU2WNUQ7qvwTxECnPnVbCuNSsU5zn52nOHZnIs4A=; b=Cyv9yuN112OMAN6Kfpw12epVBF9c/o9cbNAa0ifqRXsbvIqyIX9Fzxbs NDX7wdUkqiWHByBZBlp/qtELasffOJH7TTvelDP8TB2p0wsXFep9YBZWD sYLXjV32GFz8NcEUPT3DhzwQGPO8YvZ55ppDVFWkNUCV2U+6IRt3Mw//I DWuiPKglDBYs0bjBvRuSvtyJ7s041slQ/1Klpzd8q667TZUPWRpMyb0Hc KN5sMiOdnzKa/F0Tc1aBPhhi4yxgWveL9BsixU+vaKhihnZhjM/fZDHY9 4sN1Yny6hVJmqxaeNXpWylSkE5PpAt7cMpsi4FXB0Qdyi+wKSXtAIsNYN Q==; X-CSE-ConnectionGUID: WzU4XoqQT3uH7Zhx5gGx1w== X-CSE-MsgGUID: ygtm5rwhStugyPEMtRD7wg== X-IronPort-AV: E=McAfee;i="6700,10204,11275"; a="44119884" X-IronPort-AV: E=Sophos;i="6.12,206,1728975600"; d="scan'208";a="44119884" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2024 14:32:14 -0800 X-CSE-ConnectionGUID: rV73UJUmQI6W+vOMhBIaHQ== X-CSE-MsgGUID: dDfEXtuwSj+KhU2fTnIxLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="98585823" Received: from dut4066lnl.fm.intel.com ([10.105.8.83]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2024 14:32:14 -0800 From: Jonathan Cavitt To: igt-dev@lists.freedesktop.org Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com, alex.zuo@intel.com, kamil.konieczny@linux.intel.com, vinay.belgaumkar@intel.com Subject: [PATCH v9 0/4] test/intel/xe_sysfs: Restore sysfs params correctly Date: Tue, 3 Dec 2024 22:32:09 +0000 Message-ID: <20241203223213.81798-1-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The xe_sysfs_timeslice_duration, xe_sysfs_preempt_timeout, and xe_sysfs_scheduler tests do not correctly restore modified sysfs params on test failure. Additionally, xe_sysfs_timeslice_duration modifies but does not restore preempt_timeout_us. Finally, while xe_sysfs_scheduler does attempt to restore all modified sysfs params at the end of the tests, no guarantee is made that the restorations are successful. Repair these issues. v3: Fix several formatting issues (Kamil) v4: Do not compare possibly unassigned variable (Kamil) Whitespace and commit name fixes (Kamil) v5: Add new helper funciton, igt_sysfs_get_next_engine Fix igt_sysfs_scanf/printf usage in tests (Kamil) v6: Replace helper function igt_sysfs_get_next_engine with new helper functions that return and destroy engine lists (Kamil) v7: Also fix xe_sysfs_scheduler v8: Update igt_sysfs_get_engine_list to no longer require reporting size (Kamil) Remove assertion for some sysfs writes to succeed, as we only require that the end result is correct. v9: Store engine lists (Kamil) Jonathan Cavitt (4): lib/igt_sysfs: Add engine list helpers tests/intel/xe_sysfs*: Restore values on test failure tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored lib/igt_sysfs.c | 61 ++++++++++++++++ lib/igt_sysfs.h | 3 + tests/intel/xe_sysfs_preempt_timeout.c | 65 ++++++++++++++--- tests/intel/xe_sysfs_scheduler.c | 89 ++++++++++++++++++++--- tests/intel/xe_sysfs_timeslice_duration.c | 80 +++++++++++++++++--- 5 files changed, 268 insertions(+), 30 deletions(-) -- 2.43.0