From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com,
alex.zuo@intel.com, kamil.konieczny@linux.intel.com,
vinay.belgaumkar@intel.com, tejas.upadhyay@intel.com
Subject: [PATCH v10 0/4] test/intel/xe_sysfs: Restore sysfs params correctly
Date: Wed, 4 Dec 2024 22:23:43 +0000 [thread overview]
Message-ID: <20241204222347.108788-1-jonathan.cavitt@intel.com> (raw)
The xe_sysfs_timeslice_duration, xe_sysfs_preempt_timeout, and
xe_sysfs_scheduler tests do not correctly restore modified sysfs params on
test failure.
Additionally, xe_sysfs_timeslice_duration modifies but does not restore
preempt_timeout_us.
Finally, while xe_sysfs_scheduler does attempt to restore all modified
sysfs params at the end of the tests, no guarantee is made that the
restorations are successful.
Repair these issues.
v3: Fix several formatting issues (Kamil)
v4: Do not compare possibly unassigned variable (Kamil)
Whitespace and commit name fixes (Kamil)
v5: Add new helper funciton, igt_sysfs_get_next_engine
Fix igt_sysfs_scanf/printf usage in tests (Kamil)
v6: Replace helper function igt_sysfs_get_next_engine with new helper
functions that return and destroy engine lists (Kamil)
v7: Also fix xe_sysfs_scheduler
v8: Update igt_sysfs_get_engine_list to no longer require reporting
size (Kamil)
Remove assertion for some sysfs writes to succeed, as we only
require that the end result is correct.
v9: Store engine lists (Kamil)
v10: Minor formatting fix
Jonathan Cavitt (4):
lib/igt_sysfs: Add engine list helpers
tests/intel/xe_sysfs*: Restore values on test failure
tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout
tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored
lib/igt_sysfs.c | 61 ++++++++++++++++
lib/igt_sysfs.h | 3 +
tests/intel/xe_sysfs_preempt_timeout.c | 65 ++++++++++++++---
tests/intel/xe_sysfs_scheduler.c | 89 ++++++++++++++++++++---
tests/intel/xe_sysfs_timeslice_duration.c | 81 ++++++++++++++++++---
5 files changed, 269 insertions(+), 30 deletions(-)
--
2.43.0
next reply other threads:[~2024-12-04 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 22:23 Jonathan Cavitt [this message]
2024-12-04 22:23 ` [PATCH v10 1/4] lib/igt_sysfs: Add engine list helpers Jonathan Cavitt
2024-12-04 22:23 ` [PATCH v10 2/4] tests/intel/xe_sysfs*: Restore values on test failure Jonathan Cavitt
2024-12-04 22:23 ` [PATCH v10 3/4] tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout Jonathan Cavitt
2024-12-05 12:15 ` Upadhyay, Tejas
2024-12-05 15:17 ` Cavitt, Jonathan
2024-12-06 5:46 ` Upadhyay, Tejas
2024-12-04 22:23 ` [PATCH v10 4/4] tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored Jonathan Cavitt
2024-12-05 12:17 ` Upadhyay, Tejas
2024-12-04 23:25 ` ✗ i915.CI.BAT: failure for test/intel/xe_sysfs: Restore sysfs params correctly Patchwork
2024-12-06 17:14 ` Cavitt, Jonathan
2024-12-04 23:30 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-05 3:34 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-06 17:13 ` Cavitt, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204222347.108788-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=saurabhg.gupta@intel.com \
--cc=tejas.upadhyay@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox