From: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Dominik Grzegorzek" <dominik.grzegorzek@intel.com>,
"Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>
Subject: [PATCH v2 i-g-t 1/1] tests/intel/xe_eudebug_online: Fix run_online_client memory leak
Date: Thu, 5 Dec 2024 11:26:13 +0100 [thread overview]
Message-ID: <20241205102613.13524-2-dominik.karol.piatkowski@intel.com> (raw)
In-Reply-To: <20241205102613.13524-1-dominik.karol.piatkowski@intel.com>
In run_online_client, buf is created by create_uc_buf, that calls
intel_buf_create_full, that callocs and initializes it. This memory is
never freed. Fix it by adding missing intel_buf_destroy.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@intel.com>
---
tests/intel/xe_eudebug_online.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index 750350556..bf53b44ce 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -1132,6 +1132,8 @@ static void run_online_client(struct xe_eudebug_client *c)
DRM_XE_DEBUG_METADATA_PROGRAM_MODULE,
2 * sizeof(*metadata));
+ intel_buf_destroy(buf);
+
xe_eudebug_client_close_driver(c, fd);
}
--
2.34.1
next prev parent reply other threads:[~2024-12-05 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 10:26 [PATCH v2 i-g-t 0/1] tests/intel/xe_eudebug_online: Fix run_online_client memory leak Dominik Karol Piątkowski
2024-12-05 10:26 ` Dominik Karol Piątkowski [this message]
2024-12-05 10:42 ` [PATCH v2 i-g-t 1/1] " Grzegorzek, Dominik
2024-12-06 0:39 ` ✗ Xe.CI.BAT: failure for tests/intel/xe_eudebug_online: Fix run_online_client memory leak (rev2) Patchwork
2024-12-06 0:47 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-06 1:55 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-06 2:30 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205102613.13524-2-dominik.karol.piatkowski@intel.com \
--to=dominik.karol.piatkowski@intel.com \
--cc=dominik.grzegorzek@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox