Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	 Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [PATCH] tests/xe_exec_sip: increase timeout margin for tests
Date: Fri, 06 Dec 2024 09:17:48 +0100	[thread overview]
Message-ID: <20241206-xe_exec_sip_eudebug_increase_timeout_for_devcoredump-v1-1-6736edd67447@intel.com> (raw)

In case engine reset happens 4s timeout margin sometimes is not enough
and test fails. It happens mostly on LNL/BMG due to devcoredump creation.
On CI it does not pass 5s, let's increase it to 8s to be on safe side.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 tests/intel/xe_exec_sip_eudebug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_exec_sip_eudebug.c b/tests/intel/xe_exec_sip_eudebug.c
index d056a14a2d7f..c317112b4154 100644
--- a/tests/intel/xe_exec_sip_eudebug.c
+++ b/tests/intel/xe_exec_sip_eudebug.c
@@ -263,8 +263,8 @@ static void test_sip(enum shader_type shader_type, enum sip_type sip_type,
 	debugger_enabled = xe_eudebug_debugger_available(fd);
 	vm_id = xe_vm_create(fd, debugger_enabled ? DRM_XE_VM_CREATE_FLAG_LR_MODE : 0, 0);
 
-	/* Get timeout for job, and add 4s to ensure timeout processes in subtest. */
-	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 4ull * MSEC_PER_SEC;
+	/* Get timeout for job, and add 8s for devcoredump processing. */
+	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 8ull * MSEC_PER_SEC;
 	timeout *= NSEC_PER_MSEC;
 	timeout *= igt_run_in_simulation() ? 10 : 1;
 

---
base-commit: e776f39da6b3666a2834f7e02a1eed9a87f21d74
change-id: 20241206-xe_exec_sip_eudebug_increase_timeout_for_devcoredump-64e46bd9721d

Best regards,
-- 
Andrzej Hajda <andrzej.hajda@intel.com>


             reply	other threads:[~2024-12-06  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06  8:17 Andrzej Hajda [this message]
2024-12-06  8:39 ` ✗ GitLab.Pipeline: warning for tests/xe_exec_sip: increase timeout margin for tests (rev2) Patchwork
2024-12-06  9:05 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-06  9:14 ` ✗ Xe.CI.BAT: failure " Patchwork
2024-12-09  8:08   ` Hajda, Andrzej
2024-12-09  8:24     ` Saarinen, Jani
2024-12-06 10:23 ` ✗ i915.CI.Full: " Patchwork
2024-12-06 14:09 ` ✗ Xe.CI.Full: " Patchwork
2024-12-06 16:51 ` [PATCH] tests/xe_exec_sip: increase timeout margin for tests Kamil Konieczny
  -- strict thread matches above, loose matches on Subject: below --
2024-10-11 13:36 Andrzej Hajda
2024-10-14  9:53 ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241206-xe_exec_sip_eudebug_increase_timeout_for_devcoredump-v1-1-6736edd67447@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox