From: Clint Taylor <clinton.a.taylor@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t v4 7/8] XE3: tests/intel/kms_frontbuffer_tracking: fix x-tiled tests for case when there is no x-tile
Date: Fri, 6 Dec 2024 13:27:47 -0800 [thread overview]
Message-ID: <20241206212748.2101217-8-clinton.a.taylor@intel.com> (raw)
In-Reply-To: <20241206212748.2101217-1-clinton.a.taylor@intel.com>
From: "Heikkila, Juha-pekka" <juha-pekka.heikkila@intel.com>
On Xe3 display no more support x-tile and will disable such framebuffers
v2: Optimize display_ver checks (Sai Teja)
Signed-off-by: Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>
Signed-off-by: Clint Taylor <Clinton.A.Taylor@intel.com>
---
tests/intel/kms_frontbuffer_tracking.c | 25 +++++++++++++++++++++----
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index e41ee0a80..c5b3fd46f 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -2181,7 +2181,12 @@ static void setup_modeset(void)
offscreen_fb.fb = NULL;
offscreen_fb.w = 1024;
offscreen_fb.h = 1024;
- create_fbs(FORMAT_DEFAULT, opt.tiling);
+
+ /* Xe3 remove x-tile from display + */
+ if (drm.display_ver < 30)
+ create_fbs(FORMAT_DEFAULT, opt.tiling);
+ else
+ create_fbs(FORMAT_DEFAULT, TILING_4);
}
static void teardown_modeset(void)
@@ -2302,7 +2307,6 @@ static void setup_drrs(void)
static void setup_environment(void)
{
- setup_drm();
setup_modeset();
setup_fbc();
@@ -3146,6 +3150,7 @@ static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
case TILING_LINEAR:
return intel_gen(drm.devid) >= 9;
case TILING_X:
+ return (intel_get_device_info(drm.devid)->display_ver > 29) ? false : true;
case TILING_Y:
return true;
case TILING_4:
@@ -4226,9 +4231,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
igt_output_t *output;
igt_fixture {
- setup_environment();
+ setup_drm();
drm.devid = intel_get_drm_devid(drm.fd);
drm.display_ver = intel_display_ver(drm.devid);
+ setup_environment();
}
for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
@@ -4537,6 +4543,11 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
if (t.tiling == TILING_4)
igt_require(intel_get_device_info(drm.devid)->has_4tile);
+ /* Xe3 remove x-tile from display + */
+ if (t.tiling == TILING_X) {
+ igt_require(drm.display_ver < 30);
+ }
+
if (tiling_is_valid(t.feature, t.tiling))
draw_subtest(&t);
else
@@ -4568,7 +4579,13 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
t.format = FORMAT_DEFAULT;
t.flip = FLIP_PAGEFLIP;
t.method = IGT_DRAW_BLT;
- t.tiling = opt.tiling;
+
+ /* Xe3 remove x-tile from display + */
+ if (drm.display_ver < 30)
+ t.tiling = opt.tiling;
+ else
+ t.tiling = TILING_4;
+
igt_subtest("basic") {
if (!is_xe_device(drm.fd))
igt_require_gem(drm.fd);
--
2.25.1
next prev parent reply other threads:[~2024-12-06 21:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 21:27 [PATCH i-g-t v4 0/8] Initial PTL support Clint Taylor
2024-12-06 21:27 ` [PATCH i-g-t v4 1/8] PTL: lib/intel_chipset: add pantherlake definition and support Clint Taylor
2024-12-06 23:30 ` Matt Roper
2024-12-06 21:27 ` [PATCH i-g-t v4 2/8] XE3: lib/intel_pat: extend for xe3 Clint Taylor
2024-12-06 21:27 ` [PATCH i-g-t v4 3/8] XE3: tests/intel/xe_pat: " Clint Taylor
2024-12-06 21:27 ` [PATCH i-g-t v4 4/8] XE3: tests/kms_addfb_basic: fix x-tiled tests for case when there is no x-tile Clint Taylor
2024-12-06 23:46 ` Matt Roper
2024-12-06 21:27 ` [PATCH i-g-t v4 5/8] XE3: tests/intel/kms_draw_crc: " Clint Taylor
2024-12-07 0:01 ` Matt Roper
2024-12-06 21:27 ` [PATCH i-g-t v4 6/8] XE3: tests/kms_cursor_legacy: flip_vs_cursor_busy_crc was requiring any driver but used intel x-tile Clint Taylor
2024-12-07 0:10 ` Matt Roper
2024-12-06 21:27 ` Clint Taylor [this message]
2024-12-07 0:21 ` [PATCH i-g-t v4 7/8] XE3: tests/intel/kms_frontbuffer_tracking: fix x-tiled tests for case when there is no x-tile Matt Roper
2024-12-06 21:27 ` [PATCH i-g-t v4 8/8] XE3: tests/intel/kms_frontbuffer_tracking: platform based handling of x-tile cases Clint Taylor
2024-12-07 0:28 ` Matt Roper
2024-12-06 22:30 ` ✓ Xe.CI.BAT: success for Initial PTL support (rev4) Patchwork
2024-12-06 22:30 ` ✓ i915.CI.BAT: " Patchwork
2024-12-06 23:21 ` [PATCH i-g-t v4 0/8] Initial PTL support Matt Roper
2024-12-06 23:44 ` ✗ i915.CI.Full: failure for Initial PTL support (rev4) Patchwork
2024-12-07 3:05 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206212748.2101217-8-clinton.a.taylor@intel.com \
--to=clinton.a.taylor@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox