Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH i-g-t 2/3] Revert "tests/xe_oa: Drop TestOa from metric_set()"
Date: Mon,  9 Dec 2024 18:08:11 -0800	[thread overview]
Message-ID: <20241210020812.1513475-2-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20241210020812.1513475-1-ashutosh.dixit@intel.com>

This reverts commit d226604a63fbd5c37c9f5d60b6fc23acffc49f0a.

Re-instate TestOa metric set. IGT needs to work with TestOa since it has
special properties which help with OA data validation. Remaining parts of
d226604a63fb were already reverted in 4942fc57c20f ("lib/xe/oa: Re-instate
TestOa metric sets in LNL/BMG XML's").

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/intel/xe_oa.c | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 9e7c2ae1e6..c660720ea0 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -310,20 +310,15 @@ static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_cl
 	struct intel_xe_perf_metric_set *metric_set_iter;
 	struct intel_xe_perf_metric_set *test_set = NULL;
 
-	switch (hwe->engine_class) {
-	case DRM_XE_ENGINE_CLASS_RENDER:
-		test_set_name = "RenderBasic";
-		break;
-	case DRM_XE_ENGINE_CLASS_COMPUTE:
-		test_set_name = "ComputeBasic";
-		break;
-	case DRM_XE_ENGINE_CLASS_VIDEO_DECODE:
-	case DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE:
-		if (HAS_OAM(devid))
-			test_set_name = "MediaSet1";
-	default:
-		igt_assert(!"missing");
-	}
+	if (hwe->engine_class == DRM_XE_ENGINE_CLASS_RENDER ||
+	    hwe->engine_class == DRM_XE_ENGINE_CLASS_COMPUTE)
+		test_set_name = "TestOa";
+	else if ((hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_DECODE ||
+		  hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE) &&
+		 HAS_OAM(devid))
+		test_set_name = "MediaSet1";
+	else
+		igt_assert(!"reached");
 
 	igt_list_for_each_entry(metric_set_iter, &intel_xe_perf->metric_sets, link) {
 		if (strcmp(metric_set_iter->symbol_name, test_set_name) == 0) {
-- 
2.47.1


  reply	other threads:[~2024-12-10  2:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  2:08 [PATCH i-g-t 1/3] tests/intel/xe_oa: Move Xe2+ check before init_sys_info Ashutosh Dixit
2024-12-10  2:08 ` Ashutosh Dixit [this message]
2024-12-10 11:14   ` [PATCH i-g-t 2/3] Revert "tests/xe_oa: Drop TestOa from metric_set()" Kamil Konieczny
2024-12-12  1:28     ` Dixit, Ashutosh
2024-12-10  2:08 ` [PATCH i-g-t 3/3] tests/intel/xe_oa: Use buf->bo_size for xe_bo_map Ashutosh Dixit
2024-12-10  2:53 ` ✗ i915.CI.BAT: failure for series starting with [i-g-t,1/3] tests/intel/xe_oa: Move Xe2+ check before init_sys_info Patchwork
2024-12-10  3:08 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-10  4:10 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-10 11:15 ` [PATCH i-g-t 1/3] " Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210020812.1513475-2-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox