From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Marcin Bernatowicz" <marcin.bernatowicz@linux.intel.com>,
"Adam Miszczak" <adam.miszczak@linux.intel.com>,
"Jakub Kolakowski" <jakub1.kolakowski@intel.com>,
"Lukasz Laguna" <lukasz.laguna@intel.com>,
"Michał Wajdeczko" <michal.wajdeczko@intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Narasimha C V" <narasimha.c.v@intel.com>,
"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
"Satyanarayana K V P" <satyanarayana.k.v.p@intel.com>,
"Tomasz Lis" <tomasz.lis@intel.com>
Subject: [PATCH i-g-t 5/5] tests/xe_sriov_auto_provisioning: Add tests for SR-IOV auto-provisioning
Date: Wed, 18 Dec 2024 13:00:56 +0100 [thread overview]
Message-ID: <20241218120056.779962-6-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20241218120056.779962-1-marcin.bernatowicz@linux.intel.com>
Added subtests validating below scenarios:
- auto-provisioned resources are allocated by PF driver in fairly manner,
- auto-provisioned resources are released once VFs are disabled,
- verify that ranges of auto-provisioned resources are exclusive.
The tests rely on ggtt_provisioned, lmem_provisioned,
contexts_provisioned and doorbells_provisioned debugfs attributes.
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Michał Wajdeczko <michal.wajdeczko@intel.com>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Cc: Narasimha C V <narasimha.c.v@intel.com>
Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
Cc: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: Tomasz Lis <tomasz.lis@intel.com>
---
tests/intel/xe_sriov_auto_provisioning.c | 399 +++++++++++++++++++++++
tests/meson.build | 1 +
2 files changed, 400 insertions(+)
create mode 100644 tests/intel/xe_sriov_auto_provisioning.c
diff --git a/tests/intel/xe_sriov_auto_provisioning.c b/tests/intel/xe_sriov_auto_provisioning.c
new file mode 100644
index 000000000..a5ae60525
--- /dev/null
+++ b/tests/intel/xe_sriov_auto_provisioning.c
@@ -0,0 +1,399 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright(c) 2023 Intel Corporation. All rights reserved.
+ */
+
+#include <stdbool.h>
+
+#include "drmtest.h"
+#include "igt_core.h"
+#include "igt_sriov_device.h"
+#include "igt_sysfs.h"
+#include "xe/xe_sriov_debugfs.h"
+#include "xe/xe_sriov_provisioning.h"
+#include "xe/xe_query.h"
+
+/**
+ * TEST: xe_sriov_auto_provisioning
+ * Category: Core
+ * Mega feature: SR-IOV
+ * Sub-category: provisioning
+ * Functionality: auto-provisioning
+ * Run type: FULL
+ * Description: Examine behavior of SR-IOV auto-provisioning
+ *
+ * SUBTEST: auto-provisioning-fair
+ * Description:
+ * Verify that auto-provisioned resources are allocated by PF driver in fairly manner
+ *
+ * SUBTEST: auto-provisioned-resources-released-on-vfs-disabling
+ * Description:
+ * Verify that auto-provisioned resources are released once VFs are disabled
+ *
+ * SUBTEST: exclusive-ranges
+ * Description:
+ * Verify that ranges of auto-provisioned resources are exclusive
+ */
+
+IGT_TEST_DESCRIPTION("Xe tests for SR-IOV auto-provisioning");
+
+static int compare_ranges_by_vf_id(const void *a, const void *b)
+{
+ const struct xe_sriov_provisioned_range *range_a = a;
+ const struct xe_sriov_provisioned_range *range_b = b;
+
+ return (range_a->vf_id - range_b->vf_id);
+}
+
+static int validate_vf_ids(enum xe_sriov_shared_res res,
+ struct xe_sriov_provisioned_range *ranges,
+ unsigned int nr_ranges, unsigned int num_vfs)
+{
+ unsigned int current_vf_id = 0;
+
+ igt_assert(num_vfs);
+
+ if (igt_debug_on_f(nr_ranges == 0,
+ "%s: No VF ranges\n",
+ xe_sriov_debugfs_provisioned_attr_name(res)))
+ return -ENOENT;
+
+ igt_assert(ranges);
+ qsort(ranges, nr_ranges, sizeof(ranges[0]), compare_ranges_by_vf_id);
+
+ for (unsigned int i = 0; i < nr_ranges; i++) {
+ unsigned int vf_id = ranges[i].vf_id;
+
+ /* Skip duplicates */
+ if (vf_id == current_vf_id)
+ continue;
+
+ if (igt_debug_on_f(vf_id < 1 || vf_id > num_vfs,
+ "%s: Out of range VF%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), vf_id))
+ return -ERANGE;
+
+ if (igt_debug_on_f(vf_id > current_vf_id + 1,
+ "%s: Missing VF%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res),
+ current_vf_id + 1))
+ return -ESRCH;
+
+ current_vf_id = vf_id;
+ }
+
+ if (igt_debug_on_f(current_vf_id != num_vfs,
+ "%s: Missing VF%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), num_vfs))
+ return -ESRCH;
+
+ return 0;
+}
+
+/* Expects ranges sorted by VF IDs */
+static int validate_fair_allocation(enum xe_sriov_shared_res res,
+ struct xe_sriov_provisioned_range *ranges,
+ unsigned int nr_ranges)
+{
+ uint64_t expected_allocation = 0;
+ uint64_t current_allocation = 0;
+ unsigned int current_vf_id;
+
+ igt_assert(nr_ranges);
+ current_vf_id = ranges[0].vf_id;
+
+ for (unsigned int i = 0; i <= nr_ranges; i++) {
+ if (i == nr_ranges || ranges[i].vf_id != current_vf_id) {
+ /* Check allocation consistency for the previous VF ID */
+ if (expected_allocation == 0)
+ expected_allocation = current_allocation;
+ else if (igt_debug_on_f(current_allocation != expected_allocation,
+ "%s: Allocation mismatch, expected=%lu VF%u=%lu\n",
+ xe_sriov_debugfs_provisioned_attr_name(res),
+ expected_allocation, current_vf_id,
+ current_allocation))
+ return -1;
+
+ /* Reset for the new VF ID (if not at the end) */
+ if (i < nr_ranges) {
+ current_vf_id = ranges[i].vf_id;
+ current_allocation = 0;
+ }
+ }
+
+ /* Accumulate allocation for the current VF ID */
+ if (i < nr_ranges)
+ current_allocation += ranges[i].end - ranges[i].start + 1;
+ }
+
+ return 0;
+}
+
+static int check_fair_allocation(int pf_fd, unsigned int num_vfs, unsigned int gt_id,
+ enum xe_sriov_shared_res res)
+{
+ struct xe_sriov_provisioned_range *ranges;
+ unsigned int nr_ranges;
+ int ret;
+
+ ret = xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res, gt_id, &ranges, &nr_ranges);
+ if (igt_debug_on_f(ret, "Failed read %s on GT%u (%d)\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), gt_id, ret))
+ return ret;
+
+ ret = validate_vf_ids(res, ranges, nr_ranges, num_vfs);
+ if (ret) {
+ free(ranges);
+ return ret;
+ }
+
+ ret = validate_fair_allocation(res, ranges, nr_ranges);
+ if (ret) {
+ free(ranges);
+ return ret;
+ }
+
+ free(ranges);
+
+ return 0;
+}
+
+static void auto_provisioning_fair(int pf_fd, unsigned int num_vfs)
+{
+ enum xe_sriov_shared_res res;
+ unsigned int gt;
+ int fails = 0;
+
+ igt_sriov_disable_driver_autoprobe(pf_fd);
+ igt_sriov_enable_vfs(pf_fd, num_vfs);
+
+ xe_for_each_gt(pf_fd, gt) {
+ xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
+ if (igt_debug_on_f(check_fair_allocation(pf_fd, num_vfs, gt, res),
+ "%s fair allocation failed on gt%u\n",
+ xe_sriov_shared_res_to_string(res), gt))
+ fails++;
+ }
+ }
+
+ igt_sriov_disable_vfs(pf_fd);
+
+ igt_fail_on_f(fails, "fair allocation failed\n");
+}
+
+static void auto_provisioning_release(int pf_fd, unsigned int num_vfs)
+{
+ struct xe_sriov_provisioned_range *ranges;
+ unsigned int nr_ranges;
+ enum xe_sriov_shared_res res;
+ unsigned int gt;
+ int fails = 0;
+
+ igt_sriov_disable_driver_autoprobe(pf_fd);
+ igt_sriov_enable_vfs(pf_fd, num_vfs);
+
+ xe_for_each_gt(pf_fd, gt) {
+ xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
+ if (igt_warn_on_f(xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res,
+ gt,
+ &ranges,
+ &nr_ranges),
+ "Failed read %s on gt%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), gt)) {
+ continue;
+ }
+
+ igt_warn_on_f(validate_vf_ids(res, ranges, nr_ranges, num_vfs),
+ "%s: VF IDs validation failed on gt%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), gt);
+ free(ranges);
+ }
+ }
+
+ igt_sriov_disable_vfs(pf_fd);
+
+ xe_for_each_gt(pf_fd, gt) {
+ xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
+ if (igt_debug_on_f(xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res,
+ gt,
+ &ranges,
+ &nr_ranges),
+ "Failed read %s on gt%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), gt)) {
+ fails++;
+ continue;
+ }
+
+ if (igt_debug_on_f(nr_ranges,
+ "%s contains unexpected ranges on gt%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), gt)) {
+ fails++;
+ for (unsigned int i = 0; i < nr_ranges; i++) {
+ igt_debug((res == XE_SRIOV_SHARED_RES_GGTT) ?
+ "%s:VF%u: %lx-%lx\n" :
+ "%s:VF%u %lu-%lu\n",
+ xe_sriov_shared_res_to_string(res),
+ ranges[i].vf_id, ranges[i].start, ranges[i].end);
+ }
+ }
+ free(ranges);
+ }
+ }
+
+ igt_fail_on_f(fails, "shared resource release check failed\n");
+}
+
+static int compare_ranges_by_start(const void *a, const void *b)
+{
+ const struct xe_sriov_provisioned_range *range_a = a;
+ const struct xe_sriov_provisioned_range *range_b = b;
+
+ if (range_a->start < range_b->start)
+ return -1;
+ if (range_a->start > range_b->start)
+ return 1;
+ return 0;
+}
+
+static int check_no_overlap(int pf_fd, unsigned int num_vfs, unsigned int gt_id,
+ enum xe_sriov_shared_res res)
+{
+ struct xe_sriov_provisioned_range *ranges;
+ unsigned int nr_ranges;
+ int ret;
+
+ ret = xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res, gt_id, &ranges, &nr_ranges);
+ if (ret)
+ return ret;
+
+ ret = validate_vf_ids(res, ranges, nr_ranges, num_vfs);
+ if (ret) {
+ free(ranges);
+ return ret;
+ }
+
+ igt_assert(ranges);
+ qsort(ranges, nr_ranges, sizeof(ranges[0]), compare_ranges_by_start);
+
+ for (unsigned int i = 0; i < nr_ranges - 1; i++)
+ if (ranges[i].end >= ranges[i + 1].start) {
+ igt_debug((res == XE_SRIOV_SHARED_RES_GGTT) ?
+ "Overlapping ranges: VF%u [%lx-%lx] and VF%u [%lx-%lx]\n" :
+ "Overlapping ranges: VF%u [%lu-%lu] and VF%u [%lu-%lu]\n",
+ ranges[i].vf_id, ranges[i].start, ranges[i].end,
+ ranges[i + 1].vf_id, ranges[i + 1].start, ranges[i + 1].end);
+ free(ranges);
+ return -1;
+ }
+
+ free(ranges);
+
+ return 0;
+}
+
+static void auto_provisioning_exclusive_ranges(int pf_fd, unsigned int num_vfs)
+{
+ enum xe_sriov_shared_res res;
+ unsigned int gt;
+ int fails = 0;
+
+ igt_sriov_disable_driver_autoprobe(pf_fd);
+ igt_sriov_enable_vfs(pf_fd, num_vfs);
+
+ xe_for_each_gt(pf_fd, gt) {
+ xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
+ if (res == XE_SRIOV_SHARED_RES_LMEM)
+ /*
+ * lmem_provisioned is not applicable for this test,
+ * as it does not expose ranges
+ */
+ continue;
+
+ if (igt_debug_on_f(check_no_overlap(pf_fd, num_vfs, gt, res),
+ "%s overlap check failed on gt%u\n",
+ xe_sriov_shared_res_to_string(res), gt))
+ fails++;
+ }
+ }
+
+ igt_sriov_disable_vfs(pf_fd);
+
+ igt_fail_on_f(fails, "exclusive ranges check failed\n");
+}
+
+igt_main
+{
+ enum xe_sriov_shared_res res;
+ unsigned int gt;
+ bool autoprobe;
+ int pf_fd;
+
+ igt_fixture {
+ struct xe_sriov_provisioned_range *ranges;
+ unsigned int nr_ranges;
+ int ret;
+
+ pf_fd = drm_open_driver(DRIVER_XE);
+ igt_require(igt_sriov_is_pf(pf_fd));
+ igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0);
+
+ xe_for_each_gt(pf_fd, gt) {
+ xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
+ ret = xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res, gt,
+ &ranges,
+ &nr_ranges);
+ igt_skip_on_f(ret, "Failed read %s on gt%u (%d)\n",
+ xe_sriov_debugfs_provisioned_attr_name(res),
+ gt, ret);
+ igt_skip_on_f(nr_ranges != 0, "Unexpected %s content on gt%u\n",
+ xe_sriov_debugfs_provisioned_attr_name(res), gt);
+ }
+ }
+ autoprobe = igt_sriov_is_driver_autoprobe_enabled(pf_fd);
+ }
+
+ igt_describe("Verify that auto-provisioned resources are allocated by PF driver in fairly manner");
+ igt_subtest_with_dynamic("auto-provisioning-fair") {
+ for_random_sriov_num_vfs(pf_fd, num_vfs) {
+ igt_dynamic_f("numvfs-random") {
+ igt_debug("numvfs=%u\n", num_vfs);
+ auto_provisioning_fair(pf_fd, num_vfs);
+ }
+ }
+ }
+
+ igt_describe("Verify that auto-provisioned resources are released once VFs are disabled");
+ igt_subtest_with_dynamic("auto-provisioned-resources-released-on-vfs-disabling") {
+ for_random_sriov_num_vfs(pf_fd, num_vfs) {
+ igt_dynamic_f("numvfs-random") {
+ igt_debug("numvfs=%u\n", num_vfs);
+ auto_provisioning_release(pf_fd, num_vfs);
+ }
+ }
+ }
+
+ igt_describe("Verify that ranges of auto-provisioned resources are exclusive");
+ igt_subtest_with_dynamic_f("exclusive-ranges") {
+ unsigned int total_vfs = igt_sriov_get_total_vfs(pf_fd);
+
+ igt_skip_on(total_vfs < 2);
+
+ for_random_sriov_vf_in_range(pf_fd, 2, total_vfs, num_vfs) {
+ igt_dynamic_f("numvfs-random") {
+ igt_debug("numvfs=%u\n", num_vfs);
+ auto_provisioning_exclusive_ranges(pf_fd, num_vfs);
+ }
+ }
+ }
+
+ igt_fixture {
+ igt_sriov_disable_vfs(pf_fd);
+ /* abort to avoid execution of next tests with enabled VFs */
+ igt_abort_on_f(igt_sriov_get_enabled_vfs(pf_fd) > 0, "Failed to disable VF(s)");
+ autoprobe ? igt_sriov_enable_driver_autoprobe(pf_fd) :
+ igt_sriov_disable_driver_autoprobe(pf_fd);
+ igt_abort_on_f(autoprobe != igt_sriov_is_driver_autoprobe_enabled(pf_fd),
+ "Failed to restore sriov_drivers_autoprobe value\n");
+ drm_close_driver(pf_fd);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index 2724c7a9a..01076f401 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -315,6 +315,7 @@ intel_xe_progs = [
'xe_vm',
'xe_waitfence',
'xe_spin_batch',
+ 'xe_sriov_auto_provisioning',
'xe_sriov_flr',
'xe_sysfs_defaults',
'xe_sysfs_preempt_timeout',
--
2.31.1
next prev parent reply other threads:[~2024-12-18 12:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 12:00 [PATCH i-g-t 0/5] Add xe_sriov_auto_provisioning tests Marcin Bernatowicz
2024-12-18 12:00 ` [PATCH i-g-t 1/5] lib/xe/xe_sriov_debugfs: Add debugfs get/set functions for u32, u64, bool Marcin Bernatowicz
2024-12-18 14:18 ` Laguna, Lukasz
2024-12-18 12:00 ` [PATCH i-g-t 2/5] lib/xe/xe_sriov_provisioning: Add accessors for quota/spare attributes Marcin Bernatowicz
2024-12-18 14:28 ` Laguna, Lukasz
2024-12-18 12:00 ` [PATCH i-g-t 3/5] lib/xe/xe_sriov_provisioning: Add shared resource provisionability check Marcin Bernatowicz
2024-12-18 14:47 ` Laguna, Lukasz
2024-12-18 12:00 ` [PATCH i-g-t 4/5] lib/igt_sriov_device: Add helper functions for VF range validation Marcin Bernatowicz
2024-12-19 14:39 ` Laguna, Lukasz
2024-12-18 12:00 ` Marcin Bernatowicz [this message]
2024-12-19 14:48 ` [PATCH i-g-t 5/5] tests/xe_sriov_auto_provisioning: Add tests for SR-IOV auto-provisioning Laguna, Lukasz
2024-12-19 15:54 ` Bernatowicz, Marcin
2025-01-07 11:52 ` Laguna, Lukasz
2024-12-18 22:25 ` ✓ i915.CI.BAT: success for Add xe_sriov_auto_provisioning tests Patchwork
2024-12-19 1:00 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-19 12:22 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-19 17:51 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218120056.779962-6-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=adam.miszczak@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=lukasz.laguna@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
--cc=narasimha.c.v@intel.com \
--cc=piotr.piorkowski@intel.com \
--cc=satyanarayana.k.v.p@intel.com \
--cc=tomasz.lis@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox