* [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail
@ 2024-12-18 12:45 Thomas Hellström
2024-12-18 14:08 ` Nirmoy Das
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Hellström @ 2024-12-18 12:45 UTC (permalink / raw)
To: igt-dev; +Cc: Thomas Hellström, Matthew Brost, akshata.jahagirdar
Threads may compete over VRAM resources, and since there is no
serialization in TTM, threaded evict tests may have a high
possibility of failing.
Disable such tests until we have a working exhaustive eviction
implementation in place.
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <akshata.jahagirdar@intel.com>
---
tests/intel-ci/xe-fast-feedback.testlist | 5 -----
tests/intel-ci/xe.blocklist.txt | 7 +++++++
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 727be9230..f16ca9188 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
igt@xe_exec_threads@threads-mixed-fd-basic
igt@xe_exec_threads@threads-mixed-userptr-invalidate
igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
-igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
igt@xe_evict@evict-beng-small
igt@xe_evict@evict-beng-small-cm
igt@xe_evict@evict-beng-small-external
igt@xe_evict@evict-beng-small-external-cm
igt@xe_evict@evict-beng-small-multi-vm
igt@xe_evict@evict-cm-threads-small
-igt@xe_evict@evict-mixed-threads-small
-igt@xe_evict@evict-mixed-threads-small-multi-vm
igt@xe_evict@evict-small
igt@xe_evict@evict-small-cm
igt@xe_evict@evict-small-external
igt@xe_evict@evict-small-external-cm
igt@xe_evict@evict-small-multi-vm
-igt@xe_evict@evict-small-multi-vm-cm
-igt@xe_evict@evict-threads-small
diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
index e29e745a0..ed9e572a5 100644
--- a/tests/intel-ci/xe.blocklist.txt
+++ b/tests/intel-ci/xe.blocklist.txt
@@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
igt@sriov_basic@enable-vfs-bind-unbind-each$
igt@sriov_basic@bind-unbind-vf$
##################################################################
+# Exclude xe_evict tests that are not expected to succeed
+# due to missing TTM exhaustive eviction
+##################################################################
+igt@xe_evict@*-multi-vm-cm*
+igt@xe_evict@*-threads-*
+# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
+##################################################################
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail
2024-12-18 12:45 [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail Thomas Hellström
@ 2024-12-18 14:08 ` Nirmoy Das
2024-12-18 14:18 ` Kamil Konieczny
2024-12-18 15:06 ` Jahagirdar, Akshata
2 siblings, 0 replies; 5+ messages in thread
From: Nirmoy Das @ 2024-12-18 14:08 UTC (permalink / raw)
To: Thomas Hellström, igt-dev; +Cc: Matthew Brost, akshata.jahagirdar
On 12/18/2024 1:45 PM, Thomas Hellström wrote:
> Threads may compete over VRAM resources, and since there is no
> serialization in TTM, threaded evict tests may have a high
> possibility of failing.
>
> Disable such tests until we have a working exhaustive eviction
> implementation in place.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <akshata.jahagirdar@intel.com>
Saw many failures of these tests on BMG
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> tests/intel-ci/xe-fast-feedback.testlist | 5 -----
> tests/intel-ci/xe.blocklist.txt | 7 +++++++
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 727be9230..f16ca9188 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
> igt@xe_exec_threads@threads-mixed-fd-basic
> igt@xe_exec_threads@threads-mixed-userptr-invalidate
> igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
> igt@xe_evict@evict-beng-small
> igt@xe_evict@evict-beng-small-cm
> igt@xe_evict@evict-beng-small-external
> igt@xe_evict@evict-beng-small-external-cm
> igt@xe_evict@evict-beng-small-multi-vm
> igt@xe_evict@evict-cm-threads-small
> -igt@xe_evict@evict-mixed-threads-small
> -igt@xe_evict@evict-mixed-threads-small-multi-vm
> igt@xe_evict@evict-small
> igt@xe_evict@evict-small-cm
> igt@xe_evict@evict-small-external
> igt@xe_evict@evict-small-external-cm
> igt@xe_evict@evict-small-multi-vm
> -igt@xe_evict@evict-small-multi-vm-cm
> -igt@xe_evict@evict-threads-small
> diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
> index e29e745a0..ed9e572a5 100644
> --- a/tests/intel-ci/xe.blocklist.txt
> +++ b/tests/intel-ci/xe.blocklist.txt
> @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
> igt@sriov_basic@enable-vfs-bind-unbind-each$
> igt@sriov_basic@bind-unbind-vf$
> ##################################################################
> +# Exclude xe_evict tests that are not expected to succeed
> +# due to missing TTM exhaustive eviction
> +##################################################################
> +igt@xe_evict@*-multi-vm-cm*
> +igt@xe_evict@*-threads-*
> +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
> +##################################################################
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail
2024-12-18 12:45 [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail Thomas Hellström
2024-12-18 14:08 ` Nirmoy Das
@ 2024-12-18 14:18 ` Kamil Konieczny
2024-12-18 15:28 ` Thomas Hellström
2024-12-18 15:06 ` Jahagirdar, Akshata
2 siblings, 1 reply; 5+ messages in thread
From: Kamil Konieczny @ 2024-12-18 14:18 UTC (permalink / raw)
To: Thomas Hellström; +Cc: igt-dev, Matthew Brost, akshata.jahagirdar
Hi Thomas,
On 2024-12-18 at 13:45:19 +0100, Thomas Hellström wrote:
> Threads may compete over VRAM resources, and since there is no
> serialization in TTM, threaded evict tests may have a high
> possibility of failing.
>
> Disable such tests until we have a working exhaustive eviction
> implementation in place.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <akshata.jahagirdar@intel.com>
Looks reasonable, please only change prefix into
tests/intel-ci/xe*:
also consider writing it a little shorter, like:
[PATCH i-g-t] tests/intel-ci/xe*: Disable few xe_evict subtests
With this
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Please also see one nit below.
> ---
> tests/intel-ci/xe-fast-feedback.testlist | 5 -----
> tests/intel-ci/xe.blocklist.txt | 7 +++++++
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 727be9230..f16ca9188 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
> igt@xe_exec_threads@threads-mixed-fd-basic
> igt@xe_exec_threads@threads-mixed-userptr-invalidate
> igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
> igt@xe_evict@evict-beng-small
> igt@xe_evict@evict-beng-small-cm
> igt@xe_evict@evict-beng-small-external
> igt@xe_evict@evict-beng-small-external-cm
> igt@xe_evict@evict-beng-small-multi-vm
> igt@xe_evict@evict-cm-threads-small
> -igt@xe_evict@evict-mixed-threads-small
> -igt@xe_evict@evict-mixed-threads-small-multi-vm
> igt@xe_evict@evict-small
> igt@xe_evict@evict-small-cm
> igt@xe_evict@evict-small-external
> igt@xe_evict@evict-small-external-cm
> igt@xe_evict@evict-small-multi-vm
> -igt@xe_evict@evict-small-multi-vm-cm
> -igt@xe_evict@evict-threads-small
> diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
> index e29e745a0..ed9e572a5 100644
> --- a/tests/intel-ci/xe.blocklist.txt
> +++ b/tests/intel-ci/xe.blocklist.txt
> @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
> igt@sriov_basic@enable-vfs-bind-unbind-each$
> igt@sriov_basic@bind-unbind-vf$
> ##################################################################
> +# Exclude xe_evict tests that are not expected to succeed
> +# due to missing TTM exhaustive eviction
> +##################################################################
> +igt@xe_evict@*-multi-vm-cm*
> +igt@xe_evict@*-threads-*
> +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
Did you mean that
igt@xe_evict@evict-cm-threads-small
should stay in BAT?
Regards,
Kamil
> +##################################################################
> --
> 2.47.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail
2024-12-18 14:18 ` Kamil Konieczny
@ 2024-12-18 15:28 ` Thomas Hellström
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Hellström @ 2024-12-18 15:28 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, Matthew Brost, akshata.jahagirdar
On Wed, 2024-12-18 at 15:18 +0100, Kamil Konieczny wrote:
> Hi Thomas,
> On 2024-12-18 at 13:45:19 +0100, Thomas Hellström wrote:
> > Threads may compete over VRAM resources, and since there is no
> > serialization in TTM, threaded evict tests may have a high
> > possibility of failing.
> >
> > Disable such tests until we have a working exhaustive eviction
> > implementation in place.
> >
> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Cc: <akshata.jahagirdar@intel.com>
>
> Looks reasonable, please only change prefix into
> tests/intel-ci/xe*:
>
> also consider writing it a little shorter, like:
> [PATCH i-g-t] tests/intel-ci/xe*: Disable few xe_evict subtests
>
> With this
> Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
> Please also see one nit below.
>
> > ---
> > tests/intel-ci/xe-fast-feedback.testlist | 5 -----
> > tests/intel-ci/xe.blocklist.txt | 7 +++++++
> > 2 files changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/intel-ci/xe-fast-feedback.testlist
> > b/tests/intel-ci/xe-fast-feedback.testlist
> > index 727be9230..f16ca9188 100644
> > --- a/tests/intel-ci/xe-fast-feedback.testlist
> > +++ b/tests/intel-ci/xe-fast-feedback.testlist
> > @@ -263,19 +263,14 @@
> > igt@xe_exec_threads@threads-mixed-shared-vm-basic
> > igt@xe_exec_threads@threads-mixed-fd-basic
> > igt@xe_exec_threads@threads-mixed-userptr-invalidate
> >
> > igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> > -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
> > igt@xe_evict@evict-beng-small
> > igt@xe_evict@evict-beng-small-cm
> > igt@xe_evict@evict-beng-small-external
> > igt@xe_evict@evict-beng-small-external-cm
> > igt@xe_evict@evict-beng-small-multi-vm
> > igt@xe_evict@evict-cm-threads-small
> > -igt@xe_evict@evict-mixed-threads-small
> > -igt@xe_evict@evict-mixed-threads-small-multi-vm
> > igt@xe_evict@evict-small
> > igt@xe_evict@evict-small-cm
> > igt@xe_evict@evict-small-external
> > igt@xe_evict@evict-small-external-cm
> > igt@xe_evict@evict-small-multi-vm
> > -igt@xe_evict@evict-small-multi-vm-cm
> > -igt@xe_evict@evict-threads-small
> > diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-
> > ci/xe.blocklist.txt
> > index e29e745a0..ed9e572a5 100644
> > --- a/tests/intel-ci/xe.blocklist.txt
> > +++ b/tests/intel-ci/xe.blocklist.txt
> > @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
> > igt@sriov_basic@enable-vfs-bind-unbind-each$
> > igt@sriov_basic@bind-unbind-vf$
> > ##################################################################
> > +# Exclude xe_evict tests that are not expected to succeed
> > +# due to missing TTM exhaustive eviction
> > +##################################################################
> > +igt@xe_evict@*-multi-vm-cm*
> > +igt@xe_evict@*-threads-*
> > +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
>
> Did you mean that
> igt@xe_evict@evict-cm-threads-small
>
> should stay in BAT?
No it shouldn't. Good catch. I'll update.
>
> Regards,
> Kamil
>
> > +##################################################################
> > --
> > 2.47.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail
2024-12-18 12:45 [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail Thomas Hellström
2024-12-18 14:08 ` Nirmoy Das
2024-12-18 14:18 ` Kamil Konieczny
@ 2024-12-18 15:06 ` Jahagirdar, Akshata
2 siblings, 0 replies; 5+ messages in thread
From: Jahagirdar, Akshata @ 2024-12-18 15:06 UTC (permalink / raw)
To: Thomas Hellström, igt-dev; +Cc: Matthew Brost
On 12/18/2024 4:45 AM, Thomas Hellström wrote:
> Threads may compete over VRAM resources, and since there is no
> serialization in TTM, threaded evict tests may have a high
> possibility of failing.
>
> Disable such tests until we have a working exhaustive eviction
> implementation in place.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <akshata.jahagirdar@intel.com>
> ---
> tests/intel-ci/xe-fast-feedback.testlist | 5 -----
> tests/intel-ci/xe.blocklist.txt | 7 +++++++
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 727be9230..f16ca9188 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
> igt@xe_exec_threads@threads-mixed-fd-basic
> igt@xe_exec_threads@threads-mixed-userptr-invalidate
> igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
> igt@xe_evict@evict-beng-small
> igt@xe_evict@evict-beng-small-cm
> igt@xe_evict@evict-beng-small-external
> igt@xe_evict@evict-beng-small-external-cm
> igt@xe_evict@evict-beng-small-multi-vm
> igt@xe_evict@evict-cm-threads-small
> -igt@xe_evict@evict-mixed-threads-small
> -igt@xe_evict@evict-mixed-threads-small-multi-vm
> igt@xe_evict@evict-small
> igt@xe_evict@evict-small-cm
> igt@xe_evict@evict-small-external
> igt@xe_evict@evict-small-external-cm
> igt@xe_evict@evict-small-multi-vm
> -igt@xe_evict@evict-small-multi-vm-cm
> -igt@xe_evict@evict-threads-small
There seem to be multiple issues pertaining to these tests.
Reviewed-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
> diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
> index e29e745a0..ed9e572a5 100644
> --- a/tests/intel-ci/xe.blocklist.txt
> +++ b/tests/intel-ci/xe.blocklist.txt
> @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
> igt@sriov_basic@enable-vfs-bind-unbind-each$
> igt@sriov_basic@bind-unbind-vf$
> ##################################################################
> +# Exclude xe_evict tests that are not expected to succeed
> +# due to missing TTM exhaustive eviction
> +##################################################################
> +igt@xe_evict@*-multi-vm-cm*
> +igt@xe_evict@*-threads-*
> +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
> +##################################################################
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-18 15:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-18 12:45 [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail Thomas Hellström
2024-12-18 14:08 ` Nirmoy Das
2024-12-18 14:18 ` Kamil Konieczny
2024-12-18 15:28 ` Thomas Hellström
2024-12-18 15:06 ` Jahagirdar, Akshata
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox