Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, santhosh.reddy.guddati@intel.com,
	Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Subject: [PATCH i-g-t v2 2/5] runner/settings: Constify absolute_path parameter
Date: Wed,  8 Jan 2025 01:36:11 +0530	[thread overview]
Message-ID: <20250107200614.963199-3-ramanaidu.naladala@intel.com> (raw)
In-Reply-To: <20250107200614.963199-1-ramanaidu.naladala@intel.com>

Modified absolute_path to use const char* for input, updating the
corresponding declaration. This ensures the input path remains
unmodified, enhancing code safety and clarity.

v2: Update commit subject.  (kmail)

Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
---
 runner/settings.c | 2 +-
 runner/settings.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/runner/settings.c b/runner/settings.c
index 92fd42ea6..bea0c3059 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -567,7 +567,7 @@ static char *_basename(const char *path)
 	return tmpname;
 }
 
-char *absolute_path(char *path)
+char *absolute_path(const char *path)
 {
 	char *result = NULL;
 	char *base, *dir;
diff --git a/runner/settings.h b/runner/settings.h
index f69f09778..7e6cd11e2 100644
--- a/runner/settings.h
+++ b/runner/settings.h
@@ -136,7 +136,7 @@ bool parse_options(int argc, char **argv,
 bool validate_settings(struct settings *settings);
 
 /* TODO: Better place for this */
-char *absolute_path(char *path);
+char *absolute_path(const char *path);
 
 /**
  * serialize_settings:
-- 
2.43.0


  parent reply	other threads:[~2025-01-07 20:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07 20:06 [PATCH i-g-t v2 0/5] Update image assets Naladala Ramanaidu
2025-01-07 20:06 ` [PATCH i-g-t v2 1/5] data: Move PNG images to new data directory Naladala Ramanaidu
2025-01-07 20:06 ` Naladala Ramanaidu [this message]
2025-01-16 12:29   ` [PATCH i-g-t v2 2/5] runner/settings: Constify absolute_path parameter Kamil Konieczny
2025-01-07 20:06 ` [PATCH i-g-t v2 3/5] runner/settings: Add function to set IGT_RUNNER_DATA environment variable Naladala Ramanaidu
2025-01-16  9:51   ` Kamil Konieczny
2025-01-16 12:36   ` Kamil Konieczny
2025-02-18 21:14     ` Naladala, Ramanaidu
2025-01-07 20:06 ` [PATCH i-g-t v2 4/5] lib/igt_core: Enhance __igt_fopen_data to support additional directories Naladala Ramanaidu
2025-01-07 20:06 ` [PATCH i-g-t v2 5/5] HAX patch do not merge Naladala Ramanaidu
2025-01-07 23:16 ` ✗ i915.CI.BAT: failure for Update image assets (rev3) Patchwork
2025-01-07 23:17 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-09 15:19 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-10  6:37 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-14 11:48 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107200614.963199-3-ramanaidu.naladala@intel.com \
    --to=ramanaidu.naladala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox