Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stuart Summers <stuart.summers@intel.com>
Cc: igt-dev@lists.freedesktop.org, Stuart Summers <stuart.summers@intel.com>
Subject: [PATCH i-g-t] tests/intel/xe_exec_reset: Add a vm_unbind after the stress test completes
Date: Wed,  8 Jan 2025 22:54:24 +0000	[thread overview]
Message-ID: <20250108225424.95051-1-stuart.summers@intel.com> (raw)

The test is submitting workloads in a tight loop and then
destroying the exec queue for each of these. There is a
potential that the GuC IDs could get used up during these
submissions and before a GT reset goes through. If that
happens, the subsequent submissions will essentially be
"lost" in that they aren't submitted to GuC and just wait
for a submission timeout to happen, at which point we do
a reset_async in the driver. What seems to be happening
however is these workloads are lingering beyond the
completion of the xe_exec_reset test. Then when the
reset_async eventually goes through, the submissions
from a next test can also hang (or possibly because
they too ran into the guc_id exhaustion case).

Add an explicit vm_unbind before destroying the VM
to give time for those submissions to complete
before the test ends.

https://gitlab.freedesktop.org/drm/xe/kernel/issues/4015

Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
 tests/intel/xe_exec_reset.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
index a3eaf8bbf..ca5566d11 100644
--- a/tests/intel/xe_exec_reset.c
+++ b/tests/intel/xe_exec_reset.c
@@ -645,6 +645,8 @@ static void submit_jobs(struct gt_thread_data *t)
 		xe_exec_queue_destroy(fd, exec.exec_queue_id);
 	}
 
+	xe_vm_unbind_sync(fd, vm, 0, addr, bo_size);
+
 	munmap(data, bo_size);
 	gem_close(fd, bo);
 	xe_vm_destroy(fd, vm);
-- 
2.34.1


             reply	other threads:[~2025-01-08 22:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 22:54 Stuart Summers [this message]
2025-01-08 23:38 ` [PATCH i-g-t] tests/intel/xe_exec_reset: Add a vm_unbind after the stress test completes Cavitt, Jonathan
2025-01-09 15:39   ` Summers, Stuart
2025-01-13 16:00     ` Summers, Stuart
2025-01-09  0:21 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-01-09  0:31 ` ✓ i915.CI.BAT: " Patchwork
2025-01-11  2:32 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-11  4:36 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250108225424.95051-1-stuart.summers@intel.com \
    --to=stuart.summers@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox