Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: <george.zhang@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <juha-pekka.heikkila@intel.com>, <Clinton.A.Taylor@intel.com>,
	"George Zhang" <george.zhang@amd.com>
Subject: [PATCH] tests/kms_addfb_basic: Fix addfb25_tests to not require intel
Date: Mon, 20 Jan 2025 12:10:14 -0500	[thread overview]
Message-ID: <20250120171021.1029868-1-george.zhang@amd.com> (raw)

From: George Zhang <george.zhang@amd.com>

This test does not require running on intel devices, so move it under
the display_require.

It was accidentally moved under the igt_require_intel fixture when
it was meant to be moved under the igt_display_require.

Fixes: 109d23b91a30 ("tests/kms_addfb_basic: fix x-tiled tests for case when there is no x-tile)

Signed-off-by: George Zhang <george.zhang@amd.com>
---
 tests/kms_addfb_basic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 3ba87117b..30ca8b016 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -1022,11 +1022,11 @@ igt_main
 
 		size_tests(fd);
 
+		addfb25_tests(fd);
+
 		igt_fixture
 			igt_require_intel(fd);
 
-		addfb25_tests(fd);
-
 		addfb25_ytile(fd);
 
 		addfb25_4tile(fd);
-- 
2.43.0


             reply	other threads:[~2025-01-20 17:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 17:10 george.zhang [this message]
2025-01-20 17:22 ` [PATCH] tests/kms_addfb_basic: Fix addfb25_tests to not require intel Zhang, George
2025-01-20 17:50 ` Juha-Pekka Heikkilä
2025-01-20 19:26 ` ✗ GitLab.Pipeline: warning for " Patchwork
2025-01-20 19:54 ` ✗ i915.CI.BAT: failure " Patchwork
2025-01-20 20:01 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-20 21:42 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-20 22:02 ` ✗ i915.CI.BAT: failure for tests/kms_addfb_basic: Fix addfb25_tests to not require intel (rev2) Patchwork
2025-01-21 11:08   ` Juha-Pekka Heikkilä
2025-01-20 22:20 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-20 23:37 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120171021.1029868-1-george.zhang@amd.com \
    --to=george.zhang@amd.com \
    --cc=Clinton.A.Taylor@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox