Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t] tests/intel/kms_pm_rpm: Update modifier to linear for display version 30+
Date: Thu, 23 Jan 2025 14:45:46 +0530	[thread overview]
Message-ID: <20250123091546.3126819-1-jeevan.b@intel.com> (raw)

On latest platform tile-X is no longer supported, So for display
version 30+ we can use linear tiling and tile-X for older platform.
This change accounts for the limitations of gem_set_tiling, which
no longer works on recent platforms and will not be supported on
Xe drivers.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
 tests/intel/kms_pm_rpm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/intel/kms_pm_rpm.c b/tests/intel/kms_pm_rpm.c
index 990c50915..0f4da426b 100644
--- a/tests/intel/kms_pm_rpm.c
+++ b/tests/intel/kms_pm_rpm.c
@@ -1188,6 +1188,12 @@ static void cursor_subtest(bool dpms)
 	int rc;
 	struct igt_fb cursor_fb1, cursor_fb2, cursor_fb3;
 	uint32_t crtc_id;
+	uint64_t modifier;
+
+	if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 30)
+		modifier = DRM_FORMAT_MOD_LINEAR;
+	else
+		modifier = I915_FORMAT_MOD_X_TILED;
 
 	disable_all_screens_and_wait(&ms_data);
 
@@ -1199,7 +1205,7 @@ static void cursor_subtest(bool dpms)
 	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
 		      DRM_FORMAT_MOD_LINEAR, &cursor_fb2);
 	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_XRGB8888,
-		      I915_FORMAT_MOD_X_TILED, &cursor_fb3);
+		      modifier, &cursor_fb3);
 
 	fill_igt_fb(&cursor_fb1, 0xFF00FFFF);
 	fill_igt_fb(&cursor_fb2, 0xFF00FF00);
-- 
2.25.1


             reply	other threads:[~2025-01-23  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23  9:15 Jeevan B [this message]
2025-01-23  9:39 ` ✗ GitLab.Pipeline: warning for tests/intel/kms_pm_rpm: Update modifier to linear for display version 30+ Patchwork
2025-01-23 10:04 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-23 10:51 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-23 14:56 ` [PATCH i-g-t] " Thasleem, Mohammed
2025-01-24 16:02   ` Juha-Pekka Heikkilä
2025-01-23 22:25 ` ✓ Xe.CI.Full: success for " Patchwork
2025-01-24  3:00 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123091546.3126819-1-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox