From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A866C0218B for ; Thu, 23 Jan 2025 09:22:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 027A710E7A4; Thu, 23 Jan 2025 09:22:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="akPEMNVS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDBA610E7A4 for ; Thu, 23 Jan 2025 09:22:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737624150; x=1769160150; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iDdfXvF0/Z9Fd+0xymmgtbJF2KrFm4gIo0Lyqh2HXoA=; b=akPEMNVS8Y74aweW0KRngjd+ySDH2biiHFnILKT3Gv9mCmAyWlrzIMq/ nzTbWZdqsWO2ThdWM2ggSyQ54SM9JGeGQWn7lFuUOogBvZou1Z1NE53ui 8iDTRhuMc1GvwzQxxv4berm7KqOZPUiSd12ZMs6SLgLg8vryJ4ZlROLwU iptmfLE5WvQwx1aoIt3ctUUI35DYVnFTBmiBul5xeTRP+qHC7teHZQKi2 h5klsDlFBAUvyL0rWALayyKeWuZntYo1RmGT5BcEJ2xvqPRNMbhFMv+rv bF1Iqz6z9V2jdT2vHl2+ORjApkf1Jr0QNfg67BiOBEHfBFwoL858Ib3rP g==; X-CSE-ConnectionGUID: +dYkKfwzSeG0yhMCLOK38A== X-CSE-MsgGUID: fzcYsTLtQoefGWBCQEqOUg== X-IronPort-AV: E=McAfee;i="6700,10204,11323"; a="63461482" X-IronPort-AV: E=Sophos;i="6.13,227,1732608000"; d="scan'208";a="63461482" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 01:22:30 -0800 X-CSE-ConnectionGUID: tYDLrIwrRtaPejyhsoFZkQ== X-CSE-MsgGUID: vVXqo4fwTx+/nrw7Jix0lw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="107255325" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.85]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 01:22:28 -0800 From: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= To: igt-dev@lists.freedesktop.org Cc: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= , Lucas De Marchi , Kamil Konieczny Subject: [PATCH i-g-t 3/3] tests/xe_intel_bb: check multithreading rescans won't segfault Date: Thu, 23 Jan 2025 10:22:10 +0100 Message-Id: <20250123092210.48249-4-zbigniew.kempczynski@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250123092210.48249-1-zbigniew.kempczynski@intel.com> References: <20250123092210.48249-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" This test is likely only for checking purposes, it doesn't makes sense to merge it after series review. Signed-off-by: Zbigniew Kempczyński Cc: Lucas De Marchi Cc: Kamil Konieczny --- tests/intel-ci/xe-fast-feedback.testlist | 1 + tests/intel/xe_intel_bb.c | 47 ++++++++++++++++++++++++ 2 files changed, 48 insertions(+) diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist index 0234d3e72d..7adb9a3436 100644 --- a/tests/intel-ci/xe-fast-feedback.testlist +++ b/tests/intel-ci/xe-fast-feedback.testlist @@ -7,6 +7,7 @@ igt@fbdev@nullptr igt@fbdev@read igt@fbdev@write +igt@xe_intel_bb@multithread-open igt@kms_addfb_basic@addfb25-4-tiled igt@kms_addfb_basic@addfb25-bad-modifier igt@kms_addfb_basic@addfb25-modifier-no-flag diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c index 845052bf26..5df009f9ed 100644 --- a/tests/intel/xe_intel_bb.c +++ b/tests/intel/xe_intel_bb.c @@ -18,6 +18,7 @@ #include "igt.h" #include "igt_crc.h" +#include "igt_device_scan.h" #include "intel_blt.h" #include "intel_bufops.h" #include "intel_mocs.h" @@ -950,6 +951,49 @@ static int render(struct buf_ops *bops, uint32_t tiling, return fails; } +/** + * SUBTEST: multithread-open + * Description: check device scanning when multiple threads are involved + */ +static void *__single_open(void *data) +{ + struct igt_device_card card; + int fd; + + igt_info("Thread: %d\n", (int)to_user_pointer(data)); + + for (int i = 0; i < 5; i++) + igt_devices_scan(); + + igt_assert_eq(igt_device_card_match("pci:vendor=intel", &card), true); + igt_info("Device detail: %s, %s, %s\n", card.subsystem, card.card, card.render); + + fd = igt_open_card(&card); + igt_info("Fd: %d\n", fd); + igt_assert(fd >= 0); + close(fd); + + return NULL; +} + +#define NUM_THREADS 100 +static void multithread_open(void) +{ + pthread_t pth[NUM_THREADS]; + int i, ret; + + for (i = 0; i < NUM_THREADS; i++) { + ret = pthread_create(&pth[i], NULL, __single_open, + from_user_pointer(i)); + igt_assert_eq(ret, 0); + } + + for (i = 0; i < NUM_THREADS; i++) { + ret = pthread_join(pth[i], NULL); + igt_assert_eq(ret, 0); + } +} + static int opt_handler(int opt, int opt_index, void *data) { switch (opt) { @@ -1063,6 +1107,9 @@ igt_main_args("dpib", NULL, help_str, opt_handler, NULL) } } + igt_subtest("multithread-open") + multithread_open(); + igt_fixture { buf_ops_destroy(bops); drm_close_driver(xe); -- 2.34.1