From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Kamil Konieczny" <kamil.konieczny@linux.intel.com>
Subject: [PATCH i-g-t v2 0/3] Drop device scan cache logic
Date: Thu, 23 Jan 2025 10:52:05 +0100 [thread overview]
Message-ID: <20250123095208.72984-1-zbigniew.kempczynski@intel.com> (raw)
In this series I haven't added limiting fetching attributes - after
reading udevadm-info.c I'm not sure it makes sense to limit it. Udevadm
in general does same things current igt_device_scan does, especially
it also skips some attributes. Additionally it skips attributes which
are binaries but I've some resistence to do this similar as strlen()
on blob is imo risky and it may result in segfault. I may send attrs
limiting in separate patch after this series will be reviewed (and
hopefully merged).
Series addresses main concern - stale device cache. Now rescans are
unconditional what prevents from opening old device after operations
on module.
Test added which checks device scanning in multithreading code likely
is not needed for merge. Adding to BAT should reveal early potential
problems with the series.
v2: retrieve missing scanning state variable (used for freeing
on multiple scans)
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Zbigniew Kempczyński (3):
lib/igt_device_scan: drop device scan cache logic
lib/igt_device_scan: change device list variable visibility
tests/xe_intel_bb: check multithreading rescans won't segfault
benchmarks/gem_wsim.c | 2 +-
lib/drmtest.c | 2 +-
lib/igt_device_scan.c | 16 +++-----
lib/igt_device_scan.h | 2 +-
lib/igt_multigpu.c | 2 +-
tests/core_hotunplug.c | 2 +-
tests/device_reset.c | 2 +-
tests/intel-ci/xe-fast-feedback.testlist | 1 +
tests/intel/i915_suspend.c | 4 +-
tests/intel/xe_intel_bb.c | 47 ++++++++++++++++++++++++
tools/intel_gpu_top.c | 2 +-
tools/intel_pm_rpm.c | 2 +-
tools/lsgpu.c | 2 +-
13 files changed, 64 insertions(+), 22 deletions(-)
--
2.34.1
next reply other threads:[~2025-01-23 9:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 9:52 Zbigniew Kempczyński [this message]
2025-01-23 9:52 ` [PATCH i-g-t v2 1/3] lib/igt_device_scan: drop device scan cache logic Zbigniew Kempczyński
2025-01-23 17:25 ` Lucas De Marchi
2025-01-23 9:52 ` [PATCH i-g-t v2 2/3] lib/igt_device_scan: change device list variable visibility Zbigniew Kempczyński
2025-01-24 16:26 ` Kamil Konieczny
2025-01-27 4:49 ` Zbigniew Kempczyński
2025-01-27 15:31 ` Lucas De Marchi
2025-01-27 15:37 ` Zbigniew Kempczyński
2025-01-27 16:08 ` Lucas De Marchi
2025-01-23 9:52 ` [PATCH i-g-t v2 3/3] tests/xe_intel_bb: check multithreading rescans won't segfault Zbigniew Kempczyński
2025-01-24 16:28 ` Kamil Konieczny
2025-01-27 4:50 ` Zbigniew Kempczyński
2025-01-23 10:36 ` ✓ i915.CI.BAT: success for Drop device scan cache logic (rev2) Patchwork
2025-01-23 11:15 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-23 23:13 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-27 4:55 ` Zbigniew Kempczyński
2025-01-24 3:29 ` ✗ i915.CI.Full: " Patchwork
2025-01-27 4:59 ` Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250123095208.72984-1-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox