Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>
Subject: [PATCH i-g-t] tests/intel/xe_exec_mix_modes: Use IGT comparison functions
Date: Mon, 27 Jan 2025 11:14:25 +0100	[thread overview]
Message-ID: <20250127101425.21082-1-francois.dugast@intel.com> (raw)

With igt_assert() the logs were only telling us that the comparison had
failed. With igt_assert_lt() the logs provide the actual values that
were compared, which helps debugging.

Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
 tests/intel/xe_exec_mix_modes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_exec_mix_modes.c b/tests/intel/xe_exec_mix_modes.c
index 0bcd49cc0..59887d2aa 100644
--- a/tests/intel/xe_exec_mix_modes.c
+++ b/tests/intel/xe_exec_mix_modes.c
@@ -169,10 +169,10 @@ run_job(int fd, struct drm_xe_engine_class_instance *hwe,
 			 * depending on the execution mode.
 			 */
 			if (engine_execution_mode == EXEC_MODE_LR)
-				igt_assert(igt_nsec_elapsed(&tv) < 0.5 * duration_ns);
+				igt_assert_lt(igt_nsec_elapsed(&tv), 0.5 * duration_ns);
 			else if (engine_execution_mode == EXEC_MODE_DMA_FENCE &&
 				 job_type == SPINNER_INTERRUPTED)
-				igt_assert(igt_nsec_elapsed(&tv) > duration_ns);
+				igt_assert_lt(duration_ns, igt_nsec_elapsed(&tv));
 		}
 	}
 
-- 
2.43.0


             reply	other threads:[~2025-01-27 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 10:14 Francois Dugast [this message]
2025-01-27 12:25 ` ✓ i915.CI.BAT: success for tests/intel/xe_exec_mix_modes: Use IGT comparison functions Patchwork
2025-01-27 12:31 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-27 12:56 ` [PATCH i-g-t] " Kamil Konieczny
2025-01-27 14:04 ` ✗ i915.CI.Full: failure for " Patchwork
2025-01-27 14:21 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127101425.21082-1-francois.dugast@intel.com \
    --to=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox