From: Peter Senna Tschudin <peter.senna@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Peter Senna Tschudin <peter.senna@linux.intel.com>,
juha-pekka.heikkila@intel.com, katarzyna.piecielska@intel.com,
ryszard.knop@intel.com, ewelina.musial@intel.com,
adrinael@adrinael.net, mateusz.grabski@intel.com,
konrad.b.brodzik@intel.com
Subject: [PATCH i-g-t] Bump aborting on network failure deadline to 40 seconds
Date: Thu, 6 Feb 2025 16:21:47 +0100 [thread overview]
Message-ID: <20250206152147.209277-1-peter.senna@linux.intel.com> (raw)
Commit ddfde25f16ba ("runner: Add support for aborting on network
failure") introduced a 20 second deadline for the DUT’s network
to recover after a suspend/resume cycle. If the network isn’t
back up within that time, igt_runner aborts the test run to save logs
and prevent potential log loss from an imminent power cycle.
This deadline was set to accommodate our internal CI system, which
checks for DUT network connectivity every 5 seconds and retries up
to 3 times at 20 second intervals. If it fails 3 consecutive checks,
it triggers a power cycle on the DUT.
Although our internal CI system can be configured with a longer
wait time, extending it further would unnecessarily prolong tests
in cases of DUT hangs.
Bumping the deadline to 40 seconds keeps the abort mechanism safely
within our internal CI system retry window while improving chances
of preventing a premature abort. For upstream testing on Jenkins,
the deadlines vary from 16 and 25 minutes, and this change has
no impact.
CC: juha-pekka.heikkila@intel.com
CC: katarzyna.piecielska@intel.com
CC: ryszard.knop@intel.com
CC: ewelina.musial@intel.com
CC: adrinael@adrinael.net
CC: mateusz.grabski@intel.com
CC: konrad.b.brodzik@intel.com
Signed-off-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
---
runner/executor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/runner/executor.c b/runner/executor.c
index 999e7f719..2abb18732 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -218,11 +218,11 @@ static bool load_ping_config_from_env(void)
/*
* On some hosts, getting network back up after suspend takes
- * upwards of 10 seconds. 20 seconds should be enough to see
+ * upwards of 10 seconds. 40 seconds should be enough to see
* if network comes back at all, and hopefully not too long to
* make external monitoring freak out.
*/
-#define PING_ABORT_DEADLINE 20
+#define PING_ABORT_DEADLINE 40
static bool can_ping(void)
{
--
2.34.1
next reply other threads:[~2025-02-06 15:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 15:21 Peter Senna Tschudin [this message]
2025-02-06 21:06 ` ✓ Xe.CI.BAT: success for Bump aborting on network failure deadline to 40 seconds Patchwork
2025-02-07 2:00 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-07 7:51 ` Peter Senna Tschudin
2025-02-07 8:13 ` Ravali, JupallyX
2025-02-07 14:00 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-07 14:07 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-07 14:43 ` Peter Senna Tschudin
2025-02-10 5:35 ` Ravali, JupallyX
2025-02-07 21:01 ` ✓ Xe.CI.Full: success " Patchwork
2025-02-10 5:33 ` ✓ i915.CI.BAT: " Patchwork
2025-02-10 7:08 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-10 8:26 ` Peter Senna Tschudin
2025-02-10 14:43 ` Ravali, JupallyX
2025-02-10 10:36 ` ✓ i915.CI.Full: success " Patchwork
2025-02-11 9:21 ` [PATCH i-g-t] " Kamil Konieczny
2025-02-11 9:55 ` Peter Senna Tschudin
2025-02-11 11:59 ` Piecielska, Katarzyna
2025-02-11 13:38 ` Peter Senna Tschudin
2025-02-12 10:06 ` Knop, Ryszard
2025-02-12 13:52 ` Kamil Konieczny
2025-02-12 14:31 ` Knop, Ryszard
2025-02-12 14:59 ` Kamil Konieczny
2025-02-12 15:38 ` Peter Senna Tschudin
2025-02-13 13:37 ` Kamil Konieczny
2025-02-14 9:26 ` Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206152147.209277-1-peter.senna@linux.intel.com \
--to=peter.senna@linux.intel.com \
--cc=adrinael@adrinael.net \
--cc=ewelina.musial@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
--cc=katarzyna.piecielska@intel.com \
--cc=konrad.b.brodzik@intel.com \
--cc=mateusz.grabski@intel.com \
--cc=ryszard.knop@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox