From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Marcin Bernatowicz" <marcin.bernatowicz@linux.intel.com>,
"Adam Miszczak" <adam.miszczak@linux.intel.com>,
"Jakub Kolakowski" <jakub1.kolakowski@intel.com>,
"Lukasz Laguna" <lukasz.laguna@intel.com>,
"Michał Wajdeczko" <michal.wajdeczko@intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Narasimha C V" <narasimha.c.v@intel.com>,
"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
"Satyanarayana K V P" <satyanarayana.k.v.p@intel.com>,
"Tomasz Lis" <tomasz.lis@intel.com>
Subject: [PATCH v2 i-g-t 4/5] tests/xe_sriov_scheduling: nonpreempt-engine-resets subtest
Date: Wed, 12 Feb 2025 19:47:56 +0100 [thread overview]
Message-ID: <20250212184757.586071-5-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20250212184757.586071-1-marcin.bernatowicz@linux.intel.com>
Verify the occurrence of engine resets
when non-preemptible workloads surpass the combined
duration of execution quantum and preemption timeout.
v2:
- Replace magic numbers with defines (Lukasz)
- Reuse adjusted prepare_vf_sched_params
- Remove redundant asserts
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Michał Wajdeczko <michal.wajdeczko@intel.com>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Cc: Narasimha C V <narasimha.c.v@intel.com>
Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
Cc: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: Tomasz Lis <tomasz.lis@intel.com>
---
tests/intel/xe_sriov_scheduling.c | 94 +++++++++++++++++++++++++++++++
1 file changed, 94 insertions(+)
diff --git a/tests/intel/xe_sriov_scheduling.c b/tests/intel/xe_sriov_scheduling.c
index a9ac950cf..fe037c1dc 100644
--- a/tests/intel/xe_sriov_scheduling.c
+++ b/tests/intel/xe_sriov_scheduling.c
@@ -620,6 +620,87 @@ static void throughput_ratio(int pf_fd, int num_vfs, const struct subm_opts *opt
igt_sriov_disable_vfs(pf_fd);
}
+/**
+ * SUBTEST: nonpreempt-engine-resets
+ * Description:
+ * Check all VFs running a non-preemptible workload with a duration
+ * exceeding the sum of its execution quantum and preemption timeout,
+ * will experience engine reset due to preemption timeout.
+ */
+static void nonpreempt_engine_resets(int pf_fd, int num_vfs,
+ const struct subm_opts *opts)
+{
+ struct subm_set set_ = {}, *set = &set_;
+ struct vf_sched_params vf_sched_params = prepare_vf_sched_params(num_vfs, 1,
+ JOB_TIMEOUT_MS, opts);
+ uint64_t duration_ms = 2 * vf_sched_params.exec_quantum_ms +
+ vf_sched_params.preempt_timeout_us / USEC_PER_MSEC;
+ int preemptible_end = 1;
+ uint8_t vf_ids[num_vfs + 1 /*PF*/];
+
+ igt_info("eq=%ums pt=%uus duration=%lums num_vfs=%d\n",
+ vf_sched_params.exec_quantum_ms,
+ vf_sched_params.preempt_timeout_us, duration_ms, num_vfs);
+
+ init_vf_ids(vf_ids, ARRAY_SIZE(vf_ids),
+ &(struct init_vf_ids_opts){ .shuffle = true,
+ .shuffle_pf = true });
+ xe_sriov_require_default_scheduling_attributes(pf_fd);
+ /* enable VFs */
+ igt_sriov_disable_driver_autoprobe(pf_fd);
+ igt_sriov_enable_vfs(pf_fd, num_vfs);
+ /* set scheduling params (PF and VFs) */
+ set_vfs_scheduling_params(pf_fd, num_vfs, &vf_sched_params);
+ /* probe VFs */
+ igt_sriov_enable_driver_autoprobe(pf_fd);
+ for (int vf = 1; vf <= num_vfs; ++vf)
+ igt_sriov_bind_vf_drm_driver(pf_fd, vf);
+
+ /* init subm_set */
+ subm_set_alloc_data(set, num_vfs + 1 /*PF*/);
+ subm_set_init_sync_method(set, opts->sync_method);
+
+ for (int n = 0; n < set->ndata; ++n) {
+ int vf_fd =
+ vf_ids[n] ?
+ igt_sriov_open_vf_drm_device(pf_fd, vf_ids[n]) :
+ drm_reopen_driver(pf_fd);
+
+ igt_assert_fd(vf_fd);
+ set->data[n].opts = opts;
+ subm_init(&set->data[n].subm, vf_fd, vf_ids[n], 0,
+ xe_engine(vf_fd, 0)->instance);
+ subm_workload_init(&set->data[n].subm,
+ &(struct subm_work_desc){
+ .duration_ms = duration_ms,
+ .preempt = (n < preemptible_end),
+ .repeats = MIN_NUM_REPEATS });
+ igt_stats_init_with_size(&set->data[n].stats.samples,
+ set->data[n].subm.work.repeats);
+ if (set->sync_method == SYNC_BARRIER)
+ set->data[n].barrier = &set->barrier;
+ }
+
+ /* dispatch spinners, wait for results */
+ subm_set_dispatch_and_wait_threads(set);
+
+ /* verify results */
+ for (int n = 0; n < set->ndata; ++n) {
+ if (n < preemptible_end) {
+ igt_assert_eq(0, set->data[n].stats.num_early_finish);
+ igt_assert_eq(set->data[n].subm.work.repeats,
+ set->data[n].stats.samples.n_values);
+ } else {
+ igt_assert_eq(1, set->data[n].stats.num_early_finish);
+ }
+ }
+
+ /* cleanup */
+ subm_set_fini(set);
+ set_vfs_scheduling_params(pf_fd, num_vfs, &(struct vf_sched_params){});
+ igt_sriov_disable_vfs(pf_fd);
+}
+
static struct subm_opts subm_opts = {
.sync_method = SYNC_BARRIER,
.outlier_treshold = 0.1,
@@ -697,6 +778,19 @@ igt_main_args("", long_opts, help_str, subm_opts_handler, NULL)
throughput_ratio(pf_fd, vf, &subm_opts);
}
+ igt_describe("Check VFs experience engine reset due to preemption timeout");
+ igt_subtest_with_dynamic("nonpreempt-engine-resets") {
+ if (extended_scope)
+ for_each_sriov_num_vfs(pf_fd, vf)
+ igt_dynamic_f("numvfs-%d", vf)
+ nonpreempt_engine_resets(pf_fd, vf,
+ &subm_opts);
+
+ for_random_sriov_vf(pf_fd, vf)
+ igt_dynamic("numvfs-random")
+ nonpreempt_engine_resets(pf_fd, vf, &subm_opts);
+ }
+
igt_fixture {
set_vfs_scheduling_params(pf_fd, igt_sriov_get_total_vfs(pf_fd),
&(struct vf_sched_params){});
--
2.31.1
next prev parent reply other threads:[~2025-02-12 18:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 18:47 [PATCH v2 i-g-t 0/5] Add SR-IOV provisioning scheduling attributes and tests Marcin Bernatowicz
2025-02-12 18:47 ` [PATCH v2 i-g-t 1/5] lib/xe/xe_sriov_provisioning: Add scheduling attributes accessors Marcin Bernatowicz
2025-02-12 18:47 ` [PATCH v2 i-g-t 2/5] lib/xe/xe_sriov_provisioning: Add helper to check default scheduling attributes Marcin Bernatowicz
2025-02-12 18:47 ` [PATCH v2 i-g-t 3/5] tests/xe_sriov_scheduling: VF equal-throughput validation Marcin Bernatowicz
2025-02-14 14:32 ` Laguna, Lukasz
2025-02-12 18:47 ` Marcin Bernatowicz [this message]
2025-02-14 14:32 ` [PATCH v2 i-g-t 4/5] tests/xe_sriov_scheduling: nonpreempt-engine-resets subtest Laguna, Lukasz
2025-02-12 18:47 ` [PATCH v2 i-g-t 5/5] tests/xe_sriov_scheduling: Get job timeout from sysfs Marcin Bernatowicz
2025-02-14 10:21 ` K V P, Satyanarayana
2025-02-14 14:33 ` Laguna, Lukasz
2025-02-13 3:01 ` ✓ i915.CI.BAT: success for Add SR-IOV provisioning scheduling attributes and tests (rev2) Patchwork
2025-02-13 3:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-13 12:46 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-13 15:02 ` Bernatowicz, Marcin
2025-02-13 16:51 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212184757.586071-5-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=adam.miszczak@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=lukasz.laguna@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
--cc=narasimha.c.v@intel.com \
--cc=piotr.piorkowski@intel.com \
--cc=satyanarayana.k.v.p@intel.com \
--cc=tomasz.lis@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox