From: Oak Zeng <oak.zeng@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Thomas.Hellstrom@linux.intel.com, matthew.brost@intel.com,
kamil.konieczny@intel.com, zbigniew.kempczynski@intel.com,
ashutosh.dixit@intel.com, juha-pekka.heikkila@intel.com,
rodrigo.vivi@intel.com
Subject: [i-g-t v2 3/4] tests/intel/xe_vm: Exclude invalid_flags tests from LNL and BMG
Date: Fri, 14 Feb 2025 16:59:19 -0500 [thread overview]
Message-ID: <20250214215920.282425-4-oak.zeng@intel.com> (raw)
In-Reply-To: <20250214215920.282425-1-oak.zeng@intel.com>
Due to a fix of out of bound prefetch issue, we now allow scratch
page coexist with fault mode on LNL and BMG, thus exclude those
tests on such HW.
Signed-off-by: Oak Zeng <oak.zeng@intel.com>
---
tests/intel/xe_vm.c | 47 ++++++++++++++++++++++++++++++---------------
1 file changed, 32 insertions(+), 15 deletions(-)
diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index 0730dd3d3..834e0afd7 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -2349,6 +2349,7 @@ igt_main
struct drm_xe_engine_class_instance *hwe, *hwe_non_copy = NULL;
uint64_t bind_size;
int fd;
+ uint16_t dev_id;
const struct section {
const char *name;
int bo_n_pages;
@@ -2441,23 +2442,28 @@ igt_main
{ NULL },
};
- const struct vm_create_section {
- const char *name;
- __u32 flags;
- } xe_vm_create_invalid_flags[] = {
- { "xe_vm_create_fault", DRM_XE_VM_CREATE_FLAG_FAULT_MODE },
- { "xe_vm_create_scratch_fault",
- DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE |
- DRM_XE_VM_CREATE_FLAG_FAULT_MODE },
- { "xe_vm_create_scratch_fault_lr",
- ~(DRM_XE_VM_CREATE_FLAG_LR_MODE |
- DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE |
- DRM_XE_VM_CREATE_FLAG_FAULT_MODE) },
- { }
- };
+ const struct vm_create_section {
+ const char *name;
+ __u32 flags;
+ } xe_vm_create_invalid_flags1[] = {
+ { "xe_vm_create_fault", DRM_XE_VM_CREATE_FLAG_FAULT_MODE },
+ { }
+ };
+
+ const struct vm_create_section xe_vm_create_invalid_flags2[] = {
+ { "xe_vm_create_scratch_fault",
+ DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE |
+ DRM_XE_VM_CREATE_FLAG_FAULT_MODE },
+ { "xe_vm_create_scratch_fault_lr",
+ ~(DRM_XE_VM_CREATE_FLAG_LR_MODE |
+ DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE |
+ DRM_XE_VM_CREATE_FLAG_FAULT_MODE) },
+ { }
+ };
igt_fixture {
fd = drm_open_driver(DRIVER_XE);
+ dev_id = intel_get_drm_devid(fd);
xe_for_each_engine(fd, hwe)
if (hwe->engine_class != DRM_XE_ENGINE_CLASS_COPY) {
@@ -2715,11 +2721,22 @@ igt_main
}
}
- for (const struct vm_create_section *s = xe_vm_create_invalid_flags; s->name; s++) {
+ for (const struct vm_create_section *s = xe_vm_create_invalid_flags1;
+ s->name; s++) {
igt_subtest_f("invalid-flag-%s", s->name)
invalid_flag(fd, s->flags);
}
+ for (const struct vm_create_section *s = xe_vm_create_invalid_flags2;
+ s->name; s++) {
+ igt_subtest_f("invalid-flag-%s", s->name) {
+ igt_skip_on_f(IS_LUNARLAKE(dev_id) ||
+ IS_BATTLEMAGE(dev_id),
+ "Skip test on this platform\n");
+ invalid_flag(fd, s->flags);
+ }
+ }
+
igt_subtest("invalid-extensions")
invalid_extensions(fd);
--
2.26.3
next prev parent reply other threads:[~2025-02-14 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 21:59 [i-g-t v2 0/4] xe: Test scratch page under fault mode Oak Zeng
2025-02-14 21:59 ` [i-g-t v2 1/4] lib/xe: Fix a comment error Oak Zeng
2025-02-14 21:59 ` [i-g-t v2 2/4] lib/xe/xe_util: Introduce helper functions Oak Zeng
2025-02-18 6:58 ` Zbigniew Kempczyński
2025-02-18 16:38 ` Zeng, Oak
2025-02-20 5:41 ` Zbigniew Kempczyński
2025-02-14 21:59 ` Oak Zeng [this message]
2025-02-14 21:59 ` [i-g-t v2 4/4] tests/intel/xe_exec_fault_mode: Test scratch page under fault mode Oak Zeng
2025-02-14 23:52 ` ✗ GitLab.Pipeline: warning for xe: " Patchwork
2025-02-15 0:19 ` ✓ i915.CI.BAT: success " Patchwork
2025-02-15 0:51 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-15 4:09 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-16 5:11 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214215920.282425-4-oak.zeng@intel.com \
--to=oak.zeng@intel.com \
--cc=Thomas.Hellstrom@linux.intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
--cc=kamil.konieczny@intel.com \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox