From: "José Expósito" <jose.exposito89@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: louis.chauvet@bootlin.com, "José Expósito" <jose.exposito89@gmail.com>
Subject: [PATCH i-g-t 20/39] tests/vkms_configfs: Test enablement without pipeline items
Date: Tue, 18 Feb 2025 17:49:52 +0100 [thread overview]
Message-ID: <20250218165011.9123-21-jose.exposito89@gmail.com> (raw)
In-Reply-To: <20250218165011.9123-1-jose.exposito89@gmail.com>
It shouldn't be possible to enable a device without creating and
attaching its pipeline items.
Test that the device is not enabled and also that no actual device was
created using libdrm.
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
tests/vkms/vkms_configfs.c | 60 ++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/tests/vkms/vkms_configfs.c b/tests/vkms/vkms_configfs.c
index dc3dbe80d..87d660fff 100644
--- a/tests/vkms/vkms_configfs.c
+++ b/tests/vkms/vkms_configfs.c
@@ -108,6 +108,42 @@ static bool attach(const char *src_path, const char *dst_path,
return ret == 0;
}
+static drmDevicePtr find_device(const char *name, drmDevicePtr *devices,
+ int n_devices)
+{
+ drmDevicePtr dev;
+ const char *dev_name;
+
+ for (int i = 0; i < n_devices; i++) {
+ dev = devices[i];
+
+ if (!(dev->available_nodes & BIT(DRM_NODE_PRIMARY)))
+ continue;
+
+ if (dev->bustype != DRM_BUS_PLATFORM)
+ continue;
+
+ dev_name = dev->businfo.platform->fullname;
+ if (strncmp(name, dev_name, strlen(name)) == 0)
+ return dev;
+ }
+
+ return NULL;
+}
+
+static bool device_exists(const char *name)
+{
+ drmDevicePtr devices[64];
+ int n_devices;
+ bool exists;
+
+ n_devices = drmGetDevices(devices, ARRAY_SIZE(devices));
+ exists = !!find_device(name, devices, n_devices);
+ drmFreeDevices(devices, n_devices);
+
+ return exists;
+}
+
/**
* SUBTEST: device-default-files
* Description: Test that creating a VKMS device creates the default files and
@@ -689,6 +725,29 @@ static void test_attach_connector_to_encoder(void)
igt_vkms_device_destroy(dev2);
}
+/**
+ * SUBTEST: enable-no-pipeline-items
+ * Description: Try to enable a VKMS device without adding any pipeline items
+ * and test that it fails.
+ */
+
+static void test_enable_no_pipeline_items(void)
+{
+ igt_vkms_t *dev;
+
+ dev = igt_vkms_device_create(__func__);
+ igt_assert(dev);
+
+ /* Try to enable it and check that the device is not set as enabled */
+ igt_vkms_device_set_enabled(dev, true);
+ igt_assert(!igt_vkms_device_is_enabled(dev));
+
+ /* Check that no actual device was created*/
+ igt_assert(!device_exists(__func__));
+
+ igt_vkms_device_destroy(dev);
+}
+
igt_main
{
struct {
@@ -711,6 +770,7 @@ igt_main
{ "attach-plane-to-crtc", test_attach_plane_to_crtc },
{ "attach-encoder-to-crtc", test_attach_encoder_to_crtc },
{ "attach-connector-to-encoder", test_attach_connector_to_encoder },
+ { "enable-no-pipeline-items", test_enable_no_pipeline_items },
};
igt_fixture {
--
2.48.1
next prev parent reply other threads:[~2025-02-19 9:31 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 16:49 [PATCH i-g-t 00/39] VKMS configfs tests José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 01/39] lib/drmtest: Add VKMS as a known driver type José Expósito
2025-02-27 13:12 ` Louis Chauvet
2025-03-13 17:22 ` José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 02/39] lib/igt_debugfs: Move is_mountpoint() to igt_aux José Expósito
2025-02-27 13:12 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 03/39] lib/igt_configfs: Add helper to mount configfs José Expósito
2025-02-27 13:14 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 04/39] lib/vkms: Add minimal VKMS library and test device default files José Expósito
2025-02-27 13:12 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 05/39] lib/vkms: Allow to enable/disable VKMS devices José Expósito
2025-02-27 13:15 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 06/39] tests/vkms_configfs: Test device invalid values José Expósito
2025-02-27 13:14 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 07/39] lib/vkms: Test plane default files José Expósito
2025-02-27 13:15 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 08/39] lib/vkms: Test plane default values José Expósito
2025-02-27 13:15 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 09/39] lib/vkms: Test plane invalid values José Expósito
2025-02-27 13:14 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 10/39] lib/vkms: Test CRTC default files José Expósito
2025-02-27 13:15 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 11/39] lib/vkms: Test CRTC default values José Expósito
2025-02-27 13:12 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 12/39] lib/vkms: Test CRTC invalid values José Expósito
2025-02-27 13:12 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 13/39] lib/vkms: Test encoder default files José Expósito
2025-02-27 13:14 ` Louis Chauvet
2025-03-13 17:25 ` José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 14/39] lib/vkms: Test connector " José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 15/39] lib/vkms: Test connector default values José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 16/39] lib/vkms: Test plane connector invalid values José Expósito
2025-02-27 13:12 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 17/39] lib/vkms: Test attaching planes to CRTCs José Expósito
2025-02-27 13:15 ` Louis Chauvet
2025-03-13 17:23 ` José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 18/39] lib/vkms: Test attaching encoders " José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 19/39] lib/vkms: Test attaching connectors to encoders José Expósito
2025-02-18 16:49 ` José Expósito [this message]
2025-02-27 13:06 ` [PATCH i-g-t 20/39] tests/vkms_configfs: Test enablement without pipeline items Louis Chauvet
2025-02-28 1:47 ` Greg Kroah-Hartman
2025-02-28 11:58 ` José Expósito
2025-02-18 16:49 ` [PATCH i-g-t 21/39] lib/vkms: Create VKMS device from static config José Expósito
2025-02-27 14:30 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 22/39] tests/vkms_configfs: Test adding too many planes José Expósito
2025-02-27 14:53 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 23/39] tests/vkms_configfs: Test not adding a primary plane José Expósito
2025-02-27 14:54 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 24/39] tests/vkms_configfs: Test adding multiple primary planes José Expósito
2025-02-27 15:00 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 25/39] tests/vkms_configfs: Test adding multiple cursor planes José Expósito
2025-02-27 15:00 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 26/39] tests/vkms_configfs: Test adding a plane without possible CRTCs José Expósito
2025-02-27 15:01 ` Louis Chauvet
2025-02-18 16:49 ` [PATCH i-g-t 27/39] tests/vkms_configfs: Test enabling a device without CRTCs José Expósito
2025-02-27 15:15 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 28/39] tests/vkms_configfs: Test enabling a device with too many CRTCs José Expósito
2025-02-27 15:05 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 29/39] tests/vkms_configfs: Test enabling a device without encoders José Expósito
2025-02-27 15:05 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 30/39] tests/vkms_configfs: Test enabling a device with too many encoders José Expósito
2025-02-27 15:05 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 31/39] tests/vkms_configfs: Test adding an encoder without possible CRTCs José Expósito
2025-02-27 15:15 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 32/39] tests/vkms_configfs: Test adding a CRTC without encoders José Expósito
2025-02-27 15:15 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 33/39] tests/vkms_configfs: Test enabling a device without connectors José Expósito
2025-02-27 15:15 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 34/39] tests/vkms_configfs: Test enabling a device with too many connectors José Expósito
2025-02-27 15:15 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 35/39] lib/vkms: Test changing enabled device planes José Expósito
2025-02-28 8:51 ` Louis Chauvet
2025-02-28 11:52 ` José Expósito
2025-02-28 22:15 ` Louis Chauvet
2025-02-18 16:50 ` [PATCH i-g-t 36/39] lib/vkms: Test changing enabled device CRTCs José Expósito
2025-02-18 16:50 ` [PATCH i-g-t 37/39] lib/vkms: Test changing enabled device encoders José Expósito
2025-02-18 16:50 ` [PATCH i-g-t 38/39] lib/vkms: Test changing enabled device connectors José Expósito
2025-02-18 16:50 ` [PATCH i-g-t 39/39] tests/vkms_configfs: Test connector hot-plug José Expósito
2025-02-28 8:51 ` Louis Chauvet
2025-02-27 13:11 ` [PATCH i-g-t 00/39] VKMS configfs tests Louis Chauvet
2025-02-28 21:22 ` ✓ Xe.CI.BAT: success for VKMS configfs tests (rev3) Patchwork
2025-02-28 21:25 ` ✓ i915.CI.BAT: " Patchwork
2025-03-01 5:04 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-01 9:43 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218165011.9123-21-jose.exposito89@gmail.com \
--to=jose.exposito89@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=louis.chauvet@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox