From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
Jakub Kolakowski <jakub1.kolakowski@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Lukasz Laguna <lukasz.laguna@intel.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH i-g-t 2/2] tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no utilization data
Date: Tue, 4 Mar 2025 19:56:40 +0100 [thread overview]
Message-ID: <20250304185640.1333849-3-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20250304185640.1333849-1-marcin.bernatowicz@linux.intel.com>
Replace igt_require with igt_assert to enforce that num_engines is
nonzero rather than skipping the test. This ensures the test fails
explicitly if engine utilization data is missing.
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/intel/xe_drm_fdinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/intel/xe_drm_fdinfo.c b/tests/intel/xe_drm_fdinfo.c
index d18fe10d8..ddf6efb2b 100644
--- a/tests/intel/xe_drm_fdinfo.c
+++ b/tests/intel/xe_drm_fdinfo.c
@@ -367,7 +367,7 @@ static void basic_engine_utilization(int xe)
ARRAY_SIZE(engine_map), NULL, 0);
igt_assert_f(ret != 0, "failed with err:%d\n", errno);
igt_assert(!strcmp(info.driver, "xe"));
- igt_require(info.num_engines);
+ igt_assert(info.num_engines);
}
static void
--
2.31.1
next prev parent reply other threads:[~2025-03-04 18:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 18:56 [PATCH i-g-t 0/2] tests/xe_drm_fdinfo: Check prerequisites for utilization tests Marcin Bernatowicz
2025-03-04 18:56 ` [PATCH i-g-t 1/2] tests/intel/xe_drm_fdinfo: Group utilization tests and skip when no utilization data Marcin Bernatowicz
2025-03-05 12:15 ` Kamil Konieczny
2025-03-05 16:31 ` Bernatowicz, Marcin
2025-03-06 10:56 ` Kamil Konieczny
2025-03-05 17:08 ` Lucas De Marchi
2025-03-06 9:19 ` Bernatowicz, Marcin
2025-03-13 4:19 ` Lucas De Marchi
2025-03-13 11:37 ` Zbigniew Kempczyński
2025-03-04 18:56 ` Marcin Bernatowicz [this message]
2025-03-05 8:05 ` ✓ Xe.CI.BAT: success for tests/xe_drm_fdinfo: Check prerequisites for utilization tests (rev2) Patchwork
2025-03-05 8:35 ` ✓ i915.CI.BAT: " Patchwork
2025-03-05 9:02 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-05 12:34 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304185640.1333849-3-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=lukasz.laguna@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox