From: Tom Chung <chiahsuan.chung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <alex.hung@amd.com>, <sunpeng.li@amd.com>, <chiahsuan.chung@amd.com>
Subject: [PATCH i-g-t] tests/amdgpu/amd_hotplug: Check the suspend state after resume
Date: Mon, 10 Mar 2025 17:13:48 +0800 [thread overview]
Message-ID: <20250310091440.2045-1-chiahsuan.chung@amd.com> (raw)
[Why & How]
Check the last hardware sleep state after resume to make sure
last suspend really reached hardware sleep state.
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
---
tests/amdgpu/amd_hotplug.c | 48 ++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/tests/amdgpu/amd_hotplug.c b/tests/amdgpu/amd_hotplug.c
index c13bf49d3..df394f920 100644
--- a/tests/amdgpu/amd_hotplug.c
+++ b/tests/amdgpu/amd_hotplug.c
@@ -27,6 +27,8 @@ IGT_TEST_DESCRIPTION("Test simulated hotplugging on connectors");
/* Maximum pipes on any AMD ASIC. */
#define MAX_PIPES 6
+#define LAST_HW_SLEEP_PATH "/sys/power/suspend_stats/last_hw_sleep"
+#define MEM_SLEEP_PATH "/sys/power/mem_sleep"
/* Common test data. */
typedef struct data {
@@ -98,6 +100,47 @@ static void test_fini(data_t *data)
igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0);
}
+/* Check if mem_sleep is s2idle */
+static bool is_system_s2idle(void)
+{
+ int fd;
+ char dst[64];
+ int read_byte;
+
+ fd = open(MEM_SLEEP_PATH, O_RDONLY);
+ if (fd == -1)
+ igt_skip("Open %s file error\n", MEM_SLEEP_PATH);
+
+ read_byte = read(fd, dst, sizeof(dst));
+ close(fd);
+
+ if (read_byte <= 0)
+ igt_skip("Read %s file error\n", MEM_SLEEP_PATH);
+
+ return strstr(dst, "[s2idle]");
+}
+
+
+/* return the last hw_sleep duration time */
+static int get_last_hw_sleep_time(void)
+{
+ int fd;
+ char dst[64];
+ int read_byte;
+
+ fd = open(LAST_HW_SLEEP_PATH, O_RDONLY);
+ if (fd == -1)
+ igt_skip("Open HW sleep statistics file error\n");
+
+ read_byte = read(fd, dst, sizeof(dst));
+ close(fd);
+
+ if (read_byte <= 0)
+ igt_skip("Read HW sleep statistics file error\n");
+
+ return strtol(dst, NULL, 10);
+}
+
static void test_hotplug_basic(data_t *data, bool suspend)
{
igt_output_t *output;
@@ -131,8 +174,13 @@ static void test_hotplug_basic(data_t *data, bool suspend)
}
if (suspend) {
+ if (!is_system_s2idle())
+ igt_skip("System is not configured for s2idle\n");
+
igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
SUSPEND_TEST_NONE);
+ igt_assert_f(get_last_hw_sleep_time() > 0,
+ "Suspend did not reach hardware sleep state\n");
}
/* Trigger hotplug and confirm reference image is the same. */
--
2.43.0
next reply other threads:[~2025-03-10 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 9:13 Tom Chung [this message]
2025-03-10 12:27 ` ✓ i915.CI.BAT: success for tests/amdgpu/amd_hotplug: Check the suspend state after resume Patchwork
2025-03-10 12:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-10 14:42 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-11 6:37 ` ✓ Xe.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310091440.2045-1-chiahsuan.chung@amd.com \
--to=chiahsuan.chung@amd.com \
--cc=alex.hung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox