From: Pawel Sikora <pawel.sikora@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Thomas Wood <thomas.wood@intel.com>,
Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
Subject: [PATCH i-g-t 1/1] lib/igt_core: capture logs for child processes
Date: Thu, 13 Mar 2025 13:50:04 +0100 [thread overview]
Message-ID: <20250313125004.3881354-2-pawel.sikora@linux.intel.com> (raw)
In-Reply-To: <20250313125004.3881354-1-pawel.sikora@linux.intel.com>
This change addresses the issue of missing logs for child
processes in the IGT runner.
The '_igt_log_buffer_dump()' function is now called before
exiting child processes, ensuring that logs are properly
captured and not lost when IGT fails and child processes
dump logs before exiting.
Signed-off-by: Pawel Sikora <pawel.sikora@linux.intel.com>
---
lib/igt_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 9702a9417..33e5ca7cd 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1905,12 +1905,11 @@ void igt_fail(int exitcode)
failed_one = true;
}
- /* Silent exit, parent will do the yelling. */
+ _igt_log_buffer_dump();
+
if (test_child)
exit(exitcode);
- _igt_log_buffer_dump();
-
if (test_multi_fork_child)
exit(exitcode);
--
2.34.1
next prev parent reply other threads:[~2025-03-13 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 12:50 [PATCH i-g-t 0/1] lib/igt_core: capture logs for child processes Pawel Sikora
2025-03-13 12:50 ` Pawel Sikora [this message]
2025-03-13 14:28 ` [PATCH i-g-t 1/1] " Zbigniew Kempczyński
2025-03-17 16:39 ` Kamil Konieczny
2025-03-21 10:07 ` Pawel Sikora
2025-03-24 11:05 ` Kamil Konieczny
2025-03-14 16:46 ` ✓ Xe.CI.Full: success for " Patchwork
2025-03-15 0:43 ` ✓ Xe.CI.BAT: success for lib/igt_core: capture logs for child processes (rev2) Patchwork
2025-03-15 1:02 ` ✓ i915.CI.BAT: " Patchwork
2025-03-15 9:48 ` ✓ Xe.CI.Full: " Patchwork
2025-03-15 11:58 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-24 10:42 ` Pawel Sikora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313125004.3881354-2-pawel.sikora@linux.intel.com \
--to=pawel.sikora@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=thomas.wood@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox