Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Senna Tschudin <peter.senna@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Peter Senna Tschudin <peter.senna@linux.intel.com>,
	rodrigo.vivi@intel.com, katarzyna.piecielska@intel.com
Subject: [PATCH i-g-t 0/1] Close sysfs and debugfs test gap between i915 and Xe
Date: Tue, 18 Mar 2025 10:53:49 +0100	[thread overview]
Message-ID: <20250318095350.57133-1-peter.senna@linux.intel.com> (raw)

The existing tests/intel/debugfs_test.c scans and reads all relevant
files from sysfs and debugfs, but it is specific to i915, leaving a gap
for Xe.

A similar test exists for Xe in tests/intel/xe_debugfs.c, but it has two
gaps compared to the i915 counterpart:
 - It lacks sysfs file testing.
 - It does not attempt to read all debugfs files.

This commit addresses these gaps by adding two new tests to
tests/intel/xe_debugfs.c:
 - sysfs_read_all_entries
 - debugfs_read_all_entries

Both tests use the function read_and_discard_sysfs_entries(), which was
copied from tests/intel/debugfs_test.c.


Follow-up improvements

Once this patch is merged, I will submit a follow-up series to address
the following improvements:
 - Rename tests/intel/debugfs_test -> i915_debugfs_sysfs: The current
   name is misleading because it is i915-specific and covers both
   debugfs and sysfs.

 - Rename tests/intel/xe_debugfs -> xe_debugfs_sysfs

 - Remove redundant hwmon-basic from debugfs_test: The existing hwmon
   test is redundant since tests/intel/intel_hwmon.c already provides
   dedicated coverage for both i915 and Xe.

 - Move read_and_discard_sysfs_entries() to lib/: This function is used
   by both debugfs_test.c and xe_debugfs.c, so it should be placed in a
   shared location.


Why I am sending this patch first

The priority is to close the sysfs and debugfs testing gap between i915
and Xe now, so we have more time to upstream these changes. While the
follow-up improvements are relatively simple, they carry short-term
risks because:
 - The hwmon test removal could impact existing test lists.
 - The current test names (debugfs_test.c and xe_debugfs.c) are
   referenced in documentation and test configurations.

By addressing the test gap first, we can ensure proper coverage while
minimizing disruption. The follow-up series will refine the structure
and naming to improve long-term maintainability.

Cc: rodrigo.vivi@intel.com
Cc: katarzyna.piecielska@intel.com

Peter Senna Tschudin (1):
  tests/intel/xe_debugfs: Add tests to read all debugfs and sysfs files

 tests/intel/xe_debugfs.c | 88 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 87 insertions(+), 1 deletion(-)

-- 
2.34.1


             reply	other threads:[~2025-03-18  9:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18  9:53 Peter Senna Tschudin [this message]
2025-03-18  9:53 ` [PATCH i-g-t 1/1] tests/intel/xe_debugfs: Add tests to read all debugfs and sysfs files Peter Senna Tschudin
2025-03-18 15:56   ` Kamil Konieczny
2025-03-18 16:33     ` Peter Senna Tschudin
2025-03-18 21:41     ` Peter Senna Tschudin
2025-03-18 10:18 ` ✓ Xe.CI.BAT: success for Close sysfs and debugfs test gap between i915 and Xe Patchwork
2025-03-18 10:41 ` ✓ i915.CI.BAT: " Patchwork
2025-03-18 11:13 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-18 12:34   ` Peter Senna Tschudin
2025-03-18 12:16 ` ✗ i915.CI.Full: " Patchwork
2025-03-18 12:36   ` Peter Senna Tschudin
2025-03-19  8:55     ` Ravali, JupallyX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318095350.57133-1-peter.senna@linux.intel.com \
    --to=peter.senna@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=katarzyna.piecielska@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox