Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oak Zeng <oak.zeng@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ashutosh.dixit@intel.com, matthew.brost@intel.com,
	zbigniew.kempczynski@intel.com, kamil.konieczny@intel.com
Subject: [i-g-t v7 1/4] lib/xe: Fix a comment error
Date: Wed, 19 Mar 2025 18:42:28 -0400	[thread overview]
Message-ID: <20250319224231.1909393-2-oak.zeng@intel.com> (raw)
In-Reply-To: <20250319224231.1909393-1-oak.zeng@intel.com>

The timeout value of __xe_wait_ufence and xe_wait_ufence
returns the remaining time, not elapsed time. Fix it.

Signed-off-by: Oak Zeng <oak.zeng@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/xe/xe_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
index 6d8388918..a0d8c8f3d 100644
--- a/lib/xe/xe_ioctl.c
+++ b/lib/xe/xe_ioctl.c
@@ -496,7 +496,7 @@ void xe_exec_wait(int fd, uint32_t exec_queue, uint64_t addr)
  *
  * Function compares @value with memory pointed by @addr until they are equal.
  *
- * Returns (in @timeout), the elapsed time in nanoseconds if user fence was
+ * Returns (in @timeout), the remaining time in nanoseconds if user fence was
  * signalled. Returns 0 on success, -errno of ioctl on error.
  */
 int __xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
@@ -532,7 +532,7 @@ int __xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
  * Function compares @value with memory pointed by @addr until they are equal.
  * Asserts that ioctl returned without error.
  *
- * Returns elapsed time in nanoseconds if user fence was signalled.
+ * Returns remaining time in nanoseconds if user fence was signalled.
  */
 int64_t xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
 		       uint32_t exec_queue, int64_t timeout)
-- 
2.26.3


  reply	other threads:[~2025-03-19 22:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19 22:42 [i-g-t v7 0/4] xe: Test scratch page under fault mode Oak Zeng
2025-03-19 22:42 ` Oak Zeng [this message]
2025-03-19 22:42 ` [i-g-t v7 2/4] lib/xe/xe_util: Introduce helper functions Oak Zeng
2025-03-19 22:42 ` [i-g-t v7 3/4] tests/intel/xe_exec_fault_mode: Test scratch page under fault mode Oak Zeng
2025-03-19 22:42 ` [i-g-t v7 4/4] tests/intel/xe_vm: Allow scratch page under fault mode on LNL and BMG Oak Zeng
2025-03-20  1:14   ` Dixit, Ashutosh
2025-03-19 22:53 ` ✓ Xe.CI.BAT: success for xe: Test scratch page under fault mode (rev6) Patchwork
2025-03-19 23:19 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-19 23:40 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250319224231.1909393-2-oak.zeng@intel.com \
    --to=oak.zeng@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox