From: "André Almeida" <andrealmeid@igalia.com>
To: igt-dev@lists.freedesktop.org, Jeevan B <jeevan.b@intel.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: kernel-dev@igalia.com, "Vitaly Prosyak" <vitaly.prosyak@amd.com>,
"Alex Hung" <alex.hung@amd.com>, "Melissa Wen" <mwen@igalia.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v3 1/2] kms_async_flips: Refactor data options
Date: Thu, 20 Mar 2025 11:00:29 -0300 [thread overview]
Message-ID: <20250320140030.557446-2-andrealmeid@igalia.com> (raw)
In-Reply-To: <20250320140030.557446-1-andrealmeid@igalia.com>
Setting the test data options as true and false for every test is error
prone. Instead, reset all the data to false at the end of a test and
just set the needed options to true before running a test.
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
tests/kms_async_flips.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index da426f753..d4af9b383 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -708,6 +708,9 @@ static void run_test(data_t *data, void (*test)(data_t *))
test(data);
}
}
+
+ data->alternate_sync_async = false;
+ data->atomic_path = false;
}
static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
@@ -738,6 +741,9 @@ static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
}
}
}
+
+ data->alternate_sync_async = false;
+ data->atomic_path = false;
}
static data_t data;
@@ -757,6 +763,9 @@ igt_main
if (is_intel_device(data.drm_fd))
data.bops = buf_ops_create(data.drm_fd);
+
+ data.alternate_sync_async = false;
+ data.atomic_path = false;
}
igt_describe("Verify the async flip functionality and the fps during async flips");
@@ -766,8 +775,6 @@ igt_main
igt_describe("Wait for page flip events in between successive asynchronous flips");
igt_subtest_with_dynamic("async-flip-with-page-flip-events") {
- data.alternate_sync_async = false;
- data.atomic_path = false;
if (is_intel_device(data.drm_fd))
run_test_with_modifiers(&data, test_async_flip);
else
@@ -777,7 +784,6 @@ igt_main
igt_describe("Wait for page flip events in between successive "
"asynchronous flips using atomic path");
igt_subtest_with_dynamic("async-flip-with-page-flip-events-atomic") {
- data.alternate_sync_async = false;
data.atomic_path = true;
if (is_intel_device(data.drm_fd))
run_test_with_modifiers(&data, test_async_flip);
@@ -788,7 +794,6 @@ igt_main
igt_describe("Alternate between sync and async flips");
igt_subtest_with_dynamic("alternate-sync-async-flip") {
data.alternate_sync_async = true;
- data.atomic_path = false;
run_test(&data, test_async_flip);
}
@@ -802,7 +807,6 @@ igt_main
igt_describe("Verify that the async flip timestamp does not "
"coincide with either previous or next vblank");
igt_subtest_with_dynamic("test-time-stamp") {
- data.atomic_path = false;
run_test(&data, test_timestamp);
}
@@ -825,7 +829,6 @@ igt_main
"PSR2 sel fetch causes cursor to be added to primary plane "
"pages flips and async flip is not supported in cursor\n");
- data.atomic_path = false;
run_test(&data, test_cursor);
}
@@ -853,7 +856,6 @@ igt_main
igt_require(igt_display_has_format_mod(&data.display, DRM_FORMAT_XRGB8888,
I915_FORMAT_MOD_Y_TILED));
- data.atomic_path = false;
run_test(&data, test_invalid);
}
@@ -876,7 +878,6 @@ igt_main
/* Devices without CRC can't run this test */
igt_require_pipe_crc(data.drm_fd);
- data.atomic_path = false;
run_test(&data, test_crc);
}
--
2.49.0
next prev parent reply other threads:[~2025-03-20 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 14:00 [PATCH v3 0/2] tests/kms_async_flips: Create subtest for overlay planes André Almeida
2025-03-20 14:00 ` André Almeida [this message]
2025-03-24 21:22 ` [PATCH v3 1/2] kms_async_flips: Refactor data options Melissa Wen
2025-03-20 14:00 ` [PATCH v3 2/2] tests/kms_async_flips: Create subtest for overlay planes André Almeida
2025-03-24 21:32 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320140030.557446-2-andrealmeid@igalia.com \
--to=andrealmeid@igalia.com \
--cc=alex.hung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=mwen@igalia.com \
--cc=siqueira@igalia.com \
--cc=vitaly.prosyak@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox