Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 1/3] lib/igt_chamelium: Add chamelium_frame_match_or_dump_frame_pair()
Date: Mon, 24 Mar 2025 14:39:47 +0530	[thread overview]
Message-ID: <20250324090949.614233-2-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250324090949.614233-1-swati2.sharma@intel.com>

Add chamelium_frame_match_or_dump_frame_pair() to compare frame
dumps captured from chamelium.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 lib/igt_chamelium.c | 60 +++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_chamelium.h |  6 +++++
 2 files changed, 66 insertions(+)

diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 620fbbf7d..44a169b29 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -2070,6 +2070,66 @@ bool chamelium_frame_match_or_dump(struct chamelium *chamelium,
 	return match;
 }
 
+/**
+ * chamelium_frame_match_or_dump:
+ * @chamelium: The chamelium instance the frame dump belongs to
+ * @frame0: The chamelium reference frame dump to match
+ * @frame1: The chamelium capture frame dump to match
+ * @reference_crc: CRC of chamelium reference frame
+ * @check: the type of frame matching check to use
+ *
+ * Returns bool that the provided captured frame matches the reference
+ * frame from the framebuffer. If they do not, this saves the reference
+ * and captured frames to a png file.
+ */
+bool chamelium_frame_match_or_dump_frame_pair(struct chamelium *chamelium,
+					      struct chamelium_port *port,
+					      const struct chamelium_frame_dump *frame0,
+					      const struct chamelium_frame_dump *frame1,
+					      igt_crc_t *reference_crc,
+					      enum chamelium_check check)
+{
+	cairo_surface_t *reference;
+	cairo_surface_t *capture;
+	igt_crc_t *capture_crc;
+	bool match;
+
+	/* Grab the captured reference frame from chamelium */
+	reference = convert_frame_dump_argb32(frame0);
+
+	/* Grab the captured frame from chamelium */
+	capture = convert_frame_dump_argb32(frame1);
+
+	switch (check) {
+	case CHAMELIUM_CHECK_ANALOG:
+		match = igt_check_analog_frame_match(reference, capture);
+		break;
+	case CHAMELIUM_CHECK_CHECKERBOARD:
+		match = igt_check_checkerboard_frame_match(reference, capture);
+		break;
+	default:
+		igt_assert(false);
+	}
+
+	if (!match && igt_frame_dump_is_enabled()) {
+		/* Get the captured frame CRC from the Chamelium. */
+		capture_crc = chamelium_get_crc_for_area(chamelium, port, 0, 0,
+							 0, 0);
+		igt_assert(capture_crc);
+
+		compared_frames_dump(reference, capture, reference_crc,
+				     capture_crc);
+
+		free(reference_crc);
+		free(capture_crc);
+	}
+
+	cairo_surface_destroy(reference);
+	cairo_surface_destroy(capture);
+
+	return match;
+}
+
 /**
  * chamelium_analog_frame_crop:
  * @chamelium: The Chamelium instance to use
diff --git a/lib/igt_chamelium.h b/lib/igt_chamelium.h
index d979de4a2..140d52c95 100644
--- a/lib/igt_chamelium.h
+++ b/lib/igt_chamelium.h
@@ -257,6 +257,12 @@ bool chamelium_frame_match_or_dump(struct chamelium *chamelium,
 				   const struct chamelium_frame_dump *frame,
 				   struct igt_fb *fb,
 				   enum chamelium_check check);
+bool chamelium_frame_match_or_dump_frame_pair(struct chamelium *chamelium,
+					      struct chamelium_port *port,
+					      const struct chamelium_frame_dump *frame0,
+					      const struct chamelium_frame_dump *frame1,
+					      igt_crc_t *reference_crc,
+					      enum chamelium_check check);
 void chamelium_crop_analog_frame(struct chamelium_frame_dump *dump, int width,
 				 int height);
 void chamelium_destroy_frame_dump(struct chamelium_frame_dump *dump);
-- 
2.25.1


  reply	other threads:[~2025-03-24  9:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24  9:09 [PATCH i-g-t 0/3] Fix ctm-limited subtest Swati Sharma
2025-03-24  9:09 ` Swati Sharma [this message]
2025-03-26 12:23   ` [PATCH i-g-t 1/3] lib/igt_chamelium: Add chamelium_frame_match_or_dump_frame_pair() Borah, Chaitanya Kumar
2025-03-27  5:56     ` Sharma, Swati2
2025-03-24  9:09 ` [PATCH i-g-t 2/3] tests/chamelium/kms_chamelium_color: Fix ctm-limited-range subtest Swati Sharma
2025-03-27  5:27   ` Borah, Chaitanya Kumar
2025-03-27  6:02     ` Sharma, Swati2
2025-03-24  9:09 ` [PATCH i-g-t 3/3] tests/chamelium/kms_chamelium_color: Set rgb_full to 1.0 Swati Sharma
2025-03-27  5:30   ` Borah, Chaitanya Kumar
2025-03-24 13:27 ` ✓ Xe.CI.BAT: success for Fix ctm-limited subtest Patchwork
2025-03-24 13:27 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-03-24 13:43 ` ✗ i915.CI.BAT: " Patchwork
2025-03-24 15:18 ` ✓ Xe.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250324090949.614233-2-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox