Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: replace_with Sobin Thomas <sobin.thomas@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kamil.konieczny@intel.com, dominik.karol.piatkowski@intel.com
Subject: [PATCH 1/1] Added tests to handle error string conditions in xe_sysfs_scheduler.c
Date: Wed, 26 Mar 2025 18:03:12 +0000	[thread overview]
Message-ID: <20250326180312.1808192-2-sobin.thomas@intel.com> (raw)
In-Reply-To: <20250326180312.1808192-1-sobin.thomas@intel.com>

From: "Thomas, Sobin" <sobin.thomas@intel.com>

Signed-off-by: Thomas, Sobin <sobin.thomas@intel.com>
---
 tests/intel/xe_sysfs_scheduler.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/tests/intel/xe_sysfs_scheduler.c b/tests/intel/xe_sysfs_scheduler.c
index 4fc764f82..a0eaad5ab 100644
--- a/tests/intel/xe_sysfs_scheduler.c
+++ b/tests/intel/xe_sysfs_scheduler.c
@@ -10,6 +10,11 @@
  * Sub-category: SysMan tests
  * Functionality: scheduler control interface
  *
+ * SUBTEST: %s-invalid-string
+ * Description: Test to check if %s arg[1] schedule parameter checks for
+ * min max values.
+ * Test category: Negative string test
+ *
  * SUBTEST: %s-invalid
  * Description: Test to check if %s arg[1] schedule parameter rejects any
  *		unrepresentable intervals.
@@ -121,6 +126,23 @@ static void test_min_max(int xe, int engine, const char **property,
 	igt_assert_eq(set, default_max);
 }
 
+static void test_invalid_string(int xe, int engine, const char **property,
+                         uint16_t class, int gt)
+{
+	unsigned int saved, set;
+	char invalid_input[] = "999abc"; //Intentionally passing wrong string
+
+	for(int i=0;i<3;i++) {
+		igt_assert(igt_sysfs_scanf(engine,property[i],"%u",&saved) == 1);
+		igt_info("Initial %s:%u\n",property[i],saved);
+		igt_sysfs_printf(engine, property[i], "%s", invalid_input);
+		igt_sysfs_scanf(engine,property[i],"%u",&set);
+		igt_assert_eq(set,saved);
+		igt_info("Property %s correctly rejected input %s\n",property[i],invalid_input);
+	}
+}
+
+
 #define MAX_GTS 8
 igt_main
 {
@@ -130,6 +152,7 @@ igt_main
 	} tests[] = {
 		{ "invalid", test_invalid },
 		{ "min-max", test_min_max },
+		{ "invalid-string", test_invalid_string },
 		{ }
 	};
 
-- 
2.34.1


  reply	other threads:[~2025-03-26 18:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 18:03 [PATCH 0/1] *** IGT Test code handling error string for xe_sysfs_scheduler.c *** replace_with Sobin Thomas
2025-03-26 18:03 ` replace_with Sobin Thomas [this message]
2025-03-27  8:15   ` [PATCH 1/1] Added tests to handle error string conditions in xe_sysfs_scheduler.c Piatkowski, Dominik Karol
2025-03-27 17:23     ` Kamil Konieczny
2025-03-26 18:58 ` ✓ Xe.CI.BAT: success for *** IGT Test code handling error string for xe_sysfs_scheduler.c *** Patchwork
2025-03-26 19:17 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-27  8:14 ` [PATCH 0/1] " Piatkowski, Dominik Karol
2025-03-27  8:30 ` ✗ Xe.CI.Full: failure for " Patchwork
2025-03-27 11:56 ` Patchwork
2025-03-28 11:31 ` Patchwork
2025-04-06 16:07 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250326180312.1808192-2-sobin.thomas@intel.com \
    --to=sobin.thomas@intel.com \
    --cc=dominik.karol.piatkowski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox