Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t] tests/intel/xe_oa: Print oa_status value in the helper
Date: Wed, 26 Mar 2025 15:17:29 -0700	[thread overview]
Message-ID: <20250326221729.884253-1-umesh.nerlige.ramappa@intel.com> (raw)

OA status value is useful when any bits are set. Print the value in the
helper, so that each call to fetch the oa_status does not need to print
the debug message explicitly.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
 tests/intel/xe_oa.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index caf713c2a6df..0e9fa966464a 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -383,6 +383,9 @@ static u32 get_stream_status(int fd)
 
 	do_ioctl(fd, DRM_XE_OBSERVATION_IOCTL_STATUS, &status);
 
+	if (status.oa_status)
+		igt_debug("oa status %llx\n", status.oa_status);
+
 	return status.oa_status;
 }
 
@@ -1337,7 +1340,6 @@ read_2_oa_reports(int format_id,
 			;
 		if (errno == EIO) {
 			oa_status = get_stream_status(stream_fd);
-			igt_debug("oa_status %#x\n", oa_status);
 			continue;
 		}
 
@@ -1773,7 +1775,6 @@ static void test_oa_exponents(const struct drm_xe_engine_class_instance *hwe)
 				;
 			if (errno == EIO) {
 				oa_status = get_stream_status(stream_fd);
-				igt_debug("oa_status %#x\n", oa_status);
 				continue;
 			}
 
@@ -2505,7 +2506,6 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b
 		(len == -1 && (errno == EINTR || errno == EIO)))) {
 		if (errno == EIO) {
 			oa_status = get_stream_status(stream_fd);
-			igt_debug("oa_status %#x\n", oa_status);
 			igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW));
 		}
 		if (len > 0)
-- 
2.43.0


             reply	other threads:[~2025-03-26 22:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 22:17 Umesh Nerlige Ramappa [this message]
2025-03-26 22:24 ` [PATCH i-g-t] tests/intel/xe_oa: Print oa_status value in the helper Dixit, Ashutosh
2025-03-26 22:28   ` Umesh Nerlige Ramappa
2025-03-26 22:56 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-03-26 23:14 ` ✓ i915.CI.BAT: " Patchwork
2025-03-27  0:54 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-27 18:48   ` Umesh Nerlige Ramappa
2025-03-27 13:04 ` ✗ Xe.CI.Full: " Patchwork
2025-03-28 11:42 ` Patchwork
2025-04-06 16:17 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250326221729.884253-1-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox