From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>, <alex.hung@amd.com>
Cc: <harry.wentland@amd.com>
Subject: [PATCH V7 22/37] lib/igt_color: Support color transform for XRGB2101010
Date: Wed, 26 Mar 2025 17:35:54 -0600 [thread overview]
Message-ID: <20250326233609.2980110-23-alex.hung@amd.com> (raw)
In-Reply-To: <20250326233609.2980110-1-alex.hung@amd.com>
From: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
---
lib/igt_color.c | 113 ++++++++++++++++++++++++++++++------------------
1 file changed, 70 insertions(+), 43 deletions(-)
diff --git a/lib/igt_color.c b/lib/igt_color.c
index 5e1374e4b..43179a17e 100644
--- a/lib/igt_color.c
+++ b/lib/igt_color.c
@@ -126,6 +126,74 @@ void igt_color_ctm_3x4_bt709_dec(igt_pixel_t *pixel)
igt_color_apply_3x4_ctm(pixel, &igt_matrix_3x4_bt709_dec);
}
+static void
+igt_color_fourcc_to_pixel(uint32_t raw_pixel, uint32_t drm_format, igt_pixel_t *pixel)
+{
+ if (drm_format == DRM_FORMAT_XRGB8888) {
+ raw_pixel &= 0x00ffffff;
+
+ pixel->r = (raw_pixel & 0x00ff0000) >> 16;
+ pixel->g = (raw_pixel & 0x0000ff00) >> 8;
+ pixel->b = (raw_pixel & 0x000000ff);
+
+ /* normalize for 8-bit */
+ pixel->r /= (0xff);
+ pixel->g /= (0xff);
+ pixel->b /= (0xff);
+ } else if (drm_format == DRM_FORMAT_XRGB2101010) {
+ raw_pixel &= 0x3fffffff;
+
+ pixel->r = (raw_pixel & 0x3ff00000) >> 20;
+ pixel->g = (raw_pixel & 0x000ffc00) >> 10;
+ pixel->b = (raw_pixel & 0x000003ff);
+
+ /* normalize for 10-bit */
+ pixel->r /= (0x3ff);
+ pixel->g /= (0x3ff);
+ pixel->b /= (0x3ff);
+ } else {
+ igt_skip("pixel format support not implemented");
+ }
+}
+
+static uint32_t
+igt_color_pixel_to_fourc(uint32_t drm_format, igt_pixel_t *pixel)
+{
+ uint32_t raw_pixel;
+
+ /* clip */
+ pixel->r = fmax(fmin(pixel->r, 1.0), 0.0);
+ pixel->g = fmax(fmin(pixel->g, 1.0), 0.0);
+ pixel->b = fmax(fmin(pixel->b, 1.0), 0.0);
+
+ if (drm_format == DRM_FORMAT_XRGB8888) {
+ /* de-normalize back to 8-bit */
+ pixel->r *= (0xff);
+ pixel->g *= (0xff);
+ pixel->b *= (0xff);
+
+ /* re-pack pixel into FB*/
+ raw_pixel = 0x0;
+ raw_pixel |= ((uint8_t) (lround(pixel->r) & 0xff)) << 16;
+ raw_pixel |= ((uint8_t) (lround(pixel->g) & 0xff)) << 8;
+ raw_pixel |= ((uint8_t) (lround(pixel->b) & 0xff));
+ } else if (drm_format == DRM_FORMAT_XRGB2101010) {
+ /* de-normalize back to 10-bit */
+ pixel->r *= (0x3ff);
+ pixel->g *= (0x3ff);
+ pixel->b *= (0x3ff);
+
+ /* re-pack pixel into FB*/
+ raw_pixel = 0x0;
+ raw_pixel |= (lround(pixel->r) & 0x3ff) << 20;
+ raw_pixel |= (lround(pixel->g) & 0x3ff) << 10;
+ raw_pixel |= (lround(pixel->b) & 0x3ff);
+ } else {
+ igt_skip("pixel format support not implemented");
+ }
+
+ return raw_pixel;
+}
int igt_color_transform_pixels(igt_fb_t *fb, igt_pixel_transform transforms[], int num_transforms)
{
@@ -138,10 +206,6 @@ int igt_color_transform_pixels(igt_fb_t *fb, igt_pixel_transform transforms[], i
if (fb->num_planes != 1)
return -EINVAL;
- /* TODO expand for other formats */
- if (fb->drm_format != DRM_FORMAT_XRGB8888)
- return -EINVAL;
-
ptr = igt_fb_map_buffer(fb->fd, fb);
igt_assert(ptr);
map = ptr;
@@ -167,51 +231,14 @@ int igt_color_transform_pixels(igt_fb_t *fb, igt_pixel_transform transforms[], i
igt_pixel_t pixel;
int i;
- raw_pixel &= 0x00ffffff;
-
- /*
- * unpack pixel into igt_pixel_t
- *
- * only for XRGB8888 for now
- *
- * TODO add "generic" mechanism for unpacking
- * other FB formats
- */
- pixel.r = (raw_pixel & 0x00ff0000) >> 16;
- pixel.g = (raw_pixel & 0x0000ff00) >> 8;
- pixel.b = (raw_pixel & 0x000000ff);
-
- /* normalize for 8-bit */
- pixel.r /= (0xff);
- pixel.g /= (0xff);
- pixel.b /= (0xff);
-
- /* TODO use read_rgb from igt_fb? */
+ igt_color_fourcc_to_pixel(raw_pixel, fb->drm_format, &pixel);
/* run transform on pixel */
-
for (i = 0; i < num_transforms; i++)
transforms[i](&pixel);
- /* clip */
- pixel.r = fmax(fmin(pixel.r, 1.0), 0.0);
- pixel.g = fmax(fmin(pixel.g, 1.0), 0.0);
- pixel.b = fmax(fmin(pixel.b, 1.0), 0.0);
-
- /* de-normalize back to 8-bit */
- pixel.r *= (0xff);
- pixel.g *= (0xff);
- pixel.b *= (0xff);
-
- /* re-pack pixel into FB*/
- raw_pixel = 0x0;
- raw_pixel |= ((uint8_t) (lround(pixel.r) & 0xff)) << 16;
- raw_pixel |= ((uint8_t) (lround(pixel.g) & 0xff)) << 8;
- raw_pixel |= ((uint8_t) (lround(pixel.b) & 0xff));
- /* TODO use write_rgb from igt_fb? */
-
/* write back to line */
- line[x] = cpu_to_le32(raw_pixel);
+ line[x] = cpu_to_le32(igt_color_pixel_to_fourc(fb->drm_format, &pixel));
}
/* copy line back to fb buffer */
--
2.43.0
next prev parent reply other threads:[~2025-03-26 23:44 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 23:35 [PATCH V7 00/37] IGT tests for the KMS Color Pipeline API Alex Hung
2025-03-26 23:35 ` [PATCH V7 01/37] lib/drmtest: Add is_vkms_device() Alex Hung
2025-03-26 23:35 ` [PATCH V7 02/37] tests/kms_writeback: Fix kms_writeback for VKMS Alex Hung
2025-03-26 23:35 ` [PATCH V7 03/37] lib/igt_kms: Move get_writeback_formats_blob to lib Alex Hung
2025-04-03 6:41 ` Sharma, Swati2
2025-03-26 23:35 ` [PATCH V7 04/37] lib/igt_kms: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE Alex Hung
2025-03-26 23:35 ` [PATCH V7 05/37] include/drm-uapi: Add COLOROP object Alex Hung
2025-03-26 23:35 ` [PATCH V7 06/37] drm-uapi: Add 3x4 CTM Alex Hung
2025-03-26 23:35 ` [PATCH V7 07/37] drm-uapi: Add 1D LUT drm_colorop_type Alex Hung
2025-03-26 23:35 ` [PATCH V7 08/37] lib/igt_kms: Introduce drm_colorop and COLOR_PIPELINE Alex Hung
2025-04-03 10:04 ` Sharma, Swati2
2025-03-26 23:35 ` [PATCH V7 09/37] tests/kms_properties: Add colorop properties test Alex Hung
2025-03-26 23:35 ` [PATCH V7 10/37] igt/color: Add SW color transform functionality Alex Hung
2025-03-26 23:35 ` [PATCH V7 11/37] lib/igt_fb: Add copy_fb function Alex Hung
2025-03-26 23:35 ` [PATCH V7 12/37] tests/kms_colorop: Add kms_colorop tests Alex Hung
2025-04-03 9:57 ` Sharma, Swati2
2025-03-26 23:35 ` [PATCH V7 13/37] lib/igt_kms: Add support for DATA colorop property Alex Hung
2025-03-26 23:35 ` [PATCH V7 14/37] lib/igt_color: Add support for 3x4 matrices Alex Hung
2025-03-26 23:35 ` [PATCH V7 15/37] tests/kms_colorop: Add 3x4 CTM tests Alex Hung
2025-03-26 23:35 ` [PATCH V7 16/37] tests/kms_colorop: Add bypass test Alex Hung
2025-03-26 23:35 ` [PATCH V7 17/37] tests/kms_colorop: Parametrize the buffer format Alex Hung
2025-03-26 23:35 ` [PATCH V7 18/37] tests/kms_colorop: Add 10bpc test and skip if format not supported Alex Hung
2025-03-26 23:35 ` [PATCH V7 19/37] tests/kms_colorop: Skip if writeback does not support fourcc Alex Hung
2025-03-26 23:35 ` [PATCH V7 20/37] lib/igt_fb: Allow any non-planar format for igt_copy_fb Alex Hung
2025-03-26 23:35 ` [PATCH V7 21/37] kms/colorop: Do proper setup and cleanup Alex Hung
2025-03-26 23:35 ` Alex Hung [this message]
2025-03-26 23:35 ` [PATCH V7 23/37] tests/kms_colorop: Set wide [13, 13] bracket for comparison on amdgpu Alex Hung
2025-03-26 23:35 ` [PATCH V7 24/37] lib/igt_color: Add PQ variants for 0-1 and 0-125 range Alex Hung
2025-03-26 23:35 ` [PATCH V7 25/37] tests/kms_colorop: Add tests for PQ variants Alex Hung
2025-03-26 23:35 ` [PATCH V7 26/37] lib/igt_kms: increase MAX_NUM_COLOROPS to 128 Alex Hung
2025-03-26 23:35 ` [PATCH V7 27/37] tests/kms_colorop: Add a sRGB test for EOTF -> Inverse EOTF -> EOTF Alex Hung
2025-03-26 23:36 ` [PATCH V7 28/37] lib/igt_color: add BT2020/BT709 transfer functions Alex Hung
2025-03-26 23:36 ` [PATCH V7 29/37] tests/kms_colorop: Add tests for BT2020/BT709 TFs Alex Hung
2025-03-26 23:36 ` [PATCH V7 30/37] lib/igt_color: Add 1D LUT color transformation support Alex Hung
2025-03-26 23:36 ` [PATCH V7 31/37] test/kms_colorop: Add tests that exercise the 1D LUT colorops Alex Hung
2025-03-26 23:36 ` [PATCH V7 32/37] tests/kms_colorop: Add multiplier tests Alex Hung
2025-03-26 23:36 ` [PATCH V7 33/37] lib/igt_color: Point license header at skia license Alex Hung
2025-03-26 23:36 ` [PATCH V7 34/37] scripts/convert_3dlut.py Convert a 3D LUT to igt_3dlut_t array for 3D LUT API Alex Hung
2025-03-26 23:36 ` [PATCH V7 35/37] tests/kms_colorop: Add a 3D LUT subtest Alex Hung
2025-03-26 23:36 ` [PATCH V7 36/37] drm-uapi: Update kernel doc for drm_colorop_type Alex Hung
2025-03-26 23:36 ` [PATCH V7 37/37] drm-uapi: Sync up definition with kernel colorop implementation Alex Hung
2025-03-27 0:48 ` ✓ Xe.CI.BAT: success for IGT tests for the KMS Color Pipeline API (rev7) Patchwork
2025-03-27 3:13 ` ✓ i915.CI.BAT: " Patchwork
2025-03-27 5:26 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-27 13:49 ` ✗ Xe.CI.Full: " Patchwork
2025-03-28 12:00 ` Patchwork
2025-04-03 10:12 ` [PATCH V7 00/37] IGT tests for the KMS Color Pipeline API Sharma, Swati2
2025-04-07 23:26 ` Alex Hung
2025-04-06 16:26 ` ✗ Xe.CI.Full: failure for IGT tests for the KMS Color Pipeline API (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326233609.2980110-23-alex.hung@amd.com \
--to=alex.hung@amd.com \
--cc=harry.wentland@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox