From: replace_with Sobin Thomas <sobin.thomas@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kamil.konieczny@intel.com, dominik.karol.piatkowski@intel.com
Subject: [PATCH i-g-t 1/1] tests/intel/xe_sysfs_scheduler: Add invalid string test for engine sysfs properties
Date: Mon, 31 Mar 2025 14:27:49 +0000 [thread overview]
Message-ID: <20250331142749.1821941-2-sobin.thomas@intel.com> (raw)
In-Reply-To: <20250331142749.1821941-1-sobin.thomas@intel.com>
From: Sobin Thomas <sobin.thomas@intel.com>
This test validates that invalid string inputs are correctly rejected
by engine sysfs write. It ensures that the property values remain
unchanged when invalid inputs are provided.
v2: Added error check for return values for igt_sysfs_scanf and
igt_sysfs_printf. Removed the changes for fault injection in
tests/intel/xe_fault_injection.c
v1: Initial changes for checking error string.
Signed-off-by: Sobin Thomas <sobin.thomas@intel.com>
---
tests/intel/xe_sysfs_scheduler.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/tests/intel/xe_sysfs_scheduler.c b/tests/intel/xe_sysfs_scheduler.c
index 4fc764f82..594c51d44 100644
--- a/tests/intel/xe_sysfs_scheduler.c
+++ b/tests/intel/xe_sysfs_scheduler.c
@@ -10,6 +10,11 @@
* Sub-category: SysMan tests
* Functionality: scheduler control interface
*
+ * SUBTEST: %s-invalid-string
+ * Description: Test to check if %s arg[1] schedule parameter checks for
+ * min max values.
+ * Test category: Negative string test
+ *
* SUBTEST: %s-invalid
* Description: Test to check if %s arg[1] schedule parameter rejects any
* unrepresentable intervals.
@@ -121,6 +126,29 @@ static void test_min_max(int xe, int engine, const char **property,
igt_assert_eq(set, default_max);
}
+static void test_invalid_string(int xe, int engine, const char **property,
+ uint16_t class, int gt)
+{
+ unsigned int saved, set;
+ char invalid_input[] = "999abc";
+
+ for (int i = 0; i < 3; i++) {
+ igt_assert(igt_sysfs_scanf(engine, property[i], "%u", &saved) == 1);
+ igt_info("Initial %s: %u\n", property[i], saved);
+ if (igt_sysfs_printf(engine, property[i], "%s", invalid_input) > 0) {
+ igt_critical("invalid value %s can be set to property %s\n",
+ invalid_input, property[i]);
+ continue;
+ }
+
+ igt_assert(igt_sysfs_scanf(engine, property[i], "%u", &set) == 0);
+
+ //Check if the values are unchanged.
+ igt_assert_eq(set, saved);
+ }
+}
+
+
#define MAX_GTS 8
igt_main
{
@@ -130,6 +158,7 @@ igt_main
} tests[] = {
{ "invalid", test_invalid },
{ "min-max", test_min_max },
+ { "invalid-string", test_invalid_string },
{ }
};
--
2.34.1
next prev parent reply other threads:[~2025-03-31 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 14:27 [PATCH v2 i-g-t 1/1] tests/intel/xe_sysfs_scheduler: Add invalid string test for engine sysfs properties replace_with Sobin Thomas
2025-03-31 14:27 ` replace_with Sobin Thomas [this message]
2025-04-01 9:44 ` [PATCH " Piatkowski, Dominik Karol
2025-04-01 13:21 ` Kamil Konieczny
2025-03-31 19:15 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2025-03-31 19:17 ` ✓ i915.CI.BAT: " Patchwork
2025-03-31 21:41 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-31 21:54 ` ✓ i915.CI.Full: success " Patchwork
2025-04-06 21:46 ` ✗ Xe.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-04-08 4:18 [PATCH v4 i-g-t 0/1] " Sobin Thomas
2025-04-08 4:18 ` [PATCH i-g-t 1/1] " Sobin Thomas
2025-04-08 9:32 ` Piatkowski, Dominik Karol
2025-04-10 9:17 [PATCH v6 i-g-t 0/1] " Sobin Thomas
2025-04-10 9:17 ` [PATCH i-g-t 1/1] " Sobin Thomas
2025-04-11 12:20 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331142749.1821941-2-sobin.thomas@intel.com \
--to=sobin.thomas@intel.com \
--cc=dominik.karol.piatkowski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox