From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC9B8C36014 for ; Tue, 1 Apr 2025 09:07:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8540810E527; Tue, 1 Apr 2025 09:07:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jtWPJLsY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA6FB10E527 for ; Tue, 1 Apr 2025 09:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743498470; x=1775034470; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mpnK+DicnwsLO/GavGziGEhC6QyD21ihWn1Ir3z3jOI=; b=jtWPJLsYLAHf0q7Af+rXsA7HEq0Ak3pUavoQpm2SoMJLLNCtV6hVkGoO YU71/l4dp+qZsRB/PfLd93aHlholqBGzGCVHEKwgD2hEHKsAW0f4dZlNX I1iejzvtDrdl/2iCtQWJvTQoB/qf7zPOgyJ0D++kc3xBL0av4VxCACnOw XiGDMtzyxasjDyKs0LXXph8rvsbJ1fbJ22/yvZbWnpUiTIFE1OzS7Nlsj O3SAARqUv+JhPZzSEcZcFrJnO5zpRESySsMBta5jmngxKmVX/+JxP+fEj BB6NKNTahZ7vY1iMv1HQ+LTAxWbcWPRT+NKAElz+prqD7l2W0yW0iFpJQ g==; X-CSE-ConnectionGUID: BDWF5k1VTLWRo9wUJSZZUA== X-CSE-MsgGUID: bP8Xb3jiR96hEO/dMUG0zQ== X-IronPort-AV: E=McAfee;i="6700,10204,11390"; a="62345870" X-IronPort-AV: E=Sophos;i="6.14,293,1736841600"; d="scan'208";a="62345870" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 02:07:50 -0700 X-CSE-ConnectionGUID: oI3t+nWzTTKY3BBWjEnw8w== X-CSE-MsgGUID: ufjmhDcDQuesCL+TmiJWpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,292,1736841600"; d="scan'208";a="131539962" Received: from artdev273.igk.intel.com ([172.28.176.8]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 02:07:48 -0700 From: Jan Sokolowski To: igt-dev@lists.freedesktop.org Cc: Dominik Grzegorzek , Jan Sokolowski Subject: [PATCH i-g-t v2 2/2] tests/xe_eudebug_online: Implement faultable variations of some testcases Date: Tue, 1 Apr 2025 09:06:51 +0000 Message-Id: <20250401090651.298768-3-jan.sokolowski@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250401090651.298768-1-jan.sokolowski@intel.com> References: <20250401090651.298768-1-jan.sokolowski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" From: Dominik Grzegorzek Implement fault variation of tests, which are accessing the memory via debugfd, by creating a vm in FAULT_MODE. Signed-off-by: Dominik Grzegorzek Signed-off-by: Jan Sokolowski --- tests/intel/xe_eudebug_online.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c index 84ba748c1..a29e5a086 100644 --- a/tests/intel/xe_eudebug_online.c +++ b/tests/intel/xe_eudebug_online.c @@ -38,6 +38,7 @@ #define TARGET_IN_VRAM (1 << 13) #define SHADER_PAGEFAULT_READ (1 << 14) #define SHADER_PAGEFAULT_WRITE (1 << 15) +#define FAULTABLE_VM (1 << 16) #define TRIGGER_UFENCE_SET_BREAKPOINT (1 << 24) #define TRIGGER_RESUME_SINGLE_WALK (1 << 25) #define TRIGGER_RESUME_PARALLEL_WALK (1 << 26) @@ -1098,7 +1099,8 @@ static void run_online_client(struct xe_eudebug_client *c) 2 * sizeof(**metadata), metadata[1]); vm_flags = DRM_XE_VM_CREATE_FLAG_LR_MODE; - vm_flags |= c->flags & SHADER_PAGEFAULT ? DRM_XE_VM_CREATE_FLAG_FAULT_MODE : 0; + vm_flags |= c->flags & (SHADER_PAGEFAULT | FAULTABLE_VM) ? + DRM_XE_VM_CREATE_FLAG_FAULT_MODE : 0; create.vm_id = xe_eudebug_client_vm_create(c, fd, vm_flags, 0); @@ -1481,6 +1483,12 @@ static void test_basic_online(int fd, struct drm_xe_engine_class_instance *hwe, * SUBTEST: set-breakpoint * Description: * Checks for attention after setting a dynamic breakpoint in the ufence event. + * + * SUBTEST: set-breakpoint-faultable + * Sub-category: EUdebug online + * Functionality: dynamic breakpoint with FAULTABLE_VM + * Description: + * Faultable variation of test set-breakpoint. */ static void test_set_breakpoint_online(int fd, struct drm_xe_engine_class_instance *hwe, int flags) @@ -1488,6 +1496,8 @@ static void test_set_breakpoint_online(int fd, struct drm_xe_engine_class_instan struct xe_eudebug_session *s; struct online_debug_data *data; + igt_require(!(flags & FAULTABLE_VM) || !xe_supports_faults(fd)); + data = online_debug_data_create(hwe); s = xe_eudebug_session_create(fd, run_online_client, flags, data); xe_eudebug_debugger_add_trigger(s->debugger, DRM_XE_EUDEBUG_EVENT_OPEN, @@ -1739,6 +1749,12 @@ static void test_reset_with_attention_online(int fd, struct drm_xe_engine_class_ * interrupts all threads, once attention event come it sets breakpoint on * the very next instruction and resumes stopped threads back. It expects * that every thread hits the breakpoint. + * + * SUBTEST: interrupt-all-set-breakpoint-faultable + * Sub-category: EUdebug online + * Functionality: dynamic breakpoint with FAULTABLE_VM + * Description: + * Faultable variation of test interrupt-all-set-breakpoint. */ static void test_interrupt_all(int fd, struct drm_xe_engine_class_instance *hwe, int flags) { @@ -1746,6 +1762,8 @@ static void test_interrupt_all(int fd, struct drm_xe_engine_class_instance *hwe, struct online_debug_data *data; uint32_t val; + igt_require(!(flags & FAULTABLE_VM) || !xe_supports_faults(fd)); + data = online_debug_data_create(hwe); s = xe_eudebug_session_create(fd, run_online_client, flags, data); @@ -2521,6 +2539,9 @@ igt_main test_gt_render_or_compute("set-breakpoint", fd, hwe) test_set_breakpoint_online(fd, hwe, SHADER_NOP | TRIGGER_UFENCE_SET_BREAKPOINT); + test_gt_render_or_compute("set-breakpoint-faultable", fd, hwe) + test_set_breakpoint_online(fd, hwe, SHADER_NOP | TRIGGER_UFENCE_SET_BREAKPOINT | FAULTABLE_VM); + test_gt_render_or_compute("set-breakpoint-sigint-debugger", fd, hwe) test_set_breakpoint_online_sigint_debugger(fd, hwe, SHADER_NOP | TRIGGER_UFENCE_SET_BREAKPOINT); @@ -2563,6 +2584,9 @@ igt_main test_gt_render_or_compute("interrupt-all-set-breakpoint", fd, hwe) test_interrupt_all(fd, hwe, SHADER_LOOP | TRIGGER_RESUME_SET_BP); + test_gt_render_or_compute("interrupt-all-set-breakpoint-faultable", fd, hwe) + test_interrupt_all(fd, hwe, SHADER_LOOP | TRIGGER_RESUME_SET_BP | FAULTABLE_VM); + test_gt_render_or_compute("tdctl-parameters", fd, hwe) test_tdctl_parameters(fd, hwe, SHADER_LOOP); -- 2.34.1