Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: igt-dev@lists.freedesktop.org, Jeevan B <jeevan.b@intel.com>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: kernel-dev@igalia.com, "Vitaly Prosyak" <vitaly.prosyak@amd.com>,
	"Alex Hung" <alex.hung@amd.com>, "Melissa Wen" <mwen@igalia.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v5 2/4] tests/kms_async_flips: Check for atomic async flip cap
Date: Tue,  1 Apr 2025 23:29:20 -0300	[thread overview]
Message-ID: <20250402022922.210495-3-andrealmeid@igalia.com> (raw)
In-Reply-To: <20250402022922.210495-1-andrealmeid@igalia.com>

If a driver doesn't support doing an async flip through the atomic uAPI,
the atomic tests fails. Instead of failing, create a function that
checks for this capability and skip the test if is unsupported.

Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
 tests/kms_async_flips.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index da426f753..d2a1f60f9 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -207,6 +207,12 @@ static void require_monotonic_timestamp(int fd)
 		      "Monotonic timestamps not supported\n");
 }
 
+static void require_atomic_async_cap(data_t *data)
+{
+	igt_require_f(igt_has_drm_cap(data->drm_fd, DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP),
+		      "Atomic flip async flip not supported\n");
+}
+
 static void test_init(data_t *data)
 {
 	drmModeModeInfo *mode;
@@ -687,6 +693,9 @@ static void run_test(data_t *data, void (*test)(data_t *))
 {
 	igt_display_t *display = &data->display;
 
+	if (data->atomic_path)
+		require_atomic_async_cap(data);
+
 	for_each_pipe_with_valid_output(display, data->pipe, data->output) {
 		igt_display_reset(display);
 
@@ -712,6 +721,9 @@ static void run_test(data_t *data, void (*test)(data_t *))
 
 static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
 {
+	if (data->atomic_path)
+		require_atomic_async_cap(data);
+
 	for_each_pipe_with_valid_output(&data->display, data->pipe, data->output) {
 		test_init(data);
 
-- 
2.49.0


  parent reply	other threads:[~2025-04-02  2:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02  2:29 [PATCH v5 0/4] tests/kms_async_flips: Create subtest for overlay planes André Almeida
2025-04-02  2:29 ` [PATCH v5 1/4] lib/ioctl_wrappers: let the caller handle capability check result André Almeida
2025-04-03 16:59   ` Kamil Konieczny
2025-04-02  2:29 ` André Almeida [this message]
2025-04-03 15:27   ` [PATCH v5 2/4] tests/kms_async_flips: Check for atomic async flip cap Melissa Wen
2025-04-03 16:17     ` Melissa Wen
2025-04-02  2:29 ` [PATCH v5 3/4] kms_async_flips: Refactor data options André Almeida
2025-04-03 15:28   ` Melissa Wen
2025-04-02  2:29 ` [PATCH v5 4/4] tests/kms_async_flips: Create subtest for overlay planes André Almeida
2025-04-03 15:34   ` Melissa Wen
2025-04-02  3:16 ` ✓ i915.CI.BAT: success for tests/kms_async_flips: Create subtest for overlay planes (rev6) Patchwork
2025-04-02  3:23 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-02  6:07 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-02  6:44 ` ✗ Xe.CI.Full: " Patchwork
2025-04-06 23:57 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250402022922.210495-3-andrealmeid@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=alex.hung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=kernel-dev@igalia.com \
    --cc=mwen@igalia.com \
    --cc=siqueira@igalia.com \
    --cc=vitaly.prosyak@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox