From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CE68C3601E for ; Fri, 4 Apr 2025 12:31:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30F1310E0BF; Fri, 4 Apr 2025 12:31:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="lCJ0IhWE"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7349F10E0BF for ; Fri, 4 Apr 2025 12:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743769916; x=1775305916; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xM70ND132LQvpnbKhQsucxM4IQJM/abVapNsz+JBo5k=; b=lCJ0IhWEyw+ISb6Ujf1Lwb9R6A/tOf6JClrgP3YFwRcu55RSKED3J0Dj dHLF7pBbDNgUe5MSGifEiHnh2bWg7SV5u1ei/4LkCx00m6hseAzMckF37 X6C7HwrMLmjBULYVqgG2n/zMAR3kkaoh5ozdQBqhhqmOAa880rMHhWcUN 55bC3MXAypzHlqmNviSBT7SyQ9Ku6P0MgpFL7LqwwSJ/KZ+nLHtZJEDUl C/g4wdTL5nzXepfSqL13g+fwK9fVuHTa+8ytrr/j3Dw9x3taJ7L9dCFFg +MeEGfEzLfs1SLlwVZooY9qhZ5fQmtnXcNZWIhx7VI8eZfpTrfD8jQe3t Q==; X-CSE-ConnectionGUID: /5WSQAV+Re+eMfT1ugFhqg== X-CSE-MsgGUID: 906ifQp3R/Gm0B/kNeE0Gw== X-IronPort-AV: E=McAfee;i="6700,10204,11393"; a="45348185" X-IronPort-AV: E=Sophos;i="6.15,188,1739865600"; d="scan'208";a="45348185" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2025 05:31:56 -0700 X-CSE-ConnectionGUID: EJG48s9BSZS/r287Au5YPg== X-CSE-MsgGUID: EZDxqoukRraTCx/F5tcigw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,188,1739865600"; d="scan'208";a="128207046" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.53]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2025 05:31:54 -0700 From: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= To: igt-dev@lists.freedesktop.org Cc: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= , Francois Dugast , Priyanka Dandamudi Subject: [PATCH i-g-t v2 2/5] lib/intel_compute_square_kernels: use stoppable loop for LNL/BMG Date: Fri, 4 Apr 2025 14:31:37 +0200 Message-Id: <20250404123140.260143-3-zbigniew.kempczynski@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404123140.260143-1-zbigniew.kempczynski@intel.com> References: <20250404123140.260143-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Instead of tweaked loop start using loop in which we may stop it via simple cpu write to memory. Currently this is possible for LNL and BMG platforms. Signed-off-by: Zbigniew Kempczyński Cc: Francois Dugast Cc: Priyanka Dandamudi --- lib/intel_compute_square_kernels.c | 41 ++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/lib/intel_compute_square_kernels.c b/lib/intel_compute_square_kernels.c index 76c48c4511..626dbc4cec 100644 --- a/lib/intel_compute_square_kernels.c +++ b/lib/intel_compute_square_kernels.c @@ -3844,6 +3844,43 @@ static const unsigned char xe2lpg_kernel_inc_bin[] = { 0x00, 0x00, 0x00, 0x00 }; +/* + * Opencl code is in opencl/loop.cl + * + * To work properly it requires to use uncached reads, so ocloc has to + * be called with: -options " -igc_opts 'LscLoadCacheControlOverride=1' arg +*/ + +static const unsigned char xe2lpg_kernel_loop_bin[] = { + 0x65, 0x00, 0x00, 0x80, 0x20, 0x82, 0x05, 0x7f, 0x04, 0x00, 0x00, 0x02, + 0xc0, 0xff, 0xff, 0xff, 0x40, 0x19, 0x00, 0x80, 0x20, 0x82, 0x05, 0x7f, + 0x04, 0x7f, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x31, 0x20, 0x01, 0x80, + 0x00, 0x00, 0x0c, 0x02, 0x8f, 0x7f, 0x00, 0xfa, 0x03, 0x00, 0x70, 0xf6, + 0x61, 0x00, 0x10, 0x2c, 0x01, 0x00, 0x10, 0x00, 0x66, 0x09, 0x00, 0x80, + 0x20, 0x82, 0x01, 0x80, 0x00, 0x80, 0x00, 0x02, 0xc0, 0x04, 0x00, 0x40, + 0x01, 0x09, 0x8c, 0x3c, 0x00, 0x00, 0x10, 0x00, 0x61, 0x80, 0x84, 0xa4, + 0x04, 0x02, 0x10, 0x00, 0x31, 0x21, 0x01, 0x80, 0x00, 0x00, 0x0c, 0x03, + 0x0c, 0x04, 0x00, 0xfb, 0x00, 0x00, 0xa0, 0x00, 0x70, 0x81, 0x14, 0x80, + 0x60, 0x86, 0x01, 0x00, 0x04, 0x03, 0x00, 0x16, 0x34, 0x12, 0x34, 0x12, + 0x20, 0x00, 0x00, 0x94, 0x00, 0x40, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0xd8, 0xff, 0xff, 0xff, 0x61, 0x00, 0x10, 0x28, 0x7f, 0x01, 0x10, 0x00, + 0x31, 0x22, 0x02, 0x80, 0x04, 0x00, 0x00, 0x00, 0x0c, 0x7f, 0x20, 0x30, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 +}; + unsigned char xelpg_kernel_square_bin[] = { 0x61, 0x00, 0x03, 0x80, 0x20, 0x42, 0x05, 0x7f, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x65, 0x00, 0x00, 0x80, 0x20, 0x82, 0x45, 0x7f, @@ -6629,6 +6666,8 @@ const struct intel_compute_kernels intel_compute_square_kernels[] = { .long_kernel_size = sizeof(xe2lpg_kernel_inc_bin), .sip_kernel = xe2lpg_kernel_sip_bin, .sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin), + .loop_kernel = xe2lpg_kernel_loop_bin, + .loop_kernel_size = sizeof(xe2lpg_kernel_loop_bin), }, { .ip_ver = IP_VER(20, 04), @@ -6638,6 +6677,8 @@ const struct intel_compute_kernels intel_compute_square_kernels[] = { .long_kernel_size = sizeof(xe2lpg_kernel_inc_bin), .sip_kernel = xe2lpg_kernel_sip_bin, .sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin), + .loop_kernel = xe2lpg_kernel_loop_bin, + .loop_kernel_size = sizeof(xe2lpg_kernel_loop_bin), }, { .ip_ver = IP_VER(30, 00), -- 2.34.1