Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Francois Dugast" <francois.dugast@intel.com>,
	"Priyanka Dandamudi" <priyanka.dandamudi@intel.com>
Subject: [PATCH i-g-t v2 4/5] tests/xe_compute_preempt: adjust number of children according to ram size
Date: Fri,  4 Apr 2025 14:31:39 +0200	[thread overview]
Message-ID: <20250404123140.260143-5-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20250404123140.260143-1-zbigniew.kempczynski@intel.com>

Setting arbitrary number or children is prone to oom scenario and
getting test to be killed.

Single job with sip turned on takes ~100MB for Xe2 tasks so adjust
number of children to consume ~50% ram.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/intel/xe_compute_preempt.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/tests/intel/xe_compute_preempt.c b/tests/intel/xe_compute_preempt.c
index 876e538237..f07e87d4c4 100644
--- a/tests/intel/xe_compute_preempt.c
+++ b/tests/intel/xe_compute_preempt.c
@@ -40,13 +40,18 @@ test_compute_preempt(int fd, struct drm_xe_engine_class_instance *hwe, bool thre
 	igt_require_f(run_intel_compute_kernel_preempt(fd, hwe, threadgroup_preemption), "GPU not supported\n");
 }
 
+#define CONTEXT_MB 100
+
 igt_main
 {
 	int xe;
 	struct drm_xe_engine_class_instance *hwe;
+	uint64_t ram_mb;
 
-	igt_fixture
+	igt_fixture {
 		xe = drm_open_driver(DRIVER_XE);
+		ram_mb = igt_get_avail_ram_mb();
+	}
 
 	igt_subtest_with_dynamic("compute-preempt") {
 		xe_for_each_engine(xe, hwe) {
@@ -64,13 +69,16 @@ igt_main
 				continue;
 
 			igt_dynamic_f("engine-%s", xe_engine_class_string(hwe->engine_class)) {
-				uint16_t dev_id = intel_get_drm_devid(xe);
 				int child_count;
 
-				if (IS_PANTHERLAKE(dev_id))
-					child_count = 50;
-				else
-					child_count = 100;
+				/*
+				 * Get half of ram / 2, then divide by
+				 * CONTEXT_MB * 2 (long and short) job
+				 */
+				child_count = ram_mb / 2 / CONTEXT_MB / 2;
+
+				igt_debug("RAM: %zd, child count: %d\n",
+					  ram_mb, child_count);
 
 				test_compute_preempt(xe, hwe, false);
 				igt_fork(child, child_count)
-- 
2.34.1


  parent reply	other threads:[~2025-04-04 12:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 12:31 [PATCH i-g-t v2 0/5] Replace loop in WMTP tests Zbigniew Kempczyński
2025-04-04 12:31 ` [PATCH i-g-t v2 1/5] lib/intel_compute: add support for stoppable loop Zbigniew Kempczyński
2025-04-04 13:18   ` Francois Dugast
2025-04-04 12:31 ` [PATCH i-g-t v2 2/5] lib/intel_compute_square_kernels: use stoppable loop for LNL/BMG Zbigniew Kempczyński
2025-04-04 12:31 ` [PATCH i-g-t v2 3/5] lib/intel_compute_square_kernel: add loop shader binary for PTL Zbigniew Kempczyński
2025-04-04 12:31 ` Zbigniew Kempczyński [this message]
2025-04-07  8:49   ` [PATCH i-g-t v2 4/5] tests/xe_compute_preempt: adjust number of children according to ram size Dandamudi, Priyanka
2025-04-07 19:01     ` Zbigniew Kempczyński
2025-04-08 12:12       ` Kamil Konieczny
2025-04-09  8:47     ` Dandamudi, Priyanka
2025-04-04 12:31 ` [PATCH i-g-t v2 5/5] tests/xe_compute_preempt: consume all ram for wmtp Zbigniew Kempczyński
2025-04-04 14:34 ` ✓ Xe.CI.BAT: success for Replace loop in WMTP tests (rev2) Patchwork
2025-04-04 14:55 ` ✓ i915.CI.BAT: " Patchwork
2025-04-04 17:35 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250404123140.260143-5-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=priyanka.dandamudi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox