From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Riana Tauro <riana.tauro@intel.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>
Subject: [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test
Date: Wed, 9 Apr 2025 18:33:14 -0700 [thread overview]
Message-ID: <20250410013314.613109-3-vinay.belgaumkar@intel.com> (raw)
In-Reply-To: <20250410013314.613109-1-vinay.belgaumkar@intel.com>
Add a basic test that uses PMU to read GT actual and requested
frequencies while running a workload.
v2: Rebase and comments (Riana)
v3: Address review comments (Kamil and Riana)
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
tests/intel/xe_pmu.c | 147 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 147 insertions(+)
diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
index 175bbf374..589c7cbde 100644
--- a/tests/intel/xe_pmu.c
+++ b/tests/intel/xe_pmu.c
@@ -376,6 +376,94 @@ static void test_gt_c6_idle(int xe, unsigned int gt)
close(pmu_fd);
}
+/**
+ * SUBTEST: gt-frequency
+ * Description: Validate we can collect accurate frequency PMU stats
+ * while running a workload.
+ */
+static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci)
+{
+ struct xe_cork *cork = NULL;
+ uint64_t end[2], start[2];
+ unsigned long config_rq_freq, config_act_freq;
+ double min[2], max[2];
+ uint32_t gt = eci->gt_id;
+ uint32_t orig_min = xe_gt_get_freq(fd, eci->gt_id, "min");
+ uint32_t orig_max = xe_gt_get_freq(fd, eci->gt_id, "max");
+ uint32_t vm;
+ int pmu_fd[2];
+
+ config_rq_freq = get_event_config(gt, NULL, "gt-requested-frequency");
+ pmu_fd[0] = open_group(fd, config_rq_freq, -1);
+
+ config_act_freq = get_event_config(gt, NULL, "gt-actual-frequency");
+ pmu_fd[1] = open_group(fd, config_act_freq, pmu_fd[0]);
+
+ vm = xe_vm_create(fd, 0, 0);
+
+ cork = xe_cork_create_opts(fd, eci, vm, 1, 1);
+ xe_cork_sync_start(fd, cork);
+
+ /*
+ * Set GPU to min frequency and read PMU counters.
+ */
+ igt_assert(xe_gt_set_freq(fd, gt, "max", orig_min) > 0);
+ igt_assert(xe_gt_get_freq(fd, gt, "max") == orig_min);
+
+ pmu_read_multi(pmu_fd[0], 2, start);
+ usleep(SLEEP_DURATION * USEC_PER_SEC);
+ pmu_read_multi(pmu_fd[0], 2, end);
+
+ min[0] = (end[0] - start[0]);
+ min[1] = (end[1] - start[1]);
+
+ /*
+ * Set GPU to max frequency and read PMU counters.
+ */
+ igt_assert(xe_gt_set_freq(fd, gt, "max", orig_max) > 0);
+ igt_assert(xe_gt_get_freq(fd, gt, "max") == orig_max);
+ igt_assert(xe_gt_set_freq(fd, gt, "min", orig_max) > 0);
+ igt_assert(xe_gt_get_freq(fd, gt, "min") == orig_max);
+
+ pmu_read_multi(pmu_fd[0], 2, start);
+ usleep(SLEEP_DURATION * USEC_PER_SEC);
+ pmu_read_multi(pmu_fd[0], 2, end);
+
+ max[0] = (end[0] - start[0]);
+ max[1] = (end[1] - start[1]);
+
+ xe_cork_sync_end(fd, cork);
+
+ /*
+ * Restore min/max.
+ */
+ igt_assert(xe_gt_set_freq(fd, gt, "min", orig_min) > 0);
+ igt_assert(xe_gt_get_freq(fd, gt, "min") == orig_min);
+
+ igt_info("Minimum frequency: requested %.1f, actual %.1f\n",
+ min[0], min[1]);
+ igt_info("Maximum frequency: requested %.1f, actual %.1f\n",
+ max[0], max[1]);
+
+ close(pmu_fd[0]);
+ close(pmu_fd[1]);
+
+ if (cork)
+ xe_cork_destroy(fd, cork);
+
+ xe_vm_destroy(fd, vm);
+
+ close(pmu_fd[0]);
+ close(pmu_fd[1]);
+
+ assert_within_epsilon(min[0], orig_min, tolerance);
+ /*
+ * On thermally throttled devices we cannot be sure maximum frequency
+ * can be reached so use larger tolerance downwards.
+ */
+ assert_within_epsilon_up_down(max[0], orig_max, tolerance, 0.15f);
+}
+
static unsigned int enable_and_provision_vfs(int fd)
{
unsigned int gt, num_vfs;
@@ -427,6 +515,35 @@ static void disable_vfs(int fd)
"Failed to restore sriov_drivers_autoprobe value\n");
}
+static void stash_gt_freq(int fd, uint32_t **stash_min, uint32_t **stash_max)
+{
+ int num_gts, gt;
+
+ num_gts = xe_number_gt(fd);
+
+ *stash_min = (uint32_t *) malloc(sizeof(uint32_t) * num_gts);
+ *stash_max = (uint32_t *) malloc(sizeof(uint32_t) * num_gts);
+
+ igt_skip_on(*stash_min == NULL || *stash_max == NULL);
+
+ xe_for_each_gt(fd, gt) {
+ *stash_min[gt] = xe_gt_get_freq(fd, gt, "min");
+ *stash_max[gt] = xe_gt_get_freq(fd, gt, "max");
+ }
+}
+
+static void restore_gt_freq(int fd, uint32_t *stash_min, uint32_t *stash_max)
+{
+ int gt;
+
+ xe_for_each_gt(fd, gt) {
+ xe_gt_set_freq(fd, gt, "max", stash_max[gt]);
+ xe_gt_set_freq(fd, gt, "min", stash_min[gt]);
+ }
+ free(stash_min);
+ free(stash_max);
+}
+
igt_main
{
int fd, gt;
@@ -482,6 +599,36 @@ igt_main
disable_vfs(fd);
}
+ igt_subtest_group {
+ bool has_freq0_node, needs_freq_restore = false;
+ uint32_t *stash_min, *stash_max;
+
+ igt_fixture {
+ has_freq0_node = xe_sysfs_gt_has_node(fd, 0, "freq0");
+ }
+
+ igt_describe("Validate PMU GT freq measured is within the tolerance");
+ igt_subtest_with_dynamic("gt-frequency") {
+ igt_skip_on(!has_freq0_node);
+ stash_gt_freq(fd, &stash_min, &stash_max);
+ needs_freq_restore = true;
+ xe_for_each_gt(fd, gt) {
+ igt_dynamic_f("gt%u", gt)
+ xe_for_each_engine(fd, eci) {
+ if (gt == eci->gt_id) {
+ test_gt_frequency(fd, eci);
+ break;
+ }
+ }
+ }
+ }
+
+ igt_fixture {
+ if (needs_freq_restore)
+ restore_gt_freq(fd, stash_min, stash_max);
+ }
+ }
+
igt_fixture {
close(fd);
}
--
2.38.1
next prev parent reply other threads:[~2025-04-10 1:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 1:33 [PATCH i-g-t 0/2] Add PMU test for GT frequency Vinay Belgaumkar
2025-04-10 1:33 ` [PATCH i-g-t 1/2] lib/xe_gt: Move get/set GT freq utils to lib Vinay Belgaumkar
2025-04-10 18:24 ` Kamil Konieczny
2025-04-10 19:01 ` Kamil Konieczny
2025-04-10 1:33 ` Vinay Belgaumkar [this message]
2025-04-11 7:33 ` [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test Riana Tauro
2025-04-11 22:36 ` Belgaumkar, Vinay
2025-04-10 3:55 ` ✓ Xe.CI.BAT: success for Add PMU test for GT frequency (rev2) Patchwork
2025-04-10 4:47 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-10 8:51 ` ✓ i915.CI.BAT: success " Patchwork
2025-04-10 12:57 ` ✓ i915.CI.Full: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-04-11 22:45 [PATCH i-g-t 0/2] Add PMU test for GT frequency Vinay Belgaumkar
2025-04-11 22:46 ` [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test Vinay Belgaumkar
2025-04-07 23:44 [PATCH i-g-t 0/2] Add PMU test for GT frequency Vinay Belgaumkar
2025-04-07 23:44 ` [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test Vinay Belgaumkar
2025-04-09 9:58 ` Riana Tauro
2025-04-09 11:06 ` Kamil Konieczny
2025-04-10 1:26 ` Belgaumkar, Vinay
2025-04-10 1:31 ` Belgaumkar, Vinay
2025-04-02 1:39 [PATCH i-g-t 0/2] Add PMU tests for GT frequency Vinay Belgaumkar
2025-04-02 1:39 ` [PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test Vinay Belgaumkar
2025-04-03 10:39 ` Riana Tauro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410013314.613109-3-vinay.belgaumkar@intel.com \
--to=vinay.belgaumkar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox