From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84E01C369AB for ; Tue, 15 Apr 2025 10:14:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4349A10E700; Tue, 15 Apr 2025 10:14:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="chdRJ8NM"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA3F610E6FF for ; Tue, 15 Apr 2025 10:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744712095; x=1776248095; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fQsCKNI8teNCrKY+K9wUdDKEonDtLn27CchR4rlc3ZE=; b=chdRJ8NMPAtPoSHCKiDLof+6ZNQ5VWz0qODt3DfgpcxcvHkxXNTr6BaQ bIlONSn0pzGMPFvZC79/uZmmqIpeslfmS/p77mx8MxukO6TlR/rfBsP6I YTAYj0BMa8a5j/JYSpqYOXyR5wtc6a4/qa4YNEYrT1GoEg8bRZL48u6dz ACVmzYxtu98o1/K3xUK7xT/6ZHdfazS4IJi0LPg9hB5KObAa5yU3KxCcx dhZZ4tP2SFhTMGq6OhwM54CNTUQ9hltTOpop1O5mJ+nWgxHz0IspBGsSr GteVAcdeCckHjNTl+twFpXAqOjKySuXxPS88JSAXH+oG1FNCn191jgcs+ A==; X-CSE-ConnectionGUID: bd1m3vFSTsKEGITeoxy3rA== X-CSE-MsgGUID: m0eIYS7pSjSQaoZeAfz2hA== X-IronPort-AV: E=McAfee;i="6700,10204,11403"; a="50014756" X-IronPort-AV: E=Sophos;i="6.15,213,1739865600"; d="scan'208";a="50014756" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2025 03:14:55 -0700 X-CSE-ConnectionGUID: 6dOwmHCkR4GkLf5fIeDD0A== X-CSE-MsgGUID: vmaW+WSHT5SO1Hvd7mgtGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,213,1739865600"; d="scan'208";a="129933289" Received: from artdev273.igk.intel.com ([172.28.176.8]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2025 03:14:54 -0700 From: Jan Sokolowski To: igt-dev@lists.freedesktop.org Cc: Dominik Grzegorzek , Jan Sokolowski , Christoph Manszewski Subject: [PATCH i-g-t v3 2/2] tests/xe_eudebug_online: Implement faultable variations of some testcases Date: Tue, 15 Apr 2025 10:13:40 +0000 Message-Id: <20250415101340.13275-3-jan.sokolowski@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250415101340.13275-1-jan.sokolowski@intel.com> References: <20250415101340.13275-1-jan.sokolowski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" From: Dominik Grzegorzek Implement fault variation of tests, which are accessing the memory via debugfd, by creating a vm in FAULT_MODE. Signed-off-by: Dominik Grzegorzek Signed-off-by: Jan Sokolowski Reviewed-by: Christoph Manszewski --- tests/intel/xe_eudebug_online.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c index af90b9b70..1f72e3e44 100644 --- a/tests/intel/xe_eudebug_online.c +++ b/tests/intel/xe_eudebug_online.c @@ -38,6 +38,7 @@ #define TARGET_IN_VRAM (1 << 13) #define SHADER_PAGEFAULT_READ (1 << 14) #define SHADER_PAGEFAULT_WRITE (1 << 15) +#define FAULTABLE_VM (1 << 16) #define TRIGGER_UFENCE_SET_BREAKPOINT (1 << 24) #define TRIGGER_RESUME_SINGLE_WALK (1 << 25) #define TRIGGER_RESUME_PARALLEL_WALK (1 << 26) @@ -1100,7 +1101,8 @@ static void run_online_client(struct xe_eudebug_client *c) 2 * sizeof(**metadata), metadata[1]); vm_flags = DRM_XE_VM_CREATE_FLAG_LR_MODE; - vm_flags |= c->flags & SHADER_PAGEFAULT ? DRM_XE_VM_CREATE_FLAG_FAULT_MODE : 0; + vm_flags |= c->flags & (SHADER_PAGEFAULT | FAULTABLE_VM) ? + DRM_XE_VM_CREATE_FLAG_FAULT_MODE : 0; create.vm_id = xe_eudebug_client_vm_create(c, fd, vm_flags, 0); @@ -1487,6 +1489,11 @@ static void test_basic_online(int fd, struct drm_xe_engine_class_instance *hwe, * Functionality: dynamic breakpoint * Description: * Checks for attention after setting a dynamic breakpoint in the ufence event. + * + * SUBTEST: set-breakpoint-faultable + * Functionality: dynamic breakpoint with FAULTABLE_VM + * Description: + * Faultable variation of test set-breakpoint. */ static void test_set_breakpoint_online(int fd, struct drm_xe_engine_class_instance *hwe, int flags) @@ -1494,6 +1501,8 @@ static void test_set_breakpoint_online(int fd, struct drm_xe_engine_class_instan struct xe_eudebug_session *s; struct online_debug_data *data; + igt_require(!(flags & FAULTABLE_VM) || !xe_supports_faults(fd)); + data = online_debug_data_create(hwe); s = xe_eudebug_session_create(fd, run_online_client, flags, data); xe_eudebug_debugger_add_trigger(s->debugger, DRM_XE_EUDEBUG_EVENT_OPEN, @@ -1752,6 +1761,11 @@ static void test_reset_with_attention_online(int fd, struct drm_xe_engine_class_ * interrupts all threads, once attention event come it sets breakpoint on * the very next instruction and resumes stopped threads back. It expects * that every thread hits the breakpoint. + * + * SUBTEST: interrupt-all-set-breakpoint-faultable + * Functionality: dynamic breakpoint with FAULTABLE_VM + * Description: + * Faultable variation of test interrupt-all-set-breakpoint. */ static void test_interrupt_all(int fd, struct drm_xe_engine_class_instance *hwe, int flags) { @@ -1759,6 +1773,8 @@ static void test_interrupt_all(int fd, struct drm_xe_engine_class_instance *hwe, struct online_debug_data *data; uint32_t val; + igt_require(!(flags & FAULTABLE_VM) || !xe_supports_faults(fd)); + data = online_debug_data_create(hwe); s = xe_eudebug_session_create(fd, run_online_client, flags, data); @@ -2544,6 +2560,10 @@ igt_main test_gt_render_or_compute("set-breakpoint", fd, hwe) test_set_breakpoint_online(fd, hwe, SHADER_NOP | TRIGGER_UFENCE_SET_BREAKPOINT); + test_gt_render_or_compute("set-breakpoint-faultable", fd, hwe) + test_set_breakpoint_online(fd, hwe, + SHADER_NOP | TRIGGER_UFENCE_SET_BREAKPOINT | FAULTABLE_VM); + test_gt_render_or_compute("set-breakpoint-sigint-debugger", fd, hwe) test_set_breakpoint_online_sigint_debugger(fd, hwe, SHADER_NOP | TRIGGER_UFENCE_SET_BREAKPOINT); @@ -2586,6 +2606,9 @@ igt_main test_gt_render_or_compute("interrupt-all-set-breakpoint", fd, hwe) test_interrupt_all(fd, hwe, SHADER_LOOP | TRIGGER_RESUME_SET_BP); + test_gt_render_or_compute("interrupt-all-set-breakpoint-faultable", fd, hwe) + test_interrupt_all(fd, hwe, SHADER_LOOP | TRIGGER_RESUME_SET_BP | FAULTABLE_VM); + test_gt_render_or_compute("tdctl-parameters", fd, hwe) test_tdctl_parameters(fd, hwe, SHADER_LOOP); -- 2.34.1