From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B597C3ABC3 for ; Tue, 13 May 2025 18:59:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8EF110E5E8; Tue, 13 May 2025 18:59:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="U85XA1Cc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D12510E5E8 for ; Tue, 13 May 2025 18:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747162745; x=1778698745; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EpHYYlUcBTTsPAgQCybc7flFpDyn3ExxFBw4D1rDhgo=; b=U85XA1CctfTq+hnaslP4zQVHYAKzROBksZ+ZNfaArxerdxaxRlA2Bhgv Huq5XFlmAoHfD5amNvNg3TCtl2sCvdh9Ut7+HDu36qBBcD6gCAYTNU9ra NUwcxr/YS3pEIind1mvDH1uMUi40zwfnkhyHJqHnChLtsRjYBsfVCL0QN mrrEXrB38exarbKQiKtL/E6ti5ML8WkH4pc/jS09MbkKKRAq6UwHx32rj pujTMAyXnPV+ya3hnVXEkxmA76K/vmW3g8mJsaSaVa18B/WIEOsCuFxNT eZjKJAfazbU+HEW8384A/gmWKlfA6Ufh74wyVVudu7hE8NeKcXDDNTM9c g==; X-CSE-ConnectionGUID: tjxBP3z+Q3GZPpTH8bBkqA== X-CSE-MsgGUID: VHXZrnzKTm+Y42P9x+xuzA== X-IronPort-AV: E=McAfee;i="6700,10204,11432"; a="60428186" X-IronPort-AV: E=Sophos;i="6.15,286,1739865600"; d="scan'208";a="60428186" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2025 11:59:05 -0700 X-CSE-ConnectionGUID: hmOiKjHnQyWcpGXxXzZbdw== X-CSE-MsgGUID: n02FRC5dStm1E+/PBrUohw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,286,1739865600"; d="scan'208";a="137841030" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.60]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2025 11:59:04 -0700 From: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= To: igt-dev@lists.freedesktop.org Cc: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= , Francois Dugast Subject: [PATCH i-g-t 12/15] tests/xe_copy_basic: add subtest to verify mem-copy in pages Date: Tue, 13 May 2025 20:58:07 +0200 Message-ID: <20250513185811.897232-13-zbigniew.kempczynski@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250513185811.897232-1-zbigniew.kempczynski@intel.com> References: <20250513185811.897232-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Mem-copy in linear mode supports copying in 256B pages. Verify is it properly handled in intel_blt. Signed-off-by: Zbigniew Kempczyński Cc: Francois Dugast --- tests/intel/xe_copy_basic.c | 56 ++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 4 deletions(-) diff --git a/tests/intel/xe_copy_basic.c b/tests/intel/xe_copy_basic.c index 28c1878be9..7cd21131e0 100644 --- a/tests/intel/xe_copy_basic.c +++ b/tests/intel/xe_copy_basic.c @@ -48,6 +48,20 @@ struct rect { * @0xfffe: 0xfffe * @0x8fffe: 0x8fffe */ + +/** + * + * SUBTEST: mem-page-copy-%s + * Description: Test validates MEM_COPY command, it takes various + * parameters needed for the filling batch buffer for MEM_COPY command + * with size %arg[1]. + * Test category: functionality test + * + * arg[1]: + * @1: 1 + * @17: 17 + */ + static void mem_copy(int fd, uint32_t src_handle, uint32_t dst_handle, const intel_ctx_t *ctx, enum blt_memop_type type, enum blt_memop_mode mode, @@ -62,23 +76,45 @@ mem_copy(int fd, uint32_t src_handle, uint32_t dst_handle, const intel_ctx_t *ct uint8_t src_mocs = intel_get_uc_mocs_index(fd); uint8_t dst_mocs = src_mocs; uint32_t bb; - int result; + uint8_t *psrc, *pdst; + int result, i; bb = xe_bo_create(fd, 0, bb_size, region, 0); - blt_mem_copy_init(fd, &mem, MODE_BYTE, TYPE_LINEAR); + blt_mem_copy_init(fd, &mem, mode, type); blt_set_mem_object(&mem.src, src_handle, size, width, width, height, region, src_mocs, DEFAULT_PAT_INDEX, COMPRESSION_DISABLED); blt_set_mem_object(&mem.dst, dst_handle, size, width, width, height, region, dst_mocs, DEFAULT_PAT_INDEX, COMPRESSION_DISABLED); mem.src.ptr = xe_bo_map(fd, src_handle, size); mem.dst.ptr = xe_bo_map(fd, dst_handle, size); + psrc = (uint8_t *) mem.src.ptr; + pdst = (uint8_t *) mem.dst.ptr; + + srand(time(NULL)); + + /* Randomize whole src */ + for (i = 0; i < size; i++) + psrc[i] = rand(); blt_set_batch(&mem.bb, bb, bb_size, region); igt_assert(mem.src.width == mem.dst.width); blt_mem_copy(fd, ctx, NULL, ahnd, &mem); - result = memcmp(mem.src.ptr, mem.dst.ptr, mem.src.size); + + if (type == TYPE_LINEAR && mode == MODE_BYTE) { + result = memcmp(psrc, pdst, width); + + /* Rest of dst must contain 0 */ + for (i = width; i < size; i++) { + if (pdst[i] != 0) { + result = -1; + break; + } + } + } else { + result = memcmp(psrc, pdst, pitch << 8); + } intel_allocator_bind(ahnd, 0, 0); munmap(mem.src.ptr, size); @@ -86,7 +122,7 @@ mem_copy(int fd, uint32_t src_handle, uint32_t dst_handle, const intel_ctx_t *ct gem_close(fd, bb); put_ahnd(ahnd); - igt_assert_f(!result, "source and destination differ\n"); + igt_assert_f(!result, "destination doesn't contain valid data\n"); } /** @@ -176,6 +212,8 @@ igt_main { 0, 0x3fff, 1 }, { 0, 0xfffe, 1 }, { 0, 0x8fffe, 1 } }; + struct rect page[] = { { 0, 1, 1, MODE_PAGE }, + { 0, 17, 1, MODE_PAGE }}; igt_fixture { fd = drm_open_driver(DRIVER_XE); @@ -195,6 +233,16 @@ igt_main } } + for (int i = 0; i < ARRAY_SIZE(page); i++) { + igt_subtest_f("mem-page-copy-%u", page[i].width) { + igt_require(blt_has_mem_copy(fd)); + for_each_variation_r(regions, 1, set) { + region = igt_collection_get_value(regions, 0); + copy_test(fd, &page[i], MEM_COPY, region); + } + } + } + for (int i = 0; i < ARRAY_SIZE(linear); i++) { igt_subtest_f("mem-set-linear-0x%x", linear[i].width) { igt_require(blt_has_mem_set(fd)); -- 2.43.0