From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ramanaidu.naladala@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t] tests/kms_vrr: Pull Panel Replay check before setting up output
Date: Mon, 14 Jul 2025 20:25:56 +0530 [thread overview]
Message-ID: <20250714145556.213318-1-jeevan.b@intel.com> (raw)
Adding the Panel Replay support check later in the test was causing
an invalid skip, since the test disables PSR/PR in output_constraint().
Move the check earlier to ensure correct capability detection and avoid
unintended skips.
v2: Refactor TEST_LINK_OFF logic to avoid duplicate conditions.
Fixes: 7da0c57182cc ("tests/kms_vrr: Skip LOBF test if PR is not supported on sink")
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_vrr.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 9c2c4ac92..233143770 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -961,6 +961,12 @@ static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags
}
if (flags & TEST_LINK_OFF) {
+ if (!psr_sink_support(data->drm_fd,
+ data->debugfs_fd, PR_MODE, NULL)) {
+ igt_info("LOBF not supported\n");
+ return false;
+ }
+
if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))
psr_disable(data->drm_fd, data->debugfs_fd, NULL);
@@ -1051,11 +1057,6 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
continue;
}
- if (flags == TEST_LINK_OFF)
- igt_require_f(psr_sink_support(data->drm_fd,
- data->debugfs_fd, PR_MODE, output),
- "LOBF not supported");
-
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe), output->name)
test(data, pipe, output, flags);
--
2.43.0
next reply other threads:[~2025-07-14 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 14:55 Jeevan B [this message]
2025-07-14 15:31 ` [PATCH i-g-t] tests/kms_vrr: Pull Panel Replay check before setting up output Naladala, Ramanaidu
2025-07-14 21:16 ` ✓ i915.CI.BAT: success for tests/kms_vrr: Pull Panel Replay check before setting up output (rev3) Patchwork
2025-07-14 21:29 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-15 1:26 ` ✗ Xe.CI.Full: failure " Patchwork
2025-07-15 2:24 ` B, Jeevan
2025-07-15 1:57 ` ✗ i915.CI.Full: " Patchwork
2025-07-15 2:24 ` B, Jeevan
-- strict thread matches above, loose matches on Subject: below --
2025-07-14 14:52 [PATCH i-g-t] tests/kms_vrr: Pull Panel Replay check before setting up output Jeevan B
2025-07-14 10:28 Jeevan B
2025-07-14 11:37 ` Naladala, Ramanaidu
2025-07-14 14:11 ` B, Jeevan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714145556.213318-1-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox