From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
"Priyanka Dandamudi" <priyanka.dandamudi@intel.com>,
"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
"Christoph Manszewski" <christoph.manszewski@intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH v4 0/6] lib/xe/xe_query: implement few query helpers
Date: Thu, 20 Nov 2025 15:25:37 +0100 [thread overview]
Message-ID: <20251120-xe_query_helpers-v4-0-2ed6dc04dd94@intel.com> (raw)
This patchset adds following helpers to xe_query library:
- xe_hwconfig_get_u32 - to get single value from hwconfig,
similar helper exists in kernel,
- xe_query_device - encapsulates common code around DRM_IOCTL_XE_DEVICE_QUERY,
- xe_for_each_topology_mask - iterator for blob returned by DRM_XE_DEVICE_QUERY_GT_TOPOLOGY
Beside adding helpers patchset also shows their usefullness.
Cleaner code and diffstat of 85 insertions vs 282 deletions hopefuly
proves usability of these helpers.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
Changes in v4:
- removed can_fail arg from xe_query_device and add xe_query_device_may_fail,
- squashed last three patches into one,
- added tags,
- Link to v3: https://lore.kernel.org/r/20251117-xe_query_helpers-v3-0-25d984ae58cb@intel.com
Changes in v3:
- added sanity check for len > 0 in xe_hwconfig_get_u32 (Priyanka),
- in xe_query_device treat returned query.size == 0 as unsupported query,
- with above change allow query for HWCONFIG to fail - case of old platforms (ADL-S),
- added R-B tag for patch 2,
- Link to v2: https://lore.kernel.org/r/20251107-xe_query_helpers-v2-0-ec66ba6af1c1@intel.com
Changes in v2:
- add xe_query_device arg to allow fail without assert,
because EU_STALL and OA_UNITS are not implemented on old platforms,
- also return NULL if data size is 0 - case of hwconfig on old platforms,
- split first patch to implementation and conversion,
- Link to v1: https://lore.kernel.org/r/20251106-xe_query_helpers-v1-0-d761a944c237@intel.com
---
Andrzej Hajda (6):
lib/xe_query: add helper to get first value of hwconfig
tests/intel/xe_eudebug_online: use helper to get hwconfig value
lib/xe/xe_query: introduce helpers for device query
lib/xe/xe_query: use recently introduced helper to query device
lib/xe/xe_query: introduce iterator for GT topology masks
xe/treewide: use xe_query helpers for query GT topology
lib/xe/xe_oa.c | 37 ++-----
lib/xe/xe_query.c | 220 ++++++++++------------------------------
lib/xe/xe_query.h | 27 +++++
tests/intel/xe_eudebug_online.c | 41 +-------
tests/intel/xe_query.c | 69 ++++---------
5 files changed, 111 insertions(+), 283 deletions(-)
---
base-commit: 5aeea13f553d4c5882cf4af9c83c8609265200f1
change-id: 20251106-xe_query_helpers-9a49432d828d
Best regards,
--
Andrzej Hajda <andrzej.hajda@intel.com>
next reply other threads:[~2025-11-20 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 14:25 Andrzej Hajda [this message]
2025-11-20 14:25 ` [PATCH v4 1/6] lib/xe_query: add helper to get first value of hwconfig Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 2/6] tests/intel/xe_eudebug_online: use helper to get hwconfig value Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 3/6] lib/xe/xe_query: introduce helpers for device query Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 4/6] lib/xe/xe_query: use recently introduced helper to query device Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 5/6] lib/xe/xe_query: introduce iterator for GT topology masks Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 6/6] xe/treewide: use xe_query helpers for query GT topology Andrzej Hajda
2025-11-20 15:44 ` ✗ Fi.CI.BUILD: failure for lib/xe/xe_query: implement few query helpers (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120-xe_query_helpers-v4-0-2ed6dc04dd94@intel.com \
--to=andrzej.hajda@intel.com \
--cc=christoph.manszewski@intel.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=piotr.piorkowski@intel.com \
--cc=priyanka.dandamudi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).