From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
"Priyanka Dandamudi" <priyanka.dandamudi@intel.com>,
"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
"Christoph Manszewski" <christoph.manszewski@intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH v4 2/6] tests/intel/xe_eudebug_online: use helper to get hwconfig value
Date: Thu, 20 Nov 2025 15:25:39 +0100 [thread overview]
Message-ID: <20251120-xe_query_helpers-v4-2-2ed6dc04dd94@intel.com> (raw)
In-Reply-To: <20251120-xe_query_helpers-v4-0-2ed6dc04dd94@intel.com>
Recently introduced helper makes the code cleaner.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
tests/intel/xe_eudebug_online.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index e1516c202f15d9bb90d3cf0f6ed30700b5479af9..ef700c2591291f9a22849c2995c83cc5ec0ac6d9 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -1182,9 +1182,7 @@ static bool intel_gen_has_lockstep_eus(int fd)
static int query_attention_bitmask_size(int fd, int gt)
{
- uint32_t thread_count_len;
- uint32_t *thread_count_ptr;
- uint32_t threads_per_eu = 8;
+ uint32_t threads_per_eu = xe_hwconfig_get_u32(fd, INTEL_HWCONFIG_NUM_THREADS_PER_EU, 8);
struct drm_xe_query_topology_mask *c_dss = NULL, *g_dss = NULL, *eu_per_dss = NULL;
struct drm_xe_query_topology_mask *topology;
struct drm_xe_device_query query = {
@@ -1197,13 +1195,6 @@ static int query_attention_bitmask_size(int fd, int gt)
int pos = 0;
int i, last_dss_idx;
- thread_count_ptr = xe_hwconfig_lookup_value(fd, INTEL_HWCONFIG_NUM_THREADS_PER_EU,
- &thread_count_len);
- if (thread_count_ptr) {
- igt_assert(thread_count_len == 1);
- threads_per_eu = *thread_count_ptr;
- }
-
igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
igt_assert_neq(query.size, 0);
--
2.43.0
next prev parent reply other threads:[~2025-11-20 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 14:25 [PATCH v4 0/6] lib/xe/xe_query: implement few query helpers Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 1/6] lib/xe_query: add helper to get first value of hwconfig Andrzej Hajda
2025-11-20 14:25 ` Andrzej Hajda [this message]
2025-11-20 14:25 ` [PATCH v4 3/6] lib/xe/xe_query: introduce helpers for device query Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 4/6] lib/xe/xe_query: use recently introduced helper to query device Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 5/6] lib/xe/xe_query: introduce iterator for GT topology masks Andrzej Hajda
2025-11-20 14:25 ` [PATCH v4 6/6] xe/treewide: use xe_query helpers for query GT topology Andrzej Hajda
2025-11-20 15:44 ` ✗ Fi.CI.BUILD: failure for lib/xe/xe_query: implement few query helpers (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120-xe_query_helpers-v4-2-2ed6dc04dd94@intel.com \
--to=andrzej.hajda@intel.com \
--cc=christoph.manszewski@intel.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=piotr.piorkowski@intel.com \
--cc=priyanka.dandamudi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).