igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Priyanka Dandamudi" <priyanka.dandamudi@intel.com>,
	"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
	"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
	"Christoph Manszewski" <christoph.manszewski@intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH v5 1/5] tests/intel/xe_eudebug_online: use helper to get hwconfig value
Date: Fri, 21 Nov 2025 11:59:00 +0100	[thread overview]
Message-ID: <20251121-xe_query_helpers-v5-1-d69c1c160e96@intel.com> (raw)
In-Reply-To: <20251121-xe_query_helpers-v5-0-d69c1c160e96@intel.com>

Recently introduced helper makes the code cleaner.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/intel/xe_eudebug_online.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index 50d95988e6b3aa727f12e5d1c8ca52692de4d302..a5b2864a47a34b9051756174f73667bbc602e00b 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -1206,9 +1206,7 @@ static bool intel_gen_has_lockstep_eus(int fd)
 
 static int query_attention_bitmask_size(int fd, int gt)
 {
-	uint32_t thread_count_len;
-	uint32_t *thread_count_ptr;
-	uint32_t threads_per_eu = 8;
+	uint32_t threads_per_eu = xe_hwconfig_lookup_value_u32(fd, INTEL_HWCONFIG_NUM_THREADS_PER_EU);
 	struct drm_xe_query_topology_mask *c_dss = NULL, *g_dss = NULL, *eu_per_dss = NULL;
 	struct drm_xe_query_topology_mask *topology;
 	struct drm_xe_device_query query = {
@@ -1221,13 +1219,6 @@ static int query_attention_bitmask_size(int fd, int gt)
 	int pos = 0;
 	int i, last_dss_idx;
 
-	thread_count_ptr = xe_hwconfig_lookup_value(fd, INTEL_HWCONFIG_NUM_THREADS_PER_EU,
-						    &thread_count_len);
-	if (thread_count_ptr) {
-		igt_assert(thread_count_len == 1);
-		threads_per_eu = *thread_count_ptr;
-	}
-
 	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
 	igt_assert_neq(query.size, 0);
 

-- 
2.43.0


  reply	other threads:[~2025-11-21 11:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 10:58 [PATCH v5 0/5] lib/xe/xe_query: implement few query helpers Andrzej Hajda
2025-11-21 10:59 ` Andrzej Hajda [this message]
2025-11-21 10:59 ` [PATCH v5 2/5] lib/xe/xe_query: introduce helpers for device query Andrzej Hajda
2025-11-24  8:13   ` Dandamudi, Priyanka
2025-11-24  8:55     ` Dandamudi, Priyanka
2025-11-24  9:29       ` Kamil Konieczny
2025-11-24  9:41   ` Kamil Konieczny
2025-11-21 10:59 ` [PATCH v5 3/5] lib/xe/xe_query: use recently introduced helper to query device Andrzej Hajda
2025-11-24 11:01   ` Kamil Konieczny
2025-11-21 10:59 ` [PATCH v5 4/5] lib/xe/xe_query: introduce iterator for GT topology masks Andrzej Hajda
2025-11-21 10:59 ` [PATCH v5 5/5] xe/treewide: use xe_query helpers for query GT topology Andrzej Hajda
2025-11-24 11:16   ` Kamil Konieczny
2025-11-25  3:47 ` ✓ i915.CI.BAT: success for lib/xe/xe_query: implement few query helpers (rev5) Patchwork
2025-11-25  3:48 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-25  5:44 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-25  9:48 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251121-xe_query_helpers-v5-1-d69c1c160e96@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=christoph.manszewski@intel.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=piotr.piorkowski@intel.com \
    --cc=priyanka.dandamudi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).