igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 0/5] lib/xe/xe_query: implement few query helpers
@ 2025-11-21 10:58 Andrzej Hajda
  2025-11-21 10:59 ` [PATCH v5 1/5] tests/intel/xe_eudebug_online: use helper to get hwconfig value Andrzej Hajda
                   ` (8 more replies)
  0 siblings, 9 replies; 16+ messages in thread
From: Andrzej Hajda @ 2025-11-21 10:58 UTC (permalink / raw)
  To: igt-dev
  Cc: Kamil Konieczny, Priyanka Dandamudi, Gwan-gyeong Mun,
	Piotr Piórkowski, Christoph Manszewski, Andrzej Hajda

This patchset adds following helpers to xe_query library:
- xe_query_device - encapsulates common code around DRM_IOCTL_XE_DEVICE_QUERY,
- xe_for_each_topology_mask - iterator for blob returned by DRM_XE_DEVICE_QUERY_GT_TOPOLOGY
Beside adding helpers patchset also shows their usefullness.

Cleaner code and diffstat of 85 insertions vs 282 deletions hopefuly
proves usability of these helpers.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
Changes in v5:
- Dropped patch adding xe_hwconfig_get_u32 - similar helper was just merged
- Rebased - to solve recent conflicts
- Link to v4: https://lore.kernel.org/r/20251120-xe_query_helpers-v4-0-2ed6dc04dd94@intel.com

Changes in v4:
- removed can_fail arg from xe_query_device and add xe_query_device_may_fail,
- squashed last three patches into one,
- added tags,
- Link to v3: https://lore.kernel.org/r/20251117-xe_query_helpers-v3-0-25d984ae58cb@intel.com

Changes in v3:
- added sanity check for len > 0 in xe_hwconfig_get_u32 (Priyanka),
- in xe_query_device treat returned query.size == 0 as unsupported query,
- with above change allow query for HWCONFIG to fail - case of old platforms (ADL-S),
- added R-B tag for patch 2,
- Link to v2: https://lore.kernel.org/r/20251107-xe_query_helpers-v2-0-ec66ba6af1c1@intel.com

Changes in v2:
- add xe_query_device arg to allow fail without assert,
  because EU_STALL and OA_UNITS are not implemented on old platforms,
- also return NULL if data size is 0 - case of hwconfig on old platforms,
- split first patch to implementation and conversion,
- Link to v1: https://lore.kernel.org/r/20251106-xe_query_helpers-v1-0-d761a944c237@intel.com

---
Andrzej Hajda (5):
      tests/intel/xe_eudebug_online: use helper to get hwconfig value
      lib/xe/xe_query: introduce helpers for device query
      lib/xe/xe_query: use recently introduced helper to query device
      lib/xe/xe_query: introduce iterator for GT topology masks
      xe/treewide: use xe_query helpers for query GT topology

 lib/xe/xe_oa.c                  |  37 ++------
 lib/xe/xe_query.c               | 203 +++++++---------------------------------
 lib/xe/xe_query.h               |  26 +++++
 tests/intel/xe_eudebug_online.c |  41 +-------
 tests/intel/xe_query.c          |  69 ++++----------
 5 files changed, 93 insertions(+), 283 deletions(-)
---
base-commit: 7bc8d310594c1dc1a851451845d1ea3c15fbd53d
change-id: 20251106-xe_query_helpers-9a49432d828d

Best regards,
-- 
Andrzej Hajda <andrzej.hajda@intel.com>


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2025-11-25  9:48 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-21 10:58 [PATCH v5 0/5] lib/xe/xe_query: implement few query helpers Andrzej Hajda
2025-11-21 10:59 ` [PATCH v5 1/5] tests/intel/xe_eudebug_online: use helper to get hwconfig value Andrzej Hajda
2025-11-21 10:59 ` [PATCH v5 2/5] lib/xe/xe_query: introduce helpers for device query Andrzej Hajda
2025-11-24  8:13   ` Dandamudi, Priyanka
2025-11-24  8:55     ` Dandamudi, Priyanka
2025-11-24  9:29       ` Kamil Konieczny
2025-11-24  9:41   ` Kamil Konieczny
2025-11-21 10:59 ` [PATCH v5 3/5] lib/xe/xe_query: use recently introduced helper to query device Andrzej Hajda
2025-11-24 11:01   ` Kamil Konieczny
2025-11-21 10:59 ` [PATCH v5 4/5] lib/xe/xe_query: introduce iterator for GT topology masks Andrzej Hajda
2025-11-21 10:59 ` [PATCH v5 5/5] xe/treewide: use xe_query helpers for query GT topology Andrzej Hajda
2025-11-24 11:16   ` Kamil Konieczny
2025-11-25  3:47 ` ✓ i915.CI.BAT: success for lib/xe/xe_query: implement few query helpers (rev5) Patchwork
2025-11-25  3:48 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-25  5:44 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-25  9:48 ` ✗ i915.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).